stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity
Files
cb3e361fcf63fb8eb234cb3cb771abefbe01c3f0
git.stella-ops.org/docs/implplan-blocked/audits/csproj-standards/Tools/NotifySmokeCheck/NotifySmokeCheck.md

1.2 KiB
Raw Blame History

Audit - NotifySmokeCheck

Project

  • Path: src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj
  • Module: Tools
  • Kind: Tool
  • SDK: Microsoft.NET.Sdk
  • TargetFramework: net10.0
  • Audit date (UTC): 2026-01-30

Coding Standards Findings

  • Status: FAIL
  • Nullable: enable
  • TreatWarningsAsErrors: explicit true
  • Deterministic: inherited true
  • 100-line rule violations: 1
  • Service locator usage (BuildServiceProvider/GetService): 0
  • Analyzer enforcement: missing repo-wide (see summary).

Details

  • 100-line files:
    • src/Tools/NotifySmokeCheck/NotifySmokeCheckRunner.cs (515 lines)
  • Service locator matches:
    • none

Fix Guidance

  • Split files over 100 lines into smaller types or partials.

Testing Fullness Findings

  • Status: FAIL
  • Expected layers: Unit, CLI, Offline
  • Detected test projects: src/Tools/__Tests/NotifySmokeCheck.Tests/NotifySmokeCheck.Tests.csproj [Unit]
  • Missing layers: CLI, Offline

Manual checks required

  • Observability contract tests for WebService/Worker.
  • Offline execution (tests must run without network access).

Fix Guidance

  • Add offline/airgap coverage with fixtures only.
  • Add CLI tests for exit codes and golden output.