Files
git.stella-ops.org/docs-archived/implplan-blocked/audits/csproj-standards/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.md
2026-02-19 22:07:11 +02:00

2.0 KiB

Audit - StellaOps.BinaryIndex.WebService

Project

  • Path: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
  • Module: BinaryIndex
  • Kind: WebService
  • SDK: Microsoft.NET.Sdk.Web
  • TargetFramework: net10.0
  • Audit date (UTC): 2026-01-30

Coding Standards Findings

  • Status: FAIL
  • Nullable: enable
  • TreatWarningsAsErrors: explicit true
  • Deterministic: inherited true
  • 100-line rule violations: 7
  • Service locator usage (BuildServiceProvider/GetService): 0
  • Analyzer enforcement: missing repo-wide (see summary).

Details

  • 100-line files:
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/GoldenSetController.cs (775 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/PatchCoverageController.cs (331 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs (322 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Middleware/RateLimitingMiddleware.cs (275 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Telemetry/ResolutionTelemetry.cs (218 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Services/CachedResolutionService.cs (189 lines)
    • src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/ResolutionController.cs (174 lines)
  • Service locator matches:
    • none

Fix Guidance

  • Split files over 100 lines into smaller types or partials.

Testing Fullness Findings

  • Status: FAIL
  • Expected layers: Unit, Integration, Security, Offline
  • Detected test projects: src/BinaryIndex/__Tests/StellaOps.BinaryIndex.WebService.Tests/StellaOps.BinaryIndex.WebService.Tests.csproj [Unit]
  • Missing layers: Integration, Security, Offline

Manual checks required

  • Observability contract tests for WebService/Worker.
  • Offline execution (tests must run without network access).

Fix Guidance

  • Add integration tests for cross-component flows.
  • Add security tests for authn/authz or input validation.
  • Add offline/airgap coverage with fixtures only.