Files
git.stella-ops.org/docs-archived/implplan-blocked/audits/csproj-standards/AirGap/StellaOps.AirGap.Controller/StellaOps.AirGap.Controller.md
2026-02-19 22:07:11 +02:00

1.8 KiB

Audit - StellaOps.AirGap.Controller

Project

  • Path: src/AirGap/StellaOps.AirGap.Controller/StellaOps.AirGap.Controller.csproj
  • Module: AirGap
  • Kind: WebService
  • SDK: Microsoft.NET.Sdk.Web
  • TargetFramework: net10.0
  • Audit date (UTC): 2026-01-30

Coding Standards Findings

  • Status: FAIL
  • Nullable: enable
  • TreatWarningsAsErrors: explicit true
  • Deterministic: inherited true
  • 100-line rule violations: 6
  • Service locator usage (BuildServiceProvider/GetService): 0
  • Analyzer enforcement: missing repo-wide (see summary).

Details

  • 100-line files:
    • src/AirGap/StellaOps.AirGap.Controller/Endpoints/AirGapEndpoints.cs (267 lines)
    • src/AirGap/StellaOps.AirGap.Controller/Services/AirGapTelemetry.cs (177 lines)
    • src/AirGap/StellaOps.AirGap.Controller/Services/AirGapStartupDiagnosticsHostedService.cs (174 lines)
    • src/AirGap/StellaOps.AirGap.Controller/Services/AirGapStateService.cs (118 lines)
    • src/AirGap/StellaOps.AirGap.Controller/Endpoints/RequestValidation.cs (107 lines)
    • src/AirGap/StellaOps.AirGap.Controller/Auth/HeaderScopeAuthenticationHandler.cs (105 lines)
  • Service locator matches:
    • none

Fix Guidance

  • Split files over 100 lines into smaller types or partials.

Testing Fullness Findings

  • Status: FAIL
  • Expected layers: Unit, Integration, Security, Offline
  • Detected test projects: src/AirGap/__Tests/StellaOps.AirGap.Controller.Tests/StellaOps.AirGap.Controller.Tests.csproj [Unit]
  • Missing layers: Integration, Security, Offline

Manual checks required

  • Observability contract tests for WebService/Worker.
  • Offline execution (tests must run without network access).

Fix Guidance

  • Add integration tests for cross-component flows.
  • Add security tests for authn/authz or input validation.
  • Add offline/airgap coverage with fixtures only.