git.stella-ops.org/docs/implplan-blocked/audits/csproj-standards/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.md

Audit - StellaOps.Unknowns.Services

Project

• Path: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
• Module: Unknowns
• Kind: Service
• SDK: Microsoft.NET.Sdk
• TargetFramework: net10.0
• Audit date (UTC): 2026-01-30

Coding Standards Findings

• Status: FAIL
• Nullable: enable
• TreatWarningsAsErrors: explicit true
• Deterministic: inherited true
• 100-line rule violations: 5
• Service locator usage (BuildServiceProvider/GetService): 1
• Analyzer enforcement: missing repo-wide (see summary).

Details

• 100-line files:
  • src/Unknowns/StellaOps.Unknowns.Services/UnknownsLifecycleService.cs (425 lines)
  • src/Unknowns/StellaOps.Unknowns.Services/GreyQueueWatchdogService.cs (336 lines)
  • src/Unknowns/StellaOps.Unknowns.Services/UnknownsMetricsService.cs (332 lines)
  • src/Unknowns/StellaOps.Unknowns.Services/UnknownsSlaMonitorService.cs (225 lines)
  • src/Unknowns/StellaOps.Unknowns.Services/UnknownsSlaHealthCheck.cs (139 lines)
• Service locator matches:
  • src/Unknowns/StellaOps.Unknowns.Services/UnknownsSlaHealthCheck.cs:135 sp.GetService()),

Fix Guidance

• Split files over 100 lines into smaller types or partials.
• Replace service locator usage with constructor injection.

Testing Fullness Findings

• Status: FAIL
• Expected layers: Unit
• Detected test projects: none
• Missing layers: Unit

Manual checks required

• Observability contract tests for WebService/Worker.
• Offline execution (tests must run without network access).

Fix Guidance

• Add a unit test project named <Project>.Tests (or document exception).