stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity
Files
9ca2de05dff9c7db11eb49df6d4e47bbfe7a99f6
git.stella-ops.org/docs/implplan-blocked/audits/csproj-standards/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.md

1.6 KiB
Raw Blame History

Audit - StellaOps.Tools.GoldenPairs

Project

  • Path: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
  • Module: Tools
  • Kind: Tool
  • SDK: Microsoft.NET.Sdk
  • TargetFramework: net10.0
  • Audit date (UTC): 2026-01-30

Coding Standards Findings

  • Status: FAIL
  • Nullable: enable
  • TreatWarningsAsErrors: explicit true
  • Deterministic: inherited true
  • 100-line rule violations: 5
  • Service locator usage (BuildServiceProvider/GetService): 1
  • Analyzer enforcement: missing repo-wide (see summary).

Details

  • 100-line files:
    • src/Tools/GoldenPairs/GoldenPairsApp.cs (319 lines)
    • src/Tools/GoldenPairs/Services/DiffPipelineService.cs (288 lines)
    • src/Tools/GoldenPairs/Services/PackageMirrorService.cs (285 lines)
    • src/Tools/GoldenPairs/Services/GoldenPairLoader.cs (210 lines)
    • src/Tools/GoldenPairs/Models/GoldenPairMetadata.cs (172 lines)
  • Service locator matches:
    • src/Tools/GoldenPairs/Services/GoldenPairsServiceFactory.cs:49 return services.BuildServiceProvider();

Fix Guidance

  • Split files over 100 lines into smaller types or partials.
  • Replace service locator usage with constructor injection.

Testing Fullness Findings

  • Status: FAIL
  • Expected layers: Unit, CLI, Offline
  • Detected test projects: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj [Unit]
  • Missing layers: CLI, Offline

Manual checks required

  • Observability contract tests for WebService/Worker.
  • Offline execution (tests must run without network access).

Fix Guidance

  • Add offline/airgap coverage with fixtures only.
  • Add CLI tests for exit codes and golden output.