Files
2026-02-19 22:07:11 +02:00

1.6 KiB

Audit - StellaOps.Plugin.Testing

Project

  • Path: src/Plugin/StellaOps.Plugin.Testing/StellaOps.Plugin.Testing.csproj
  • Module: Plugin
  • Kind: Plugin
  • SDK: Microsoft.NET.Sdk
  • TargetFramework: net10.0
  • Audit date (UTC): 2026-01-30

Coding Standards Findings

  • Status: FAIL
  • Nullable: enable
  • TreatWarningsAsErrors: explicit true
  • Deterministic: inherited true
  • 100-line rule violations: 3
  • Service locator usage (BuildServiceProvider/GetService): 1
  • Analyzer enforcement: missing repo-wide (see summary).

Details

  • 100-line files:
    • src/Plugin/StellaOps.Plugin.Testing/TestHttpClientFactory.cs (224 lines)
    • src/Plugin/StellaOps.Plugin.Testing/TestPluginLogger.cs (200 lines)
    • src/Plugin/StellaOps.Plugin.Testing/TestPluginConfiguration.cs (124 lines)
  • Service locator matches:
    • src/Plugin/StellaOps.Plugin.Testing/TestPluginServices.cs:42 public T? GetService() where T : class

Fix Guidance

  • Split files over 100 lines into smaller types or partials.
  • Replace service locator usage with constructor injection.

Testing Fullness Findings

  • Status: FAIL
  • Expected layers: Unit, Integration, Security, Offline
  • Detected test projects: none
  • Missing layers: Unit, Integration, Security, Offline

Manual checks required

  • Observability contract tests for WebService/Worker.
  • Offline execution (tests must run without network access).

Fix Guidance

  • Add a unit test project named <Project>.Tests (or document exception).
  • Add integration tests for cross-component flows.
  • Add security tests for authn/authz or input validation.
  • Add offline/airgap coverage with fixtures only.