Fix tab content projection on Deployments and Releases pages
Both pages used self-closing <stella-page-tabs ... /> with content rendered as sibling elements OUTSIDE the component. This caused an empty tabpanel with content floating below on the page background. Fix: wrap tab-conditional content INSIDE <stella-page-tabs>...</stella-page-tabs> so it projects into the tabpanel slot. Now the tab bar and its content share the same visual container with the correct border and background. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -170,7 +170,6 @@ function deriveOutcomeIcon(status: string): string {
|
||||
ariaLabel="Run list views"
|
||||
>
|
||||
<app-page-action-outlet tabBarAction />
|
||||
</stella-page-tabs>
|
||||
|
||||
@if (viewMode() === 'approvals') {
|
||||
<!-- Approvals tab content -->
|
||||
@@ -299,6 +298,7 @@ function deriveOutcomeIcon(status: string): string {
|
||||
}
|
||||
}
|
||||
}
|
||||
</stella-page-tabs>
|
||||
</section>
|
||||
`,
|
||||
styles: [`
|
||||
|
||||
@@ -81,7 +81,7 @@ export interface PipelineRelease {
|
||||
</header>
|
||||
|
||||
<stella-page-tabs [tabs]="releaseTabs" [activeTab]="activeTab()" urlParam="tab"
|
||||
(tabChange)="activeTab.set($event)" ariaLabel="Releases tabs" />
|
||||
(tabChange)="activeTab.set($event)" ariaLabel="Releases tabs">
|
||||
|
||||
@if (activeTab() === 'releases') {
|
||||
<!-- Pipeline -->
|
||||
@@ -265,6 +265,7 @@ export interface PipelineRelease {
|
||||
@if (activeTab() === 'versions') {
|
||||
<app-release-list [embedded]="true" />
|
||||
}
|
||||
</stella-page-tabs>
|
||||
|
||||
<app-confirm-dialog #approveConfirm
|
||||
title="Approve Release"
|
||||
|
||||
Reference in New Issue
Block a user