# Audit - StellaOps.Router.Plugin.Unified ## Project - Path: `src/Router/StellaOps.Router.Plugin.Unified/StellaOps.Router.Plugin.Unified.csproj` - Module: `Router` - Kind: `Plugin` - SDK: `Microsoft.NET.Sdk` - TargetFramework: `net10.0` - Audit date (UTC): 2026-01-30 ## Coding Standards Findings - Status: FAIL - Nullable: enable - TreatWarningsAsErrors: explicit true - Deterministic: inherited true - 100-line rule violations: 4 - Service locator usage (BuildServiceProvider/GetService): 5 - Analyzer enforcement: missing repo-wide (see summary). ### Details - 100-line files: - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs` (305 lines) - `src/Router/StellaOps.Router.Plugin.Unified/TransportClientAdapter.cs` (187 lines) - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapterFactory.cs` (156 lines) - `src/Router/StellaOps.Router.Plugin.Unified/TransportServerAdapter.cs` (115 lines) - Service locator matches: - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs`:88 if (!_inner.IsAvailable(services.BuildServiceProvider())) - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs`:99 _serviceProvider = services.BuildServiceProvider(); - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs`:186 var server = _serviceProvider!.GetService(); - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs`:213 var client = _serviceProvider!.GetService(); - `src/Router/StellaOps.Router.Plugin.Unified/TransportPluginAdapter.cs`:246 var client = _serviceProvider!.GetService(); ### Fix Guidance - Split files over 100 lines into smaller types or partials. - Replace service locator usage with constructor injection. ## Testing Fullness Findings - Status: FAIL - Expected layers: Unit, Integration, Security, Offline - Detected test projects: none - Missing layers: Unit, Integration, Security, Offline ### Manual checks required - Observability contract tests for WebService/Worker. - Offline execution (tests must run without network access). ### Fix Guidance - Add a unit test project named `.Tests` (or document exception). - Add integration tests for cross-component flows. - Add security tests for authn/authz or input validation. - Add offline/airgap coverage with fixtures only.