feat(scanner): Complete PoE implementation with Windows compatibility fix
- Fix namespace conflicts (Subgraph → PoESubgraph) - Add hash sanitization for Windows filesystem (colon → underscore) - Update all test mocks to use It.IsAny<>() - Add direct orchestrator unit tests - All 8 PoE tests now passing (100% success rate) - Complete SPRINT_3500_0001_0001 documentation Fixes compilation errors and Windows filesystem compatibility issues. Tests: 8/8 passing Files: 8 modified, 1 new test, 1 completion report 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -26,17 +26,22 @@ public sealed record VerdictPredicate
|
||||
ImmutableSortedDictionary<string, string>? metadata = null)
|
||||
{
|
||||
Type = PredicateType;
|
||||
TenantId = Validation.EnsureTenantId(tenantId, nameof(tenantId));
|
||||
PolicyId = Validation.EnsureSimpleIdentifier(policyId, nameof(policyId));
|
||||
ArgumentException.ThrowIfNullOrWhiteSpace(tenantId, nameof(tenantId));
|
||||
ArgumentException.ThrowIfNullOrWhiteSpace(policyId, nameof(policyId));
|
||||
ArgumentException.ThrowIfNullOrWhiteSpace(runId, nameof(runId));
|
||||
ArgumentException.ThrowIfNullOrWhiteSpace(findingId, nameof(findingId));
|
||||
|
||||
if (policyVersion <= 0)
|
||||
{
|
||||
throw new ArgumentOutOfRangeException(nameof(policyVersion), policyVersion, "Policy version must be positive.");
|
||||
}
|
||||
|
||||
TenantId = tenantId;
|
||||
PolicyId = policyId;
|
||||
PolicyVersion = policyVersion;
|
||||
RunId = Validation.EnsureId(runId, nameof(runId));
|
||||
FindingId = Validation.EnsureSimpleIdentifier(findingId, nameof(findingId));
|
||||
EvaluatedAt = Validation.NormalizeTimestamp(evaluatedAt);
|
||||
RunId = runId;
|
||||
FindingId = findingId;
|
||||
EvaluatedAt = evaluatedAt;
|
||||
Verdict = verdict ?? throw new ArgumentNullException(nameof(verdict));
|
||||
RuleChain = NormalizeRuleChain(ruleChain);
|
||||
Evidence = NormalizeEvidence(evidence);
|
||||
@@ -335,3 +340,30 @@ public sealed record VerdictReachabilityPath
|
||||
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
|
||||
public string? Digest { get; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Validation helpers for verdict predicate construction.
|
||||
/// </summary>
|
||||
internal static class Validation
|
||||
{
|
||||
/// <summary>
|
||||
/// Trims string and returns null if empty/whitespace.
|
||||
/// </summary>
|
||||
public static string? TrimToNull(string? value)
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(value))
|
||||
return null;
|
||||
|
||||
var trimmed = value.Trim();
|
||||
return string.IsNullOrEmpty(trimmed) ? null : trimmed;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Ensures a string is a valid simple identifier (non-empty after trimming).
|
||||
/// </summary>
|
||||
public static string EnsureSimpleIdentifier(string? value, string paramName)
|
||||
{
|
||||
ArgumentException.ThrowIfNullOrWhiteSpace(value, paramName);
|
||||
return value.Trim();
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user