feat(crypto): Complete Phase 2 - Configuration-driven crypto architecture with 100% compliance
## Summary
This commit completes Phase 2 of the configuration-driven crypto architecture, achieving
100% crypto compliance by eliminating all hardcoded cryptographic implementations.
## Key Changes
### Phase 1: Plugin Loader Infrastructure
- **Plugin Discovery System**: Created StellaOps.Cryptography.PluginLoader with manifest-based loading
- **Configuration Model**: Added CryptoPluginConfiguration with regional profiles support
- **Dependency Injection**: Extended DI to support plugin-based crypto provider registration
- **Regional Configs**: Created appsettings.crypto.{international,russia,eu,china}.yaml
- **CI Workflow**: Added .gitea/workflows/crypto-compliance.yml for audit enforcement
### Phase 2: Code Refactoring
- **API Extension**: Added ICryptoProvider.CreateEphemeralVerifier for verification-only scenarios
- **Plugin Implementation**: Created OfflineVerificationCryptoProvider with ephemeral verifier support
- Supports ES256/384/512, RS256/384/512, PS256/384/512
- SubjectPublicKeyInfo (SPKI) public key format
- **100% Compliance**: Refactored DsseVerifier to remove all BouncyCastle cryptographic usage
- **Unit Tests**: Created OfflineVerificationProviderTests with 39 passing tests
- **Documentation**: Created comprehensive security guide at docs/security/offline-verification-crypto-provider.md
- **Audit Infrastructure**: Created scripts/audit-crypto-usage.ps1 for static analysis
### Testing Infrastructure (TestKit)
- **Determinism Gate**: Created DeterminismGate for reproducibility validation
- **Test Fixtures**: Added PostgresFixture and ValkeyFixture using Testcontainers
- **Traits System**: Implemented test lane attributes for parallel CI execution
- **JSON Assertions**: Added CanonicalJsonAssert for deterministic JSON comparisons
- **Test Lanes**: Created test-lanes.yml workflow for parallel test execution
### Documentation
- **Architecture**: Created CRYPTO_CONFIGURATION_DRIVEN_ARCHITECTURE.md master plan
- **Sprint Tracking**: Created SPRINT_1000_0007_0002_crypto_refactoring.md (COMPLETE)
- **API Documentation**: Updated docs2/cli/crypto-plugins.md and crypto.md
- **Testing Strategy**: Created testing strategy documents in docs/implplan/SPRINT_5100_0007_*
## Compliance & Testing
- ✅ Zero direct System.Security.Cryptography usage in production code
- ✅ All crypto operations go through ICryptoProvider abstraction
- ✅ 39/39 unit tests passing for OfflineVerificationCryptoProvider
- ✅ Build successful (AirGap, Crypto plugin, DI infrastructure)
- ✅ Audit script validates crypto boundaries
## Files Modified
**Core Crypto Infrastructure:**
- src/__Libraries/StellaOps.Cryptography/CryptoProvider.cs (API extension)
- src/__Libraries/StellaOps.Cryptography/CryptoSigningKey.cs (verification-only constructor)
- src/__Libraries/StellaOps.Cryptography/EcdsaSigner.cs (fixed ephemeral verifier)
**Plugin Implementation:**
- src/__Libraries/StellaOps.Cryptography.Plugin.OfflineVerification/ (new)
- src/__Libraries/StellaOps.Cryptography.PluginLoader/ (new)
**Production Code Refactoring:**
- src/AirGap/StellaOps.AirGap.Importer/Validation/DsseVerifier.cs (100% compliant)
**Tests:**
- src/__Libraries/__Tests/StellaOps.Cryptography.Plugin.OfflineVerification.Tests/ (new, 39 tests)
- src/__Libraries/__Tests/StellaOps.Cryptography.PluginLoader.Tests/ (new)
**Configuration:**
- etc/crypto-plugins-manifest.json (plugin registry)
- etc/appsettings.crypto.*.yaml (regional profiles)
**Documentation:**
- docs/security/offline-verification-crypto-provider.md (600+ lines)
- docs/implplan/CRYPTO_CONFIGURATION_DRIVEN_ARCHITECTURE.md (master plan)
- docs/implplan/SPRINT_1000_0007_0002_crypto_refactoring.md (Phase 2 complete)
## Next Steps
Phase 3: Docker & CI/CD Integration
- Create multi-stage Dockerfiles with all plugins
- Build regional Docker Compose files
- Implement runtime configuration selection
- Add deployment validation scripts
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
master
@@ -0,0 +1,156 @@
|
||||
using FluentAssertions;
|
||||
using Microsoft.Extensions.Logging.Abstractions;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Cryptography.PluginLoader.Tests;
|
||||
|
||||
public class CryptoPluginLoaderTests
|
||||
{
|
||||
[Fact]
|
||||
public void Constructor_WithNullConfiguration_ThrowsArgumentNullException()
|
||||
{
|
||||
// Arrange & Act
|
||||
Action act = () => new CryptoPluginLoader(null!, NullLogger<CryptoPluginLoader>.Instance);
|
||||
|
||||
// Assert
|
||||
act.Should().Throw<ArgumentNullException>()
|
||||
.WithParameterName("configuration");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadProviders_WithEmptyEnabledList_ReturnsEmptyCollection()
|
||||
{
|
||||
// Arrange
|
||||
var configuration = new CryptoPluginConfiguration
|
||||
{
|
||||
ManifestPath = CreateTestManifest(),
|
||||
DiscoveryMode = "explicit",
|
||||
Enabled = new List<EnabledPluginEntry>(),
|
||||
RequireAtLeastOne = false
|
||||
};
|
||||
|
||||
var loader = new CryptoPluginLoader(configuration, NullLogger<CryptoPluginLoader>.Instance);
|
||||
|
||||
// Act
|
||||
var providers = loader.LoadProviders();
|
||||
|
||||
// Assert
|
||||
providers.Should().BeEmpty();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadProviders_WithMissingManifest_ThrowsFileNotFoundException()
|
||||
{
|
||||
// Arrange
|
||||
var configuration = new CryptoPluginConfiguration
|
||||
{
|
||||
ManifestPath = "/nonexistent/path/manifest.json",
|
||||
DiscoveryMode = "explicit"
|
||||
};
|
||||
|
||||
var loader = new CryptoPluginLoader(configuration, NullLogger<CryptoPluginLoader>.Instance);
|
||||
|
||||
// Act
|
||||
Action act = () => loader.LoadProviders();
|
||||
|
||||
// Assert
|
||||
act.Should().Throw<FileNotFoundException>()
|
||||
.WithMessage("*manifest.json*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadProviders_WithRequireAtLeastOneAndNoProviders_ThrowsCryptoPluginLoadException()
|
||||
{
|
||||
// Arrange
|
||||
var configuration = new CryptoPluginConfiguration
|
||||
{
|
||||
ManifestPath = CreateTestManifest(),
|
||||
DiscoveryMode = "explicit",
|
||||
Enabled = new List<EnabledPluginEntry>(),
|
||||
RequireAtLeastOne = true
|
||||
};
|
||||
|
||||
var loader = new CryptoPluginLoader(configuration, NullLogger<CryptoPluginLoader>.Instance);
|
||||
|
||||
// Act
|
||||
Action act = () => loader.LoadProviders();
|
||||
|
||||
// Assert
|
||||
act.Should().Throw<CryptoPluginLoadException>()
|
||||
.WithMessage("*at least one provider*");
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LoadProviders_WithDisabledPattern_FiltersMatchingPlugins()
|
||||
{
|
||||
// Arrange
|
||||
var configuration = new CryptoPluginConfiguration
|
||||
{
|
||||
ManifestPath = CreateTestManifest(),
|
||||
DiscoveryMode = "auto",
|
||||
Disabled = new List<string> { "test.*" },
|
||||
RequireAtLeastOne = false
|
||||
};
|
||||
|
||||
var loader = new CryptoPluginLoader(configuration, NullLogger<CryptoPluginLoader>.Instance);
|
||||
|
||||
// Act
|
||||
var providers = loader.LoadProviders();
|
||||
|
||||
// Assert
|
||||
providers.Should().NotContain(p => p.Name.StartsWith("test.", StringComparison.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
private static string CreateTestManifest()
|
||||
{
|
||||
var tempPath = Path.Combine(Path.GetTempPath(), $"test-manifest-{Guid.NewGuid()}.json");
|
||||
var manifestContent = @"{
|
||||
""version"": ""1.0"",
|
||||
""plugins"": []
|
||||
}";
|
||||
File.WriteAllText(tempPath, manifestContent);
|
||||
return tempPath;
|
||||
}
|
||||
}
|
||||
|
||||
public class CryptoPluginConfigurationTests
|
||||
{
|
||||
[Fact]
|
||||
public void Constructor_SetsDefaultValues()
|
||||
{
|
||||
// Arrange & Act
|
||||
var config = new CryptoPluginConfiguration();
|
||||
|
||||
// Assert
|
||||
config.ManifestPath.Should().Be("/etc/stellaops/crypto-plugins-manifest.json");
|
||||
config.DiscoveryMode.Should().Be("explicit");
|
||||
config.FailOnMissingPlugin.Should().BeTrue();
|
||||
config.RequireAtLeastOne.Should().BeTrue();
|
||||
config.Enabled.Should().NotBeNull().And.BeEmpty();
|
||||
config.Disabled.Should().NotBeNull().And.BeEmpty();
|
||||
}
|
||||
}
|
||||
|
||||
public class CryptoPluginManifestTests
|
||||
{
|
||||
[Fact]
|
||||
public void CryptoPluginDescriptor_WithRequiredProperties_IsValid()
|
||||
{
|
||||
// Arrange & Act
|
||||
var descriptor = new CryptoPluginDescriptor
|
||||
{
|
||||
Id = "test",
|
||||
Name = "TestProvider",
|
||||
Assembly = "Test.dll",
|
||||
Type = "Test.TestProvider"
|
||||
};
|
||||
|
||||
// Assert
|
||||
descriptor.Id.Should().Be("test");
|
||||
descriptor.Name.Should().Be("TestProvider");
|
||||
descriptor.Assembly.Should().Be("Test.dll");
|
||||
descriptor.Type.Should().Be("Test.TestProvider");
|
||||
descriptor.Priority.Should().Be(50); // Default priority
|
||||
descriptor.EnabledByDefault.Should().BeTrue();
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,27 @@
|
||||
<Project Sdk="Microsoft.NET.Sdk">
|
||||
|
||||
<PropertyGroup>
|
||||
<TargetFramework>net10.0</TargetFramework>
|
||||
<LangVersion>preview</LangVersion>
|
||||
<Nullable>enable</Nullable>
|
||||
<ImplicitUsings>enable</ImplicitUsings>
|
||||
<IsPackable>false</IsPackable>
|
||||
<IsTestProject>true</IsTestProject>
|
||||
</PropertyGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<PackageReference Include="xunit" Version="2.9.2" />
|
||||
<PackageReference Include="xunit.runner.visualstudio" Version="2.8.2">
|
||||
<PrivateAssets>all</PrivateAssets>
|
||||
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
|
||||
</PackageReference>
|
||||
<PackageReference Include="Moq" Version="4.20.72" />
|
||||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
|
||||
<PackageReference Include="FluentAssertions" Version="7.0.0" />
|
||||
</ItemGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<ProjectReference Include="..\StellaOps.Cryptography.PluginLoader\StellaOps.Cryptography.PluginLoader.csproj" />
|
||||
</ItemGroup>
|
||||
|
||||
</Project>
|
||||
Reference in New Issue
Block a user