audit, advisories and doctors/setup work

This commit is contained in:
master
2026-01-13 18:53:39 +02:00
parent 9ca7cb183e
commit d7be6ba34b
811 changed files with 54242 additions and 4056 deletions

View File

@@ -0,0 +1,18 @@
# Policy Tools Tests Charter
## Mission
Validate policy tool runner behavior and deterministic outputs.
## Responsibilities
- Keep tests deterministic and offline-friendly.
- Use local fixtures; avoid network calls.
- Track task status in `TASKS.md`.
## Required Reading
- `docs/modules/policy/architecture.md`
- `docs/modules/platform/architecture-overview.md`
## Working Agreement
- 1. Update task status in the sprint file and local `TASKS.md`.
- 2. Prefer fixed timestamps and stable temp paths.
- 3. Add tests for new runner behaviors and summary outputs.

View File

@@ -0,0 +1,35 @@
using System.IO;
using System.Linq;
using System.Threading;
using System.Threading.Tasks;
using StellaOps.TestKit;
using Xunit;
namespace StellaOps.Policy.Tools.Tests;
public sealed class PolicySchemaExporterRunnerTests
{
[Trait("Category", TestCategories.Unit)]
[Fact]
public async Task RunAsync_WritesLfLineEndings()
{
using var temp = new TempDirectory("schema-export");
var runner = new PolicySchemaExporterRunner();
var options = new PolicySchemaExportOptions
{
OutputDirectory = temp.RootPath
};
var exitCode = await runner.RunAsync(options, CancellationToken.None);
Assert.Equal(0, exitCode);
var export = PolicySchemaExporterSchema.BuildExports().First();
var outputPath = Path.Combine(temp.RootPath, export.FileName);
var bytes = await File.ReadAllBytesAsync(outputPath, CancellationToken.None);
Assert.True(bytes.Length > 1);
Assert.Equal((byte)'\n', bytes[^1]);
Assert.NotEqual((byte)'\r', bytes[^2]);
}
}

View File

@@ -0,0 +1,181 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Text.Json;
using System.Threading;
using System.Threading.Tasks;
using StellaOps.TestKit;
using Xunit;
namespace StellaOps.Policy.Tools.Tests;
public sealed class PolicySimulationSmokeRunnerTests
{
private const string PolicyJson = "{\n \"version\": \"1.0\",\n \"rules\": [\n {\n \"name\": \"block-low\",\n \"action\": \"block\",\n \"severity\": [\"low\"]\n }\n ]\n}\n";
[Trait("Category", TestCategories.Unit)]
[Fact]
public async Task RunAsync_ReportsInvalidSeverity()
{
using var temp = new TempDirectory("policy-sim-invalid-severity");
WritePolicy(temp.RootPath);
var scenario = new PolicySimulationScenario
{
Name = "invalid-severity",
PolicyPath = "policy.json",
Findings = new List<ScenarioFinding>
{
new() { FindingId = "F-1", Severity = "NotASeverity" }
},
ExpectedDiffs = new List<ScenarioExpectedDiff>()
};
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
var outputRoot = Path.Combine(temp.RootPath, "out");
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
var runner = new PolicySimulationSmokeRunner();
var exitCode = await runner.RunAsync(options, CancellationToken.None);
Assert.Equal(1, exitCode);
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
var entry = document.RootElement.EnumerateArray().Single();
Assert.False(entry.GetProperty("Success").GetBoolean());
var failures = entry.GetProperty("Failures")
.EnumerateArray()
.Select(value => value.GetString())
.ToArray();
Assert.Contains("Scenario 'invalid-severity' finding 'F-1' has invalid severity 'NotASeverity'.", failures);
}
[Trait("Category", TestCategories.Unit)]
[Fact]
public async Task RunAsync_ReportsInvalidBaselineStatus()
{
using var temp = new TempDirectory("policy-sim-invalid-status");
WritePolicy(temp.RootPath);
var scenario = new PolicySimulationScenario
{
Name = "invalid-status",
PolicyPath = "policy.json",
Findings = new List<ScenarioFinding>
{
new() { FindingId = "F-1", Severity = "Low" }
},
ExpectedDiffs = new List<ScenarioExpectedDiff>(),
Baseline = new List<ScenarioBaseline>
{
new() { FindingId = "F-1", Status = "BadStatus" }
}
};
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
var outputRoot = Path.Combine(temp.RootPath, "out");
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
var runner = new PolicySimulationSmokeRunner();
var exitCode = await runner.RunAsync(options, CancellationToken.None);
Assert.Equal(1, exitCode);
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
var entry = document.RootElement.EnumerateArray().Single();
Assert.False(entry.GetProperty("Success").GetBoolean());
var failures = entry.GetProperty("Failures")
.EnumerateArray()
.Select(value => value.GetString())
.ToArray();
Assert.Contains("Scenario 'invalid-status' baseline 'F-1' has invalid status 'BadStatus'.", failures);
}
[Trait("Category", TestCategories.Unit)]
[Fact]
public async Task RunAsync_SortsActualStatusesInSummary()
{
using var temp = new TempDirectory("policy-sim-ordering");
WritePolicy(temp.RootPath);
var scenario = new PolicySimulationScenario
{
Name = "ordering",
PolicyPath = "policy.json",
Findings = new List<ScenarioFinding>
{
new() { FindingId = "b", Severity = "Low" },
new() { FindingId = "a", Severity = "Low" }
},
ExpectedDiffs = new List<ScenarioExpectedDiff>
{
new() { FindingId = "b", Status = "Blocked" },
new() { FindingId = "a", Status = "Blocked" }
}
};
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
var outputRoot = Path.Combine(temp.RootPath, "out");
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
var runner = new PolicySimulationSmokeRunner();
var exitCode = await runner.RunAsync(options, CancellationToken.None);
Assert.Equal(0, exitCode);
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
var entry = document.RootElement.EnumerateArray().Single();
var actualStatuses = entry.GetProperty("ActualStatuses").EnumerateObject().Select(pair => pair.Name).ToArray();
Assert.Equal(new[] { "a", "b" }, actualStatuses);
}
[Trait("Category", TestCategories.Unit)]
[Fact]
public void ResolveFixedTime_UsesDefaultWhenMissing()
{
var resolved = PolicySimulationSmokeDefaults.ResolveFixedTime(null);
Assert.Equal(PolicySimulationSmokeDefaults.DefaultFixedTime, resolved);
}
private static PolicySimulationSmokeOptions BuildOptions(string scenarioRoot, string outputRoot, string repoRoot)
=> new()
{
ScenarioRoot = scenarioRoot,
OutputDirectory = outputRoot,
RepoRoot = repoRoot,
FixedTime = new DateTimeOffset(2025, 1, 1, 0, 0, 0, TimeSpan.Zero)
};
private static void WritePolicy(string rootPath)
{
var policyPath = Path.Combine(rootPath, "policy.json");
File.WriteAllText(policyPath, PolicyJson);
}
private static string WriteScenario(string rootPath, PolicySimulationScenario scenario)
{
var scenarioRoot = Path.Combine(rootPath, "scenarios");
Directory.CreateDirectory(scenarioRoot);
var scenarioPath = Path.Combine(scenarioRoot, "scenario.json");
var scenarioJson = JsonSerializer.Serialize(
scenario,
new JsonSerializerOptions(JsonSerializerDefaults.Web) { WriteIndented = true });
File.WriteAllText(scenarioPath, scenarioJson);
return scenarioRoot;
}
}

View File

@@ -0,0 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
</PropertyGroup>
<ItemGroup>
<ProjectReference Include="../../StellaOps.Policy.Tools/StellaOps.Policy.Tools.csproj" />
<ProjectReference Include="../../StellaOps.TestKit/StellaOps.TestKit.csproj" />
</ItemGroup>
</Project>

View File

@@ -0,0 +1,8 @@
# Policy Tools Tests Task Board
This board mirrors active sprint tasks for this module.
Source of truth: `docs-archived/implplan/2025-12-29-csproj-audit/SPRINT_20251229_049_BE_csproj_audit_maint_tests.md`.
| Task ID | Status | Notes |
| --- | --- | --- |
| AUDIT-0096-A | DONE | Added Policy.Tools runner coverage 2026-01-14. |

View File

@@ -0,0 +1,23 @@
using System;
using System.IO;
namespace StellaOps.Policy.Tools.Tests;
internal sealed class TempDirectory : IDisposable
{
public TempDirectory(string name)
{
RootPath = Path.Combine(Path.GetTempPath(), "stellaops-policy-tools-tests", $"{name}-{Guid.NewGuid():N}");
Directory.CreateDirectory(RootPath);
}
public string RootPath { get; }
public void Dispose()
{
if (Directory.Exists(RootPath))
{
Directory.Delete(RootPath, recursive: true);
}
}
}