stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity

Add diagonal elimination to hybrid winner refinement

Browse Source 
EliminateDiagonalSegments runs in the hybrid baseline finalization but
large diagonals can re-appear during iterative optimization. Added a
conditional elimination pass in the winner refinement when
LongDiagonalViolations > 0.

NodeSpacing=40 retained (default). Tested 42/45/50/60 — each creates
different violations because the routing is tuned for 40. Wider spacing
needs its own tuning pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
master
2026-04-01 16:22:52 +03:00
parent 162de72133
commit ccf8cb0318
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/Workflow/__Tests/StellaOps.Workflow.Renderer.Tests/DocumentProcessingWorkflowRenderingTests.Artifacts.cs
View File

@@ -40,6 +40,7 @@ public partial class DocumentProcessingWorkflowRenderingTests
var layout = await engine.LayoutAsync(graph, new WorkflowRenderLayoutRequest
{
Direction = WorkflowRenderLayoutDirection.LeftToRight,
NodeSpacing = 40,
});
var svgRenderer = new WorkflowRenderSvgRenderer();

17
src/__Libraries/StellaOps.ElkSharp/ElkEdgeRouterIterative.WinnerRefinement.Hybrid.cs
View File

@@ -258,10 +258,21 @@ internal static partial class ElkEdgeRouterIterative
ElkLayoutDiagnostics.LogProgress($"Hybrid winner refinement after final boundary-slot snap: {DescribeSolution(current)}");
}
// Eliminate large diagonal segments that may survive through the
// iterative optimization (the hybrid baseline runs EliminateDiagonalSegments
// but subsequent pipeline passes can re-introduce diagonals).
if (current.Score.LongDiagonalViolations > 0)
{
var eliminated = ElkEdgePostProcessor.EliminateDiagonalSegments(current.Edges, nodes);
var elimScore = ElkEdgeRoutingScoring.ComputeScore(eliminated, nodes);
if (elimScore.LongDiagonalViolations < current.Score.LongDiagonalViolations
&& elimScore.NodeCrossings <= current.Score.NodeCrossings)
{
current = current with { Score = elimScore, Edges = eliminated };
}
}
// Straighten short diagonal stubs at gateway boundary vertices.
// The boundary-slot snap and normalization passes may leave small
// diagonal segments (3-8px) at gateway tips. This cosmetic pass
// adjusts the adjacent bend point to make the approach orthogonal.
var straightened = ElkEdgePostProcessor.StraightenGatewayCornerDiagonals(current.Edges, nodes);
if (!ReferenceEquals(straightened, current.Edges))
{