archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,129 @@
# Audit - StellaOps.Scanner.Sbomer.BuildXPlugin
## Project
- Path: ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/StellaOps.Scanner.Sbomer.BuildXPlugin.csproj
- Module: ..
- Kind: Library
- Audit date (UTC): 2026-01-30
- Files scanned: 29
- Files with issues: 28
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 5
- Namespace violations: 27
- Using directive violations: 0
- Naming violations (interfaces/fields/const/async): 0
- Service locator usage (BuildServiceProvider/GetService): 4
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs (628 lines)
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorGenerator.cs (199 lines)
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginManifestLoader.cs (190 lines)
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceCasLayout.cs (113 lines)
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceManifestWriter.cs (235 lines)
- Namespace issues:
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/BuildxPluginException.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Attestation/AttestorClient.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Attestation/AttestorProvenanceRequest.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/CasWriteResult.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/LocalCasClient.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/LocalCasOptions.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorArtifact.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorDocument.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorGenerator.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorGeneratorMetadata.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorProvenance.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorRequest.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorSubject.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginCas.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginEntryPoint.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginImage.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginManifest.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginManifestLoader.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.AssemblyInfo.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.GlobalUsings.g.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.AssemblyInfo.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.GlobalUsings.g.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceCasLayout.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceManifestWriter.cs: missing namespace
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceOptions.cs: missing namespace
- Using directive issues:
- none
- Naming issues:
- none
- Async issues:
- none
- Service locator matches:
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs:397 using var provider = services.BuildServiceProvider();
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs:434 using var provider = services.BuildServiceProvider();
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs:487 using var provider = services.BuildServiceProvider();
- ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs:602 var provider = services.BuildServiceProvider();
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Normalize namespaces to file-scoped StellaOps.<Area>.
- Replace service locator usage with constructor injection.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 29
- Files with issues: 28
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/BuildxPluginException.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Program.cs | FileLength>100; ServiceLocator | Remove service locator usage; use constructor injection.; Split file to stay <= 100 lines. |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Attestation/AttestorClient.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Attestation/AttestorProvenanceRequest.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/CasWriteResult.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/LocalCasClient.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Cas/LocalCasOptions.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorArtifact.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorDocument.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorGenerator.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorGeneratorMetadata.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorProvenance.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorRequest.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Descriptor/DescriptorSubject.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginCas.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginEntryPoint.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginImage.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginManifest.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Manifest/BuildxPluginManifestLoader.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.AssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Debug/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.AssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/obj/Release/net10.0/StellaOps.Scanner.Sbomer.BuildXPlugin.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceCasLayout.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceManifestWriter.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| ../src/Scanner/StellaOps.Scanner.Sbomer.BuildXPlugin/Surface/SurfaceOptions.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
## Testing Fullness Findings
- Status: FAIL
- Expected layers (heuristic): Performance, Unit
- Detected test projects: ../src/Scanner/__Tests/StellaOps.Scanner.Sbomer.BuildXPlugin.Tests/StellaOps.Scanner.Sbomer.BuildXPlugin.Tests.csproj [Unit]
- Missing layers: Performance
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- Add or expand test projects to cover missing layers.
- Ensure tests use deterministic fixtures and offline harnesses.