archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,108 @@
# Audit - StellaOps.Registry.TokenService
## Project
- Path: src/Registry/StellaOps.Registry.TokenService/StellaOps.Registry.TokenService.csproj
- Module: Registry
- Kind: Library
- Audit date (UTC): 2026-01-30
- Files scanned: 18
- Files with issues: 18
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 9
- Namespace violations: 17
- Using directive violations: 0
- Naming violations (interfaces/fields/const/async): 0
- Service locator usage (BuildServiceProvider/GetService): 0
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- src/Registry/StellaOps.Registry.TokenService/PlanRegistry.cs (151 lines)
- src/Registry/StellaOps.Registry.TokenService/Program.cs (200 lines)
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenIssuer.cs (134 lines)
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenServiceOptions.cs (322 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/AdminModels.cs (402 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/InMemoryPlanRuleStore.cs (231 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/IPlanRuleStore.cs (101 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs (293 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs (238 lines)
- Namespace issues:
- src/Registry/StellaOps.Registry.TokenService/PlanRegistry.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/RegistryAccessModels.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/RegistryScopeParser.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenIssuer.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenServiceOptions.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Admin/AdminModels.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Admin/InMemoryPlanRuleStore.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Admin/IPlanRuleStore.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.AssemblyInfo.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.GlobalUsings.g.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.MvcApplicationPartsAssemblyInfo.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/obj/Release/net10.0/StellaOps.Registry.TokenService.GlobalUsings.g.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Observability/RegistryTokenMetrics.cs: missing namespace
- src/Registry/StellaOps.Registry.TokenService/Security/SigningKeyLoader.cs: missing namespace
- Using directive issues:
- none
- Naming issues:
- none
- Async issues:
- none
- Service locator matches:
- none
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Normalize namespaces to file-scoped StellaOps.<Area>.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 18
- Files with issues: 18
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| src/Registry/StellaOps.Registry.TokenService/PlanRegistry.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Program.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/RegistryAccessModels.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/RegistryScopeParser.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/RegistryTokenIssuer.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/RegistryTokenServiceOptions.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/AdminModels.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/InMemoryPlanRuleStore.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/IPlanRuleStore.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.AssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/obj/Debug/net10.0/StellaOps.Registry.TokenService.MvcApplicationPartsAssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/obj/Release/net10.0/StellaOps.Registry.TokenService.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/Observability/RegistryTokenMetrics.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/Registry/StellaOps.Registry.TokenService/Security/SigningKeyLoader.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
## Testing Fullness Findings
- Status: PASS
- Expected layers (heuristic): Unit
- Detected test projects: src/Registry/__Tests/StellaOps.Registry.TokenService.Tests/StellaOps.Registry.TokenService.Tests.csproj [Unit]
- Missing layers: none
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- None.

View File

@@ -0,0 +1,88 @@
# Audit - StellaOps.Registry.TokenService
## Project
- Path: src/Registry/StellaOps.Registry.TokenService/StellaOps.Registry.TokenService.csproj
- Module: Registry
- Kind: Library
- Audit date (UTC): 2026-01-31
- Files scanned: 13
- Files with issues: 10
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 9
- Namespace violations: 0
- Using directive violations: 1
- Naming violations (interfaces/fields/const/async): 3
- Service locator usage (BuildServiceProvider/GetService): 1
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- src/Registry/StellaOps.Registry.TokenService/PlanRegistry.cs (151 lines)
- src/Registry/StellaOps.Registry.TokenService/Program.cs (201 lines)
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenIssuer.cs (135 lines)
- src/Registry/StellaOps.Registry.TokenService/RegistryTokenServiceOptions.cs (322 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/AdminModels.cs (402 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/InMemoryPlanRuleStore.cs (232 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/IPlanRuleStore.cs (101 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs (294 lines)
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs (238 lines)
- Namespace issues:
- none
- Using directive issues:
- src/Registry/StellaOps.Registry.TokenService/Security/SigningKeyLoader.cs: using directives inside namespace
- Naming issues:
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs: private field naming
- Async issues:
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs: async method naming
- src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs: missing ConfigureAwait(false)
- Service locator matches:
- src/Registry/StellaOps.Registry.TokenService/Program.cs:58 var options = sp.GetRequiredService<IOptions<RegistryTokenServiceOptions>>().Value;
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Align interface/field/const naming to standards.
- Move and sort using directives (outside namespace).
- Rename async methods and avoid blocking async calls.
- Replace service locator usage with constructor injection.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 13
- Files with issues: 10
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| src/Registry/StellaOps.Registry.TokenService/PlanRegistry.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Program.cs | FileLength>100; ServiceLocator | Remove service locator usage; use constructor injection.; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/RegistryTokenIssuer.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/RegistryTokenServiceOptions.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/AdminModels.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/InMemoryPlanRuleStore.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/IPlanRuleStore.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/PlanAdminEndpoints.cs | AsyncNaming; ConfigureAwaitMissing; FileLength>100 | Add ConfigureAwait(false) to awaited calls in library-like code.; Rename async methods to end with Async.; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Admin/PlanValidator.cs | FileLength>100; PrivateFieldNaming | Rename private fields to _camelCase.; Split file to stay <= 100 lines. |
| src/Registry/StellaOps.Registry.TokenService/Security/SigningKeyLoader.cs | UsingInsideNamespace | Move using directives outside namespace. |
## Testing Fullness Findings
- Status: PASS
- Expected layers (heuristic): Unit
- Detected test projects: src/Registry/__Tests/StellaOps.Registry.TokenService.Tests/StellaOps.Registry.TokenService.Tests.csproj [Unit]
- Missing layers: none
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- None.