stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity

archive audit attempts

Browse Source
This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

112
docs-archived/implplan-blocked/audits/csproj-standards/src/ReachGraph/StellaOps.ReachGraph.WebService/StellaOps.ReachGraph.WebService.csproj Normal file
View File

@@ -0,0 +1,112 @@
# Audit - StellaOps.ReachGraph.WebService
## Project
- Path: src/ReachGraph/StellaOps.ReachGraph.WebService/StellaOps.ReachGraph.WebService.csproj
- Module: ReachGraph
- Kind: Library
- Audit date (UTC): 2026-01-30
- Files scanned: 20
- Files with issues: 20
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 9
- Namespace violations: 19
- Using directive violations: 0
- Naming violations (interfaces/fields/const/async): 0
- Service locator usage (BuildServiceProvider/GetService): 0
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs (121 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs (549 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/ReachGraphController.cs (252 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/CveMapping/ICveSymbolMappingService.cs (152 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Models/ReachGraphContracts.cs (147 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs (195 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphReplayService.cs (139 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs (522 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphStoreService.cs (176 lines)
- Namespace issues:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/ReachGraphController.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/CveMapping/ICveSymbolMappingService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Models/ReachGraphContracts.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.AssemblyInfo.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.GlobalUsings.g.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.MvcApplicationPartsAssemblyInfo.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.AssemblyInfo.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.GlobalUsings.g.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.MvcApplicationPartsAssemblyInfo.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphReplayService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphSliceService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphStoreService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphReplayService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs: missing namespace
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphStoreService.cs: missing namespace
- Using directive issues:
- none
- Naming issues:
- none
- Async issues:
- none
- Service locator matches:
- none
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Normalize namespaces to file-scoped StellaOps.<Area>.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 20
- Files with issues: 20
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/ReachGraphController.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/CveMapping/ICveSymbolMappingService.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Models/ReachGraphContracts.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.AssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Debug/net10.0/StellaOps.ReachGraph.WebService.MvcApplicationPartsAssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/.NETCoreApp,Version=v10.0.AssemblyAttributes.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.AssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.GlobalUsings.g.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/obj/Release/net10.0/StellaOps.ReachGraph.WebService.MvcApplicationPartsAssemblyInfo.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphReplayService.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphSliceService.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/IReachGraphStoreService.cs | NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>; |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphReplayService.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphStoreService.cs | FileLength>100; NamespaceMissing | Add file-scoped namespace: namespace StellaOps.<Area>;; Split file to stay <= 100 lines. |
## Testing Fullness Findings
- Status: PASS
- Expected layers (heuristic): Unit
- Detected test projects: src/__Tests/Integration/StellaOps.Integration.E2E/StellaOps.Integration.E2E.csproj [E2E, Integration]; src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/StellaOps.ReachGraph.WebService.Tests.csproj [Unit]
- Missing layers: none
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- None.

90
docs-archived/implplan-blocked/audits/csproj-standards/src/ReachGraph/StellaOps.ReachGraph.WebService/StellaOps.ReachGraph.WebService.md Normal file
View File

@@ -0,0 +1,90 @@
# Audit - StellaOps.ReachGraph.WebService
## Project
- Path: src/ReachGraph/StellaOps.ReachGraph.WebService/StellaOps.ReachGraph.WebService.csproj
- Module: ReachGraph
- Kind: Service
- Audit date (UTC): 2026-01-31
- Files scanned: 12
- Files with issues: 9
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 9
- Namespace violations: 1
- Using directive violations: 1
- Naming violations (interfaces/fields/const/async): 2
- Service locator usage (BuildServiceProvider/GetService): 3
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs (122 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs (550 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/ReachGraphController.cs (252 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/CveMapping/ICveSymbolMappingService.cs (152 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Models/ReachGraphContracts.cs (147 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs (196 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphReplayService.cs (140 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs (523 lines)
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphStoreService.cs (176 lines)
- Namespace issues:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs: block-scoped namespace
- Using directive issues:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs: using directives inside namespace
- Naming issues:
- none
- Async issues:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs: async method naming
- src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs: async method naming
- Service locator matches:
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs:54 var redisMultiplexer = sp.GetRequiredService<IConnectionMultiplexer>();
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs:55 var serializer = sp.GetRequiredService<CanonicalReachGraphSerializer>();
- src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs:59 var logger = sp.GetRequiredService<ILogger<ReachGraphValkeyCache>>();
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Move and sort using directives (outside namespace).
- Normalize namespaces to file-scoped StellaOps.<Area>.
- Rename async methods and avoid blocking async calls.
- Replace service locator usage with constructor injection.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 12
- Files with issues: 9
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Program.cs | FileLength>100; NamespaceNotFileScoped; ServiceLocator | Convert to file-scoped namespace.; Remove service locator usage; use constructor injection.; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/CveMappingController.cs | AsyncNaming; FileLength>100 | Rename async methods to end with Async.; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Controllers/ReachGraphController.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/CveMapping/ICveSymbolMappingService.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Models/ReachGraphContracts.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/PaginationService.cs | FileLength>100; UsingInsideNamespace | Move using directives outside namespace.; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphReplayService.cs | FileLength>100 | Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphSliceService.cs | AsyncNaming; FileLength>100 | Rename async methods to end with Async.; Split file to stay <= 100 lines. |
| src/ReachGraph/StellaOps.ReachGraph.WebService/Services/ReachGraphStoreService.cs | FileLength>100 | Split file to stay <= 100 lines. |
## Testing Fullness Findings
- Status: FAIL
- Expected layers (heuristic): E2E, Integration, Offline, Security, Unit
- Detected test projects: src/__Tests/Integration/StellaOps.Integration.E2E/StellaOps.Integration.E2E.csproj [E2E, Integration]; src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/StellaOps.ReachGraph.WebService.Tests.csproj [Unit]
- Missing layers: Offline, Security
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- Add or expand test projects to cover missing layers.
- Ensure tests use deterministic fixtures and offline harnesses.

73
docs-archived/implplan-blocked/audits/csproj-standards/src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/StellaOps.ReachGraph.WebService.Tests.md Normal file
View File

@@ -0,0 +1,73 @@
# Audit - StellaOps.ReachGraph.WebService.Tests
## Project
- Path: src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/StellaOps.ReachGraph.WebService.Tests.csproj
- Module: ReachGraph
- Kind: Test
- Audit date (UTC): 2026-01-31
- Files scanned: 2
- Files with issues: 2
- File-level report: docs/implplan/audits/csproj-standards/file-audit.csv
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: inherited false
- Deterministic: inherited true
- 100-line rule violations: 2
- Namespace violations: 0
- Using directive violations: 2
- Naming violations (interfaces/fields/const/async): 2
- Service locator usage (BuildServiceProvider/GetService): 0
- Assembly.LoadFrom usage: 0
### Details
- 100-line files:
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphApiIntegrationTests.cs (306 lines)
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphTestFactory.cs (254 lines)
- Namespace issues:
- none
- Using directive issues:
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphApiIntegrationTests.cs: using directives not sorted
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphTestFactory.cs: using directives not sorted
- Naming issues:
- none
- Async issues:
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphApiIntegrationTests.cs: async method naming
- src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphApiIntegrationTests.cs: missing ConfigureAwait(false)
- Service locator matches:
- none
- Assembly.LoadFrom matches:
- none
### Fix Guidance
- Move and sort using directives (outside namespace).
- Remove overrides that disable TreatWarningsAsErrors.
- Rename async methods and avoid blocking async calls.
- Split files over 100 lines into smaller types or partials.
## File-Level Findings
- Status: FAIL
- Files scanned: 2
- Files with issues: 2
- See docs/implplan/audits/csproj-standards/file-audit.csv for full per-file status.
| File | Issues | Fix guidance |
| --- | --- | --- |
| src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphApiIntegrationTests.cs | AsyncNaming; ConfigureAwaitMissing; FileLength>100; UsingNotSorted | Add ConfigureAwait(false) to awaited calls in library-like code.; Rename async methods to end with Async.; Sort using directives alphabetically.; Split file to stay <= 100 lines. |
| src/ReachGraph/__Tests/StellaOps.ReachGraph.WebService.Tests/ReachGraphTestFactory.cs | FileLength>100; UsingNotSorted | Sort using directives alphabetically.; Split file to stay <= 100 lines. |
## Testing Fullness Findings
- Status: PASS
- Expected layers (heuristic):
- Detected test projects: none
- Missing layers: none
### Manual checks required
- Observability contract tests for WebService/Worker.
- Intent tags for regulatory modules (Policy, Authority, Signer, Attestor, EvidenceLocker).
- Offline execution (tests must run without network access).
- Coverage matrix alignment (docs/technical/testing/TEST_COVERAGE_MATRIX.md).
### Fix Guidance
- None.