archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,15 @@
# SOLID Review - F
## Scope
- File: src/Tools/FixtureUpdater/FixtureUpdaterApp.cs
- Project: src/Tools/FixtureUpdater/FixtureUpdater.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - FixtureUpdaterOptions
## Scope
- File: src/Tools/FixtureUpdater/FixtureUpdaterRunner.cs
- Project: src/Tools/FixtureUpdater/FixtureUpdater.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (FixtureUpdaterOptions, FixtureUpdaterRunner, FixtureDeterminism, RepoRootLocator, FixtureUpdaterDefaults); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 534 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/FixtureUpdater/Program.cs
- Project: src/Tools/FixtureUpdater/FixtureUpdater.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,17 @@
# SOLID Review - GoldenPairsApp
## Scope
- File: src/Tools/GoldenPairs/GoldenPairsApp.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenPairsApp, GoldenPairsContext); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 321 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SectionComparisonStatus
## Scope
- File: src/Tools/GoldenPairs/Models/GoldenDiffReport.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SectionComparisonStatus, GoldenDiffReport, ArtifactHashInfo, SectionComparison); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SeverityLevel
## Scope
- File: src/Tools/GoldenPairs/Models/GoldenPairMetadata.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SeverityLevel, BinaryFormat, GoldenDiffVerdict, GoldenPairMetadata, ArtifactInfo, BinaryArtifact, PatchInfo, AdvisoryRef, ExpectedDiff); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - GoldenPairStatus
## Scope
- File: src/Tools/GoldenPairs/Models/GoldenPairsIndex.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenPairStatus, GoldenPairsIndex, GoldenPairSummary, GoldenPairsIndexSummary); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SectionHashSet
## Scope
- File: src/Tools/GoldenPairs/Models/SectionHashModels.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SectionHashSet, SectionHashEntry); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/GoldenPairs/Program.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/GoldenPairs/Schema/GoldenPairsSchemaProvider.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - GoldenPairsJsonSerializer
## Scope
- File: src/Tools/GoldenPairs/Serialization/GoldenPairsJsonSerializer.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenPairsJsonSerializer, DeterministicTypeInfoResolver); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - IDiffPipelineService
## Scope
- File: src/Tools/GoldenPairs/Services/DiffPipelineService.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IDiffPipelineService, DiffOptions, ValidationResult, DiffPipelineService, GoldenPairsToolVersion); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 290 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/GoldenPairs/Services/GoldenPairLayout.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GoldenPairLoader
## Scope
- File: src/Tools/GoldenPairs/Services/GoldenPairLoader.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenPairLoader, GoldenPairLoadResult, GoldenPairsIndexLoadResult, GoldenPairLoadError); responsibilities may be bundled.
## Maintainability Notes
- File length 212 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - G
## Scope
- File: src/Tools/GoldenPairs/Services/GoldenPairNormalizer.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - G
## Scope
- File: src/Tools/GoldenPairs/Services/GoldenPairsPaths.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - G
## Scope
- File: src/Tools/GoldenPairs/Services/GoldenPairsServiceFactory.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IPackageMirrorService
## Scope
- File: src/Tools/GoldenPairs/Services/PackageMirrorService.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IPackageMirrorService, MirrorResult, AptPackageMirrorService); responsibilities may be bundled.
## Maintainability Notes
- File length 287 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ISectionHashProvider
## Scope
- File: src/Tools/GoldenPairs/Services/SectionHashProvider.cs
- Project: src/Tools/GoldenPairs/StellaOps.Tools.GoldenPairs.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ISectionHashProvider, FileSectionHashProvider); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - InternalsVisibleTo
## Scope
- File: src/Tools/LanguageAnalyzerSmoke/InternalsVisibleTo.cs
- Project: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmoke.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file contains assembly-level metadata attributes only.
## Maintainability Notes
- Assembly metadata is centralized and easy to verify.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - L
## Scope
- File: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmokeApp.cs
- Project: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmoke.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - SmokeScenario
## Scope
- File: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmokeRunner.cs
- Project: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmoke.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SmokeScenario, AnalyzerProfile, AnalyzerProfileCatalog, SmokeOptions, PluginManifest, PluginEntryPoint, LanguageAnalyzerSmokeRunner, FixedTimeProvider, RepoRootLocator); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 470 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/LanguageAnalyzerSmoke/Program.cs
- Project: src/Tools/LanguageAnalyzerSmoke/LanguageAnalyzerSmoke.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - InternalsVisibleTo
## Scope
- File: src/Tools/NotifySmokeCheck/InternalsVisibleTo.cs
- Project: src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file contains assembly-level metadata attributes only.
## Maintainability Notes
- Assembly metadata is centralized and easy to verify.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - N
## Scope
- File: src/Tools/NotifySmokeCheck/NotifySmokeCheckApp.cs
- Project: src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - NotifyDeliveryOptions
## Scope
- File: src/Tools/NotifySmokeCheck/NotifySmokeCheckRunner.cs
- Project: src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (NotifyDeliveryOptions, NotifySmokeOptions, NotifyDeliveryRecord, NotifySmokeCheckRunner, FixedTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- File length 517 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/NotifySmokeCheck/Program.cs
- Project: src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/PolicyDslValidator/Program.cs
- Project: src/Tools/PolicyDslValidator/PolicyDslValidator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/PolicySchemaExporter/Program.cs
- Project: src/Tools/PolicySchemaExporter/PolicySchemaExporter.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/Tools/PolicySimulationSmoke/Program.cs
- Project: src/Tools/PolicySimulationSmoke/PolicySimulationSmoke.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - InternalsVisibleTo
## Scope
- File: src/Tools/RustFsMigrator/InternalsVisibleTo.cs
- Project: src/Tools/RustFsMigrator/RustFsMigrator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file contains assembly-level metadata attributes only.
## Maintainability Notes
- Assembly metadata is centralized and easy to verify.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - RetryableException
## Scope
- File: src/Tools/RustFsMigrator/Program.cs
- Project: src/Tools/RustFsMigrator/RustFsMigrator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (RetryableException, MigrationOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 407 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - R
## Scope
- File: src/Tools/RustFsMigrator/RustFsMigratorPaths.cs
- Project: src/Tools/RustFsMigrator/RustFsMigrator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/AzureDevOpsGenerator.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 241 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/CiPlatform.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/GitHubActionsGenerator.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 230 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/GitLabCiGenerator.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/IWorkflowGenerator.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/ScanConfig.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/TriggerConfig.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/UploadConfig.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - W
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/WorkflowGeneratorFactory.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - WorkflowOptions
## Scope
- File: src/Tools/StellaOps.Tools.WorkflowGenerator/WorkflowOptions.cs
- Project: src/Tools/StellaOps.Tools.WorkflowGenerator/StellaOps.Tools.WorkflowGenerator.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (WorkflowOptions, ValidationResult); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - FixtureUpdaterRunnerTests
## Scope
- File: src/Tools/__Tests/FixtureUpdater.Tests/FixtureUpdaterRunnerTests.cs
- Project: src/Tools/__Tests/FixtureUpdater.Tests/FixtureUpdater.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (FixtureUpdaterRunnerTests, TempDirectory); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - L
## Scope
- File: src/Tools/__Tests/LanguageAnalyzerSmoke.Tests/LanguageAnalyzerSmokeRunnerTests.cs
- Project: src/Tools/__Tests/LanguageAnalyzerSmoke.Tests/LanguageAnalyzerSmoke.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - N
## Scope
- File: src/Tools/__Tests/NotifySmokeCheck.Tests/NotifySmokeCheckRunnerTests.cs
- Project: src/Tools/__Tests/NotifySmokeCheck.Tests/NotifySmokeCheck.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - PolicyDslValidatorAppTests
## Scope
- File: src/Tools/__Tests/PolicyDslValidator.Tests/PolicyDslValidatorAppTests.cs
- Project: src/Tools/__Tests/PolicyDslValidator.Tests/PolicyDslValidator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (PolicyDslValidatorAppTests, CapturingRunner); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Tools/__Tests/PolicySchemaExporter.Tests/PolicySchemaExporterTests.cs
- Project: src/Tools/__Tests/PolicySchemaExporter.Tests/PolicySchemaExporter.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Tools/__Tests/PolicySimulationSmoke.Tests/PolicySimulationSmokeEvaluatorTests.cs
- Project: src/Tools/__Tests/PolicySimulationSmoke.Tests/PolicySimulationSmoke.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - R
## Scope
- File: src/Tools/__Tests/RustFsMigrator.Tests/RustFsMigratorTests.cs
- Project: src/Tools/__Tests/RustFsMigrator.Tests/RustFsMigrator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - DiffPipelineServiceTests
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/DiffPipelineServiceTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (DiffPipelineServiceTests, FixedTimeProvider, TempDirectory); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - GoldenPairLoaderTests
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/GoldenPairLoaderTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenPairLoaderTests, TempDirectory); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/GoldenPairSchemaTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - PackageMirrorServiceTests
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/PackageMirrorServiceTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (PackageMirrorServiceTests, NoHttpClientFactory, TempDirectory); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - T
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/TestData.cs
- Project: src/Tools/__Tests/StellaOps.Tools.GoldenPairs.Tests/StellaOps.Tools.GoldenPairs.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/AzureDevOpsGeneratorTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/GitHubActionsGeneratorTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 247 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/GitLabCiGeneratorTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/GoldenFixtureTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 215 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - W
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/WorkflowGeneratorFactoryTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - W
## Scope
- File: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/WorkflowOptionsTests.cs
- Project: src/Tools/__Tests/StellaOps.Tools.WorkflowGenerator.Tests/StellaOps.Tools.WorkflowGenerator.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.