archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,17 @@
# SOLID Review - CeremonyAuditEvents
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/CeremonyAuditEvents.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyAuditEvents, CeremonyAuditEvent, CeremonyInitiatedEvent, CeremonyApprovedEvent, CeremonyExecutedEvent, CeremonyExpiredEvent, CeremonyCancelledEvent, CeremonyApprovalRejectedEvent); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 234 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CeremonyState
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/CeremonyModels.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyState, CeremonyOperationType, Ceremony, CeremonyOperationPayload, CeremonyApproval, CreateCeremonyRequest, ApproveCeremonyRequest, CeremonyResult, CeremonyErrorCode); responsibilities may be bundled.
## Maintainability Notes
- File length 381 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - CeremonyOptions
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/CeremonyOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyOptions, OperationCeremonyConfig, CeremonyNotificationConfig); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CeremonyOrchestrator
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/CeremonyOrchestrator.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyOrchestrator, ICeremonyAuditSink, ICeremonyApproverValidator, ApproverValidationResult); responsibilities may be bundled.
## Maintainability Notes
- File length 553 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/CeremonyStateMachine.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ICeremonyOrchestrator
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/ICeremonyOrchestrator.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ICeremonyOrchestrator, CeremonyFilter); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Ceremonies/ICeremonyRepository.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - P
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/PredicateTypes.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 397 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DeltaPredicateBase
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/Predicates/DeltaPredicateSchemas.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (DeltaPredicateBase, VexDeltaPredicate, VexStatusChange, VexVulnerabilityEntry, VexDeltaSummary, SbomDeltaPredicate, SbomComponentEntry, SbomVersionChangeEntry, SbomLicenseChangeEntry, SbomDeltaSummary, VerdictDeltaPredicate, GateChangeEntry, RiskDelta, ReachabilityDeltaSummary, AttestationRef, VerdictDeltaSummary, ReachabilityDeltaPredicate, GateStatusChange, ReachabilityDeltaDetailSummary); responsibilities may be bundled.
## Maintainability Notes
- File length 463 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IProofOfEntitlementIntrospector
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/SignerAbstractions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IProofOfEntitlementIntrospector, IReleaseIntegrityVerifier, ISignerQuotaService, IDsseSigner, ISignerAuditSink, ISignerPipeline); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SignerPoEFormat
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/SignerContracts.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignerPoEFormat, SigningMode, SigningSubject, ProofOfEntitlement, SigningOptions, SigningRequest, CallerContext, ProofOfEntitlementResult, ReleaseVerificationResult, SigningIdentity, SigningMetadata, SigningBundle, PolicyCounters, SigningOutcome, SignerAuditEntry, DsseEnvelope, DsseSignature); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SignerException
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/SignerExceptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignerException, SignerValidationException, SignerAuthorizationException, SignerReleaseVerificationException, SignerQuotaException); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/SignerPipeline.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - SignerStatementBuilder
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/SignerStatementBuilder.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Core/StellaOps.Signer.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignerStatementBuilder, InTotoStatement, InTotoSubject); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Auditing/InMemorySignerAuditSink.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Options/SignerCryptoOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SignerEntitlementOptions
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Options/SignerEntitlementOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignerEntitlementOptions, SignerEntitlementDefinition); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Options/SignerReleaseVerificationOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/ProofOfEntitlement/InMemoryProofOfEntitlementIntrospector.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - InMemoryQuotaService
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Quotas/InMemoryQuotaService.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (InMemoryQuotaService, QuotaWindow); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/ReleaseVerification/DefaultReleaseIntegrityVerifier.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/ServiceCollectionExtensions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/CryptoDsseSigner.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 282 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/DefaultSigningKeyResolver.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/DsseSignerOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - H
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/HmacDsseSigner.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ISigningKeyResolver
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/ISigningKeyResolver.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ISigningKeyResolver, SigningKeyResolution); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Signing/SigningServiceCollectionExtensions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - FulcioHttpClient
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/FulcioHttpClient.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (FulcioHttpClient, FulcioSigningCertificateRequest, PublicKeyRequest, PublicKeyContent, FulcioSigningCertificateResponse, SignedCertificateEmbeddedSct, CertificateChain); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IFulcioClient
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/ISigstoreClients.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IFulcioClient, IRekorClient, ISigstoreSigningService); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - RekorHttpClient
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/RekorHttpClient.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (RekorHttpClient, RekorCreateEntryRequest, HashedRekordSpec, HashedRekordData, HashSpec, SignatureSpec, PublicKeySpec, RekorSearchRequest, RekorEntryResponse, VerificationResponse, InclusionProofResponse); responsibilities may be bundled.
## Maintainability Notes
- File length 270 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SigstoreException
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/SigstoreExceptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SigstoreException, FulcioException, RekorException); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - FulcioCertificateResult
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/SigstoreModels.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (FulcioCertificateResult, RekorEntryResult, RekorInclusionProof, SigstoreSigningResult); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/SigstoreOptions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/SigstoreServiceCollectionExtensions.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/Sigstore/SigstoreSigningService.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Infrastructure/StellaOps.Signer.Infrastructure.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 201 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Auth/SignerAuthTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 412 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - PluginAvailabilityTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Availability/PluginAvailabilityTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (PluginAvailabilityTests, ServiceMode, SignResult, HealthReport, PluginHealth, ServiceStatus, ITestPlugin, AvailablePlugin, UnavailablePlugin, TransientFailurePlugin, TestPluginRegistry); responsibilities may be bundled.
## Maintainability Notes
- File length 703 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CeremonyOrchestratorIntegrationTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Ceremonies/CeremonyOrchestratorIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyOrchestratorIntegrationTests, MockTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- File length 417 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Ceremonies/CeremonyStateMachineTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Contract/PredicateTypesTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Contract/SignerContractSnapshotTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 418 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - D
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Fixtures/DeterministicTestData.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,16 @@
# SOLID Review - P
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Fixtures/PredicateFixtures.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 581 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Fixtures/SigningRequestBuilder.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - TestCryptoFactory
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Fixtures/TestCryptoFactory.Sm.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (TestCryptoFactory, Sm2TestKeyFactory); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Fixtures/TestCryptoFactory.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Integration/CryptoDsseSignerIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 512 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - KeyRotationWorkflowIntegrationTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Integration/KeyRotationWorkflowIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyRotationWorkflowIntegrationTests, TestKeys); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 419 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - MultiPluginSignVerifyIntegrationTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Integration/MultiPluginSignVerifyIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (MultiPluginSignVerifyIntegrationTests, ITestCryptoPlugin, Ed25519SimPlugin, Es256SimPlugin, Rs256SimPlugin, GostSimPlugin, Sm2SimPlugin); responsibilities may be bundled.
## Maintainability Notes
- File length 570 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Integration/SignerPipelineIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 356 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - TamperedPayloadVerificationTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Integration/TamperedPayloadVerificationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (TamperedPayloadVerificationTests, VerificationResult, ITestCryptoPlugin, Ed25519SimPlugin, Es256SimPlugin, GostSimPlugin); responsibilities may be bundled.
## Maintainability Notes
- File length 791 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeyRotationServiceTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/KeyManagement/KeyRotationServiceTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyRotationServiceTests, FakeTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- File length 658 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/KeyManagement/TemporalKeyVerificationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 408 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/KeyManagement/TrustAnchorManagerTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 506 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CertificateChainValidatorTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Keyless/CertificateChainValidatorTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CertificateChainValidatorTests, FakeTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- File length 563 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - EphemeralKeyGeneratorTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Keyless/EphemeralKeyGeneratorTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (EphemeralKeyGeneratorTests, KeylessAlgorithmsTests); responsibilities may be bundled.
## Maintainability Notes
- File length 248 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - HttpFulcioClientTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Keyless/HttpFulcioClientTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (HttpFulcioClientTests, MockHttpMessageHandler); responsibilities may be bundled.
## Maintainability Notes
- File length 482 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - K
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Keyless/KeylessDsseSignerTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 402 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeylessSigningIntegrationTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Keyless/KeylessSigningIntegrationTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeylessSigningIntegrationTests, MockFulcioServer); responsibilities may be bundled.
## Maintainability Notes
- File length 611 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Negative/SignerNegativeTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 752 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Observability/SignerOTelTraceTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 390 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/SignerEndpointsTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/CanonicalPayloadDeterminismTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 428 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/CryptoDsseSignerTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 304 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - DefaultSigningKeyResolverTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/DefaultSigningKeyResolverTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (DefaultSigningKeyResolverTests, FakeTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - DualSignTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/DualSignTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (DualSignTests, StubProvider, StubSigner, StubKeyResolver); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/SignerStatementBuilderTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 373 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SigningServiceCollectionExtensionsTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/SigningServiceCollectionExtensionsTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SigningServiceCollectionExtensionsTests, FakeTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Sm2SigningTests
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/Signing/Sm2SigningTests.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.Tests/StellaOps.Signer.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (Sm2SigningTests, StubKeyResolver); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SignDsseSubjectDto
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Contracts/SignDsseContracts.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignDsseSubjectDto, SignDssePoeDto, SignDsseOptionsDto, SignDsseRequestDto, SignDsseResponseDto, SignDsseBundleDto, SignDsseEnvelopeDto, SignDsseSignatureDto, SignDsseIdentityDto, SignDssePolicyDto, VerifyReferrersResponseDto); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,17 @@
# SOLID Review - CeremonyEndpoints
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Endpoints/CeremonyEndpoints.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyEndpoints, CreateCeremonyRequestDto, CreateCeremonyPayloadDto, ApproveCeremonyRequestDto, CeremonyResponseDto, CeremonyPayloadDto, CeremonyApprovalDto, CeremonyListResponseDto); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 592 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - KeyRotationEndpoints
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Endpoints/KeyRotationEndpoints.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyRotationEndpoints, AddKeyRequestDto, AddKeyResponseDto, RevokeKeyRequestDto, RevokeKeyResponseDto, KeyValidityResponseDto, KeyHistoryResponseDto, KeyHistoryEntryDto, RotationWarningsResponseDto, RotationWarningDto); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 454 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,16 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Endpoints/SignerEndpoints.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 360 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Program.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Security/StubBearerAuthenticationDefaults.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/Security/StubBearerAuthenticationHandler.cs
- Project: src/Signer/StellaOps.Signer/StellaOps.Signer.WebService/StellaOps.Signer.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - KeyHistoryEntity
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/Entities/KeyEntities.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyHistoryEntity, KeyAuditLogEntity); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,16 @@
# SOLID Review - TrustAnchorEntity
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/Entities/TrustAnchorEntity.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (TrustAnchorEntity, KeyOperation); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IKeyRotationService
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/IKeyRotationService.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IKeyRotationService, AddKeyRequest, RevokeKeyRequest, KeyRotationResult, KeyValidityResult, KeyStatus, KeyRotationWarning, RotationWarningType, KeyHistoryEntry); responsibilities may be bundled.
## Maintainability Notes
- File length 286 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ITrustAnchorManager
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/ITrustAnchorManager.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ITrustAnchorManager, TrustAnchorInfo, CreateTrustAnchorRequest, UpdateTrustAnchorRequest, TrustVerificationResult); responsibilities may be bundled.
## Maintainability Notes
- File length 230 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - K
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/KeyManagementDbContext.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,17 @@
# SOLID Review - KeyAuditEventType
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/KeyRotationAuditRepository.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyAuditEventType, KeyRotationAuditEntry, KeyUsageStats, IKeyRotationAuditRepository, KeyExpiryWarning, PostgresKeyRotationAuditRepository); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 413 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeyRotationService
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/KeyRotationService.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyRotationService, KeyRotationOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 539 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - TrustAnchorManager
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/TrustAnchorManager.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.KeyManagement/StellaOps.Signer.KeyManagement.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (TrustAnchorManager, PurlPatternMatcher); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 420 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/AmbientOidcTokenProvider.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/EphemeralKeyGenerator.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - EphemeralKeyPair
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/EphemeralKeyPair.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (EphemeralKeyPair, KeylessAlgorithms); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - HttpFulcioClient
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/HttpFulcioClient.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (HttpFulcioClient, FulcioSigningCertRequest, FulcioCredentials, FulcioPublicKeyRequest, FulcioPublicKey, FulcioSigningCertResponse, FulcioSignedCertificateEmbeddedSct, FulcioCertificateChain); responsibilities may be bundled.
## Maintainability Notes
- File length 310 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ICertificateChainValidator
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/ICertificateChainValidator.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ICertificateChainValidator, CertificateValidationResult, ChainStatusInfo, IdentityValidationResult, CertificateChainValidator); responsibilities may be bundled.
## Maintainability Notes
- File length 529 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/IEphemeralKeyGenerator.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IFulcioClient
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/IFulcioClient.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IFulcioClient, FulcioCertificateRequest, FulcioCertificateResult, FulcioIdentity); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IOidcTokenProvider
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/IOidcTokenProvider.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IOidcTokenProvider, OidcTokenResult, OidcClientCredentialsConfig, OidcAmbientConfig); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - K
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/KeylessDsseSigner.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 210 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - KeylessSigningException
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/KeylessSigningExceptions.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeylessSigningException, FulcioUnavailableException, OidcTokenAcquisitionException, CertificateChainValidationException, EphemeralKeyGenerationException); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/ServiceCollectionExtensions.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - SignerKeylessOptions
## Scope
- File: src/Signer/__Libraries/StellaOps.Signer.Keyless/SignerKeylessOptions.cs
- Project: src/Signer/__Libraries/StellaOps.Signer.Keyless/StellaOps.Signer.Keyless.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignerKeylessOptions, FulcioOptions, OidcOptions, AlgorithmOptions, CertificateOptions, IdentityOptions); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.