archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,15 @@
# SOLID Review - GenerateTokenRequest
## Scope
- File: src/Replay/StellaOps.Replay.WebService/Program.cs
- Project: src/Replay/StellaOps.Replay.WebService/StellaOps.Replay.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GenerateTokenRequest, GenerateTokenResponse, VerifyTokenRequest, VerifyTokenResponse, TokenInfoResponse, ReplayServiceOptions, AuthorityConfig); responsibilities may be bundled.
## Maintainability Notes
- File length 482 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - VerdictReplayEndpoints
## Scope
- File: src/Replay/StellaOps.Replay.WebService/VerdictReplayEndpoints.cs
- Project: src/Replay/StellaOps.Replay.WebService/StellaOps.Replay.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (VerdictReplayEndpoints, VerdictReplayRequest, VerdictReplayResponse, DriftItemDto, VerifyEligibilityRequest, ReplayEligibilityResponse, ReplayStatusResponse, ReplayComparisonRequest, ReplayComparisonResponse, DivergenceItemDto); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 335 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ITraceAnonymizer
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Anonymization/ITraceAnonymizer.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Anonymization/StellaOps.Replay.Anonymization.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ITraceAnonymizer, AnonymizationOptions, AnonymizationValidationResult, PiiViolation, PiiType); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ProductionTrace
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Anonymization/Models.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Anonymization/StellaOps.Replay.Anonymization.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ProductionTrace, AnonymizedTrace, TraceSpan, AnonymizedSpan, SpanEvent, AnonymizedSpanEvent, AnonymizationManifest, TraceType); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - TraceAnonymizer
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Anonymization/TraceAnonymizer.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Anonymization/StellaOps.Replay.Anonymization.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (TraceAnonymizer, AnonymizationStats); responsibilities may be bundled.
## Maintainability Notes
- File length 403 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DeterminismVerifier
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Core/DeterminismVerifier.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Core/StellaOps.Replay.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (DeterminismVerifier, VerificationResult, VerdictDifference, DifferenceSeverity, VerdictRecord, VerdictOutcome, FindingRecord); responsibilities may be bundled.
## Maintainability Notes
- File length 467 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - InputManifestResolver
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Core/InputManifestResolver.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Core/StellaOps.Replay.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (InputManifestResolver, InputManifest, ResolvedInputs, InputResolutionError, InputType, ManifestValidationResult, InputManifestResolverOptions, IFeedSnapshotStore, IPolicyManifestStore, IVexDocumentStore, FeedData, PolicyBundle, VexDocument); responsibilities may be bundled.
## Maintainability Notes
- File length 494 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - PolicySimulationInputLock
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Core/PolicySimulationInputLock.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Core/StellaOps.Replay.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (PolicySimulationInputLock, PolicySimulationMaterializedInputs, PolicySimulationValidationResult, PolicySimulationInputLockValidator); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 211 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ReplayExecutor
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Core/ReplayExecutor.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Core/StellaOps.Replay.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ReplayExecutor, ReplayExecutorOptions, IReplayPolicyEvaluator, ReplayContext, OriginalVerdict, ReplayedVerdict, ReplayRequest, ReplayExecutionResult, ReplayExecutionStatus, VerdictDiff, DiffEntry); responsibilities may be bundled.
## Maintainability Notes
- File length 519 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ReplayJobQueue
## Scope
- File: src/Replay/__Libraries/StellaOps.Replay.Core/ReplayJobQueue.cs
- Project: src/Replay/__Libraries/StellaOps.Replay.Core/StellaOps.Replay.Core.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ReplayJobQueue, ReplayJobQueueOptions, ReplayJobRequest, ReplayJob, ReplayJobStatus, ReplayQueueStats); responsibilities may be bundled.
## Maintainability Notes
- File length 446 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Anonymization.Tests/TraceAnonymizerTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Anonymization.Tests/StellaOps.Replay.Anonymization.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 478 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Core.Tests/PolicySimulationInputLockValidatorTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Core.Tests/StellaOps.Replay.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Core.Tests/Unit/DeterminismVerifierTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Core.Tests/StellaOps.Replay.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 458 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Core.Tests/Unit/InputManifestResolverTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Core.Tests/StellaOps.Replay.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 453 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - V
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Core.Tests/VerdictReplayEndpointsTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Core.Tests/StellaOps.Replay.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 297 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - V
## Scope
- File: src/Replay/__Tests/StellaOps.Replay.Core.Tests/VerdictReplayIntegrationTests.cs
- Project: src/Replay/__Tests/StellaOps.Replay.Core.Tests/StellaOps.Replay.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 419 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.