archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,15 @@
# SOLID Review - BinaryIndexOpsController
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (BinaryIndexOpsController, BinaryIndexOpsHealthResponse, BinaryIndexBenchRequest, BinaryIndexBenchResponse, BinaryIndexLatencyStats, BinaryIndexFunctionCacheStats, BinaryIndexEffectiveConfig); responsibilities may be bundled.
## Maintainability Notes
- File length 324 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GoldenSetController
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/GoldenSetController.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GoldenSetController, GoldenSetListResponse, GoldenSetResponse, GoldenSetCreateRequest, VulnerableTargetDto, BasicBlockEdgeDto, WitnessInputDto, GoldenSetMetadataDto, GoldenSetCreateResponse, GoldenSetStatusRequest, GoldenSetStatusResponse, GoldenSetAuditResponse); responsibilities may be bundled.
## Maintainability Notes
- File length 777 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/PatchCoverageController.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 332 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - R
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/ResolutionController.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,17 @@
# SOLID Review - RateLimitingMiddleware
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Middleware/RateLimitingMiddleware.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (RateLimitingMiddleware, SlidingWindowCounter, RateLimitingOptions, RateLimitingExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 277 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Program
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Program.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: no type declarations; file appears to contain top-level statements or metadata.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Services/CachedResolutionService.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,17 @@
# SOLID Review - ResolutionTelemetry
## Scope
- File: src/BinaryIndex/StellaOps.BinaryIndex.WebService/Telemetry/ResolutionTelemetry.cs
- Project: src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ResolutionTelemetry, ResolutionTelemetryTags, ResolutionTelemetryExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 220 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IGoldenSetAnalysisPipeline
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/GoldenSetAnalysisPipeline.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IGoldenSetAnalysisPipeline, AnalysisPipelineOptions, GoldenSetAnalysisPipeline, ISignatureIndexFactory, SignatureIndexFactory); responsibilities may be bundled.
## Maintainability Notes
- File length 370 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FingerprintExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/Implementations.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FingerprintExtractor, ReachabilityAnalyzer, NullBinaryReachabilityService); responsibilities may be bundled.
## Maintainability Notes
- File length 280 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IFingerprintExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/Interfaces.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IFingerprintExtractor, FingerprintExtractionOptions, ISignatureMatcher, SignatureMatchOptions, IReachabilityAnalyzer, ReachabilityOptions, ITaintGateExtractor, IBinaryReachabilityService, BinaryReachabilityResult, BinaryReachabilityOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 409 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GoldenSetAnalysisResult
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/Models/AnalysisResultModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (GoldenSetAnalysisResult, SignatureMatch, MatchLevel, MatchLevelScores, ReachabilityResult, SinkMatch, ReachabilityPath, TaintGate, TaintGateType); responsibilities may be bundled.
## Maintainability Notes
- File length 350 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FunctionFingerprint
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/Models/FingerprintModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FunctionFingerprint, BasicBlockHash, BasicBlockType, SemanticEmbedding, ExtractedConstant, CfgEdge, CfgEdgeType); responsibilities may be bundled.
## Maintainability Notes
- File length 286 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - SignatureIndex
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/Models/SignatureIndexModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (SignatureIndex, FunctionSignature, SignatureIndexBuilder); responsibilities may be bundled.
## Maintainability Notes
- File length 250 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ReachGraphBinaryReachabilityService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/ReachGraphBinaryReachabilityService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ReachGraphBinaryReachabilityService, IReachGraphSliceClient, CveSliceResult, CveSlicePath, SliceResult, SliceNode, SliceEdge, NullReachGraphSliceClient); responsibilities may be bundled.
## Maintainability Notes
- File length 293 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/ServiceCollectionExtensions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/SignatureMatcher.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 361 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/TaintGateExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Analysis/StellaOps.BinaryIndex.Analysis.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - BuilderServiceOptions
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/BuilderOptions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BuilderServiceOptions, DistroBuilderOptions, FunctionExtractionOptions); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FingerprintClaim
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/FingerprintClaimModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FingerprintClaim, ClaimVerdict, FingerprintClaimEvidence, IFingerprintClaimRepository, IFunctionFingerprintRepository); responsibilities may be bundled.
## Maintainability Notes
- File length 305 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IGuidProvider
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/GuidProvider.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IGuidProvider, GuidProvider); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IFunctionFingerprintExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/IFunctionFingerprintExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IFunctionFingerprintExtractor, FunctionFingerprint, ExtractionOptions, FunctionChange, ChangeType); responsibilities may be bundled.
## Maintainability Notes
- File length 229 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IPatchDiffEngine
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/IPatchDiffEngine.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IPatchDiffEngine, FunctionDiffResult, DiffStatistics, DiffOptions, HashWeights); responsibilities may be bundled.
## Maintainability Notes
- File length 234 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IReproducibleBuilder
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/IReproducibleBuilder.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IReproducibleBuilder, BuildRequest, PatchReference, BuildOptions, BuildResult, BuiltBinary, PatchDiffRequest, PatchTarget, PatchDiffResult, BinaryDiff, BuildEnvironmentValidation); responsibilities may be bundled.
## Maintainability Notes
- File length 429 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/PatchDiffEngine.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 489 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IReproducibleBuildJob
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/ReproducibleBuildJobTypes.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IReproducibleBuildJob, CveAttribution, IAdvisoryFeedMonitor, ReproducibleBuildOptions, ReproducibleBuildJob); responsibilities may be bundled.
## Maintainability Notes
- File length 430 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/ServiceCollectionExtensions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - AbiCompatibility
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/AbiCompatibility.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (AbiCompatibility, AbiCompatibilityLevel, AbiBreakingChange, AbiBreakType, AbiWarning, AbiWarningType, AbiSummary); responsibilities may be bundled.
## Maintainability Notes
- File length 208 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DynamicLinkingDiff
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/DynamicLinkingDiff.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DynamicLinkingDiff, GotDiff, GotEntry, GotEntryModification, GotEntryType, PltDiff, PltEntry, PltReorder, RpathDiff, NeededDiff, RelocationDiff, RelocationChange, RelocationChangeType); responsibilities may be bundled.
## Maintainability Notes
- File length 245 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ISymbolTableDiffAnalyzer
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/ISymbolTableDiffAnalyzer.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ISymbolTableDiffAnalyzer, SymbolDiffOptions, SymbolTable, ExtractedSymbol); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - N
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/NameDemangler.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 388 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/SymbolDiffServiceExtensions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - SymbolTableDiff
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/SymbolTableDiff.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (SymbolTableDiff, BinaryRef, BinaryFormat, SymbolChangeSummary, SymbolChangeCounts, SymbolChange, SymbolModification, SymbolAttributes, AttributeChange, SymbolRename, SymbolType, SymbolBinding, SymbolVisibility, ChangeSeverity, RenameConfidence); responsibilities may be bundled.
## Maintainability Notes
- File length 316 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - SymbolTableDiffAnalyzer
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/SymbolTableDiffAnalyzer.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (SymbolTableDiffAnalyzer, ISymbolExtractor, INameDemangler, ManglingScheme); responsibilities may be bundled.
## Maintainability Notes
- File length 807 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - VersionMapDiff
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/SymbolDiff/VersionMapDiff.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Builders/StellaOps.BinaryIndex.Builders.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (VersionMapDiff, VersionDefinition, VersionRequirement, VersionAssignmentChange, VersionChangeCounts); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - B
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/BinaryCacheOptions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - B
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/BinaryCacheServiceExtensions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - BinaryCacheOptionsValidator
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/CacheOptionsValidation.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BinaryCacheOptionsValidator, ResolutionCacheOptionsValidator); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/CachedBinaryVulnerabilityService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 541 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FunctionIrCacheOptions
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/FunctionIrCacheService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FunctionIrCacheOptions, FunctionCacheKey, CachedFunctionFingerprint, FunctionIrCacheStats, FunctionIrCacheService); responsibilities may be bundled.
## Maintainability Notes
- File length 318 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IRandomSource
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/RandomSource.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IRandomSource, SystemRandomSource); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IResolutionCacheService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/ResolutionCacheService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/StellaOps.BinaryIndex.Cache.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IResolutionCacheService, CachedResolution, ResolutionCacheOptions, ResolutionCacheService); responsibilities may be bundled.
## Maintainability Notes
- File length 330 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - VulnResolutionRequest
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Contracts/Resolution/VulnResolutionContracts.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Contracts/StellaOps.BinaryIndex.Contracts.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (VulnResolutionRequest, ResolutionHashes, VulnResolutionResponse, ResolutionStatus, ResolutionEvidence, ResolutionMatchTypes, ResolutionFixMethods, BatchVulnResolutionRequest, BatchResolutionOptions, BatchVulnResolutionResponse); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 249 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - BinaryIndexOpsHealthResponse
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOpsModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BinaryIndexOpsHealthResponse, BinaryIndexComponentHealth, ComponentHealthStatus, BinaryIndexLifterWarmness, IsaWarmness, BinaryIndexBenchResponse, BenchLatencySummary, BenchOperationResult, BinaryIndexFunctionCacheStats, BinaryIndexEffectiveConfig, B2R2PoolConfigView, SemanticLiftingConfigView, FunctionCacheConfigView, PersistenceConfigView, BackendVersions); responsibilities may be bundled.
## Maintainability Notes
- File length 495 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - BinaryIndexOptions
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOptions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BinaryIndexOptions, B2R2PoolOptions, SemanticLiftingOptions, FunctionCacheOptions, BinaryIndexPersistenceOptions, BinaryIndexOpsOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 277 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - BinaryIdentity
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Models/BinaryIdentity.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BinaryIdentity, BinaryFormat, BinaryType); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - FixState
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Models/FixModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FixState, FixMethod); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IResolutionService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Resolution/ResolutionService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IResolutionService, ResolutionOptions, ResolutionServiceOptions, ResolutionService); responsibilities may be bundled.
## Maintainability Notes
- File length 465 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - B
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/BinaryIdentityService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/ElfFeatureExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 212 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IBinaryFeatureExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/IBinaryFeatureExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IBinaryFeatureExtractor, BinaryMetadata); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IBinaryVulnAssertionRepository
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/IBinaryVulnAssertionRepository.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IBinaryVulnAssertionRepository, BinaryVulnAssertion); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IBinaryVulnerabilityService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/IBinaryVulnerabilityService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IBinaryVulnerabilityService, FingerprintLookupOptions, LookupOptions, DeltaSigLookupOptions, BinaryVulnMatch, MatchMethod, MatchEvidence, FixStatusResult, FunctionFingerprintSet, CorpusLookupOptions, CorpusFunctionMatch, CorpusMatchMethod, CorpusCveAssociation, CorpusAffectedState); responsibilities may be bundled.
## Maintainability Notes
- File length 388 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/ITenantContext.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - M
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/MachoFeatureExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 307 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/PeFeatureExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 283 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Services/StreamGuard.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/StellaOps.BinaryIndex.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/AlpineCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/StellaOps.BinaryIndex.Corpus.Alpine.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - AlpinePackageExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/AlpinePackageExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/StellaOps.BinaryIndex.Corpus.Alpine.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (AlpinePackageExtractor, ExtractedBinaryInfo); responsibilities may be bundled.
## Maintainability Notes
- File length 229 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/ApkBuildSecfixesExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/StellaOps.BinaryIndex.Corpus.Alpine.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IAlpinePackageSource
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/IAlpinePackageSource.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Alpine/StellaOps.BinaryIndex.Corpus.Alpine.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IAlpinePackageSource, AlpinePackageMetadata); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/DebianCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/StellaOps.BinaryIndex.Corpus.Debian.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DebianMirrorPackageSource
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/DebianMirrorPackageSource.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/StellaOps.BinaryIndex.Corpus.Debian.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DebianMirrorPackageSource, HttpResponseStream); responsibilities may be bundled.
## Maintainability Notes
- File length 277 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DebianPackageExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/DebianPackageExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/StellaOps.BinaryIndex.Corpus.Debian.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DebianPackageExtractor, ExtractedBinaryInternal); responsibilities may be bundled.
## Maintainability Notes
- File length 225 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IDebianPackageSource
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/IDebianPackageSource.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Debian/StellaOps.BinaryIndex.Corpus.Debian.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IDebianPackageSource, DebianPackageMetadata); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IRpmPackageSource
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/IRpmPackageSource.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/StellaOps.BinaryIndex.Corpus.Rpm.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IRpmPackageSource, RpmPackageMetadata); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - R
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/RpmCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/StellaOps.BinaryIndex.Corpus.Rpm.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - RpmPackageExtractor
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/RpmPackageExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/StellaOps.BinaryIndex.Corpus.Rpm.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (RpmPackageExtractor, PayloadCompression, ExtractedBinaryInfo); responsibilities may be bundled.
## Maintainability Notes
- File length 384 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/SrpmChangelogExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus.Rpm/StellaOps.BinaryIndex.Corpus.Rpm.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Connectors/CurlCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 449 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Connectors/GlibcCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 551 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - O
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Connectors/OpenSslCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 556 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Z
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Connectors/ZlibCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 454 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IGuidProvider
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/GuidProvider.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IGuidProvider, SystemGuidProvider); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IBinaryCorpusConnector
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/IBinaryCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IBinaryCorpusConnector, CorpusQuery, CorpusSnapshot, PackageInfo, ExtractedBinary); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ICorpusIngestionService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/ICorpusIngestionService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ICorpusIngestionService, LibraryIngestionMetadata, IngestionOptions, IngestionResult, FunctionCveAssociation); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ICorpusQueryService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/ICorpusQueryService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ICorpusQueryService, FunctionFingerprints, IdentifyOptions, SimilarityWeights, CorpusFunctionWithCve, CorpusStatistics, LibrarySummary, LibraryVersionSummary); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ICorpusRepository
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/ICorpusRepository.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ICorpusRepository, FingerprintSearchResult); responsibilities may be bundled.
## Maintainability Notes
- File length 329 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/ICorpusSnapshotRepository.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ILibraryCorpusConnector
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/ILibraryCorpusConnector.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ILibraryCorpusConnector, LibraryBinary, LibraryBinarySource, LibrarySourceType, LibraryFetchOptions); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - LibraryMetadata
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Models/FunctionCorpusModels.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (LibraryMetadata, LibraryVersion, BuildVariant, CorpusFunction, CorpusFingerprint, FingerprintAlgorithm, FingerprintMetadata, FunctionCluster, ClusterMember, FunctionCve, CveAffectedState, CveEvidenceType, IngestionJob, IngestionJobType, IngestionJobStatus, FunctionMatch, MatchConfidence, MatchDetails, FunctionEvolution, FunctionVersionInfo); responsibilities may be bundled.
## Maintainability Notes
- File length 274 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - BatchFingerprintPipeline
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Services/BatchFingerprintPipeline.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BatchFingerprintPipeline, FingerprintWorkItem, IBatchFingerprintPipeline, BatchFingerprintOptions, BatchFingerprintResult, FingerprintProgress, IFingerprintGeneratorFactory, ICorpusFingerprintGenerator, GeneratedFingerprint); responsibilities may be bundled.
## Maintainability Notes
- File length 466 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CorpusIngestionService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Services/CorpusIngestionService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (CorpusIngestionService, IFunctionExtractor, IFingerprintGenerator, ExtractedFunction); responsibilities may be bundled.
## Maintainability Notes
- File length 468 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CorpusQueryService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Services/CorpusQueryService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (CorpusQueryService, FunctionCandidate, CombinedCandidate); responsibilities may be bundled.
## Maintainability Notes
- File length 421 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CveFunctionMappingUpdater
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Services/CveFunctionMappingUpdater.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (CveFunctionMappingUpdater, ICveFunctionMappingUpdater, ICveDataProvider, CveDetails, CveMappingUpdateResult, CveBatchMappingResult); responsibilities may be bundled.
## Maintainability Notes
- File length 425 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FunctionClusteringService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/Services/FunctionClusteringService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Corpus/StellaOps.BinaryIndex.Corpus.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (FunctionClusteringService, FunctionWithFingerprint, GroupClusteringResult, IFunctionClusteringService, ClusteringOptions, ClusteringResult, ClusterDetails, ClusterMemberDetails, IClusterSimilarityComputer); responsibilities may be bundled.
## Maintainability Notes
- File length 533 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/AstComparisonEngine.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 393 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/CodeNormalizer.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 535 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DecompiledCodeParser
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/DecompiledCodeParser.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DecompiledCodeParser, TokenType, RecursiveParser); responsibilities may be bundled.
## Maintainability Notes
- File length 951 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - D
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/DecompilerServiceCollectionExtensions.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GhidraDecompilerAdapter
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/GhidraDecompilerAdapter.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (GhidraDecompilerAdapter, DecompilerOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 293 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IDecompilerService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/IDecompilerService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IDecompilerService, IAstComparisonEngine, ICodeNormalizer, IDecompiledCodeParser); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DecompiledFunction
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/Models.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Decompiler/StellaOps.BinaryIndex.Decompiler.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DecompiledFunction, DecompiledAst, AstNode, AstNodeType, SourceLocation, LocalVariable, AstPattern, PatternType, PatternMetadata, DecompiledComparisonResult, AstEditDistance, SemanticEquivalence, EquivalenceType, CodeDifference, DifferenceType, ComparisonConfidence, DecompileOptions, ComparisonOptions, NormalizationOptions, FunctionNode, ParameterNode, BlockNode, IfNode, WhileNode, ForNode, ReturnNode, AssignmentNode, BinaryOpNode, UnaryOpNode, CallNode, VariableNode, ConstantNode, ArrayAccessNode, FieldAccessNode, CastNode, EmptyNode); responsibilities may be bundled.
## Maintainability Notes
- File length 378 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IDeltaSigAttestorService
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/Attestation/DeltaSigAttestorIntegration.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IDeltaSigAttestorService, DeltaSigSigningOptions, DeltaSigAttestationOptions, DeltaSigAttestationResult, DeltaSigAttestationVerifyResult, DsseEnvelope, DsseSignature, InTotoStatement, InTotoSubject, StoredInclusionProof, DeltaSigEnvelopeBuilder); responsibilities may be bundled.
## Maintainability Notes
- File length 487 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DeltaSigPredicate
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/Attestation/DeltaSigPredicate.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DeltaSigPredicate, DeltaSigSubject, FunctionDelta, IrDiff, DeltaSummary, DeltaTooling, VersionRange, LargeBlobReference); responsibilities may be bundled.
## Maintainability Notes
- File length 492 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,16 @@
# SOLID Review - D
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/Attestation/DeltaSigPredicateConverter.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 252 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - DeltaSigPredicateV2
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/Attestation/DeltaSigPredicateV2.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DeltaSigPredicateV2, DeltaSigSubjectV2, FunctionMatchV2, SymbolProvenanceV2, IrDiffReferenceV2, DeltaToolingV2, DeltaSummaryV2, DeltaSigVerdicts, MatchStates, MatchMethods, SignatureStates); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 549 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - BasicBlock
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/CfgExtractor.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BasicBlock, BlockTerminatorKind, ControlFlowGraph, CfgMetrics, CfgExtractor); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 504 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - D
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/DeltaSigService.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 618 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - DeltaSigServiceV2
## Scope
- File: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/DeltaSigServiceV2.cs
- Project: src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.DeltaSig/StellaOps.BinaryIndex.DeltaSig.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (DeltaSigServiceV2, IDeltaSigServiceV2, DeltaSigRequestV2, PredicateVersionRequest, PredicateVersion); responsibilities may be bundled.
## Maintainability Notes
- File length 421 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

Some files were not shown because too many files have changed in this diff Show More