archive audit attempts

This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions

View File

@@ -0,0 +1,15 @@
# SOLID Review - AocForbiddenFieldAnalyzer
## Scope
- File: src/Aoc/__Analyzers/StellaOps.Aoc.Analyzers/AocForbiddenFieldAnalyzer.cs
- Project: src/Aoc/__Analyzers/StellaOps.Aoc.Analyzers/StellaOps.Aoc.Analyzers.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (AocForbiddenFieldAnalyzer, AnalyzerTypeSymbols); responsibilities may be bundled.
## Maintainability Notes
- File length 633 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/Results/AocHttpResults.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/StellaOps.Aoc.AspNetCore.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,16 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/Routing/AocGuardEndpointFilter.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/StellaOps.Aoc.AspNetCore.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: filter enforces guard validation; helper logic split into partials.
- Dependency inversion: dependencies injected; no service locator usage.
## Maintainability Notes
- Helper partials isolate argument resolution and payload validation.
- Constructor injection simplifies testing and reuse.
## Recommendations
- Keep as-is; prefer `RequireAocGuard` for wiring endpoints.

View File

@@ -0,0 +1,15 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/Routing/AocGuardEndpointFilterExtensions.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc.AspNetCore/StellaOps.Aoc.AspNetCore.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocError.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocForbiddenKeys.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocGuardException.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocGuardExtensions.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocGuardOptions.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocGuardResult.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocViolation.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - AocViolationCode
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocViolationCode.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: enum definition only; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - AocWriteGuard
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/AocWriteGuard.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: orchestrates guard validation; detailed checks are grouped into partials.
## Maintainability Notes
- Partial helpers keep validation steps isolated and file length manageable.
## Recommendations
- Keep as-is; extract dedicated validators if new validation domains are added.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IAocGuard
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/IAocGuard.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-02-04
## Findings
- Single responsibility: interface defines guard contract; cohesive.
## Maintainability Notes
- Small surface area; easy to adapt.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - S
## Scope
- File: src/Aoc/__Libraries/StellaOps.Aoc/ServiceCollectionExtensions.cs
- Project: src/Aoc/__Libraries/StellaOps.Aoc/StellaOps.Aoc.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - AocForbiddenFieldAnalyzerTests
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.Analyzers.Tests/AocForbiddenFieldAnalyzerTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.Analyzers.Tests/StellaOps.Aoc.Analyzers.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (AocForbiddenFieldAnalyzerTests, AdvisoryModel, Ingester, Processor, IngesterTests, AocIngestionAttribute, DbContext, TestDbContext, CustomRepo, IAocGuard); responsibilities may be bundled.
## Maintainability Notes
- File length 472 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - AocGuardEndpointFilterExtensionsTests
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/AocGuardEndpointFilterExtensionsTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/StellaOps.Aoc.AspNetCore.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (AocGuardEndpointFilterExtensionsTests, GuardPayload); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - AocGuardEndpointFilterTests
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/AocGuardEndpointFilterTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/StellaOps.Aoc.AspNetCore.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (AocGuardEndpointFilterTests, GuardPayload, SelfReferencingPayload, TestAocGuard, TestEndpointFilterInvocationContext); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/AocHttpResultsTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.AspNetCore.Tests/StellaOps.Aoc.AspNetCore.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.Tests/AocErrorTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.Tests/StellaOps.Aoc.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - A
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.Tests/AocWriteGuardTests.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.Tests/StellaOps.Aoc.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 212 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Aoc/__Tests/StellaOps.Aoc.Tests/UnitTest1.cs
- Project: src/Aoc/__Tests/StellaOps.Aoc.Tests/StellaOps.Aoc.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.