stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity

archive audit attempts

Browse Source
This commit is contained in:
master
2026-02-19 22:00:31 +02:00
parent c2f13fe588
commit b5829dce5c
19638 changed files with 6366 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
docs-archived/implplan-blocked/audits/csproj-standards/Tools/NotifySmokeCheck/NotifySmokeCheck.md Normal file
View File

@@ -0,0 +1,41 @@
# Audit - NotifySmokeCheck
## Project
- Path: `src/Tools/NotifySmokeCheck/NotifySmokeCheck.csproj`
- Module: `Tools`
- Kind: `Tool`
- SDK: `Microsoft.NET.Sdk`
- TargetFramework: `net10.0`
- Audit date (UTC): 2026-01-30
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 1
- Service locator usage (BuildServiceProvider/GetService): 0
- Analyzer enforcement: missing repo-wide (see summary).
### Details
- 100-line files:
- `src/Tools/NotifySmokeCheck/NotifySmokeCheckRunner.cs` (515 lines)
- Service locator matches:
- none
### Fix Guidance
- Split files over 100 lines into smaller types or partials.
## Testing Fullness Findings
- Status: FAIL
- Expected layers: Unit, CLI, Offline
- Detected test projects: src/Tools/__Tests/NotifySmokeCheck.Tests/NotifySmokeCheck.Tests.csproj [Unit]
- Missing layers: CLI, Offline
### Manual checks required
- Observability contract tests for WebService/Worker.
- Offline execution (tests must run without network access).
### Fix Guidance
- Add offline/airgap coverage with fixtures only.
- Add CLI tests for exit codes and golden output.