setup and mock fixes

src/Platform/StellaOps.Platform.WebService/Endpoints/SeedEndpoints.cs

@@ -1,19 +1,20 @@
 // Copyright (c) StellaOps. All rights reserved.
 // Licensed under BUSL-1.1. See LICENSE in the project root.
-// Description: Admin endpoint for seeding demo data into all module databases.
 
 using Microsoft.AspNetCore.Builder;
 using Microsoft.AspNetCore.Http;
+using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.Routing;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
-using StellaOps.Infrastructure.Postgres.Migrations;
 using StellaOps.Authority.Persistence.Postgres;
-using StellaOps.Scheduler.Persistence.Postgres;
 using StellaOps.Concelier.Persistence.Postgres;
-using StellaOps.Policy.Persistence.Postgres;
-using StellaOps.Notify.Persistence.Postgres;
 using StellaOps.Excititor.Persistence.Postgres;
+using StellaOps.Infrastructure.Postgres.Migrations;
+using StellaOps.Notify.Persistence.Postgres;
+using StellaOps.Platform.WebService.Constants;
+using StellaOps.Policy.Persistence.Postgres;
+using StellaOps.Scheduler.Persistence.Postgres;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -24,23 +25,26 @@ using System.Threading.Tasks;
 namespace StellaOps.Platform.WebService.Endpoints;
 
 /// <summary>
-/// Admin-only endpoint for seeding databases with demo data.
-/// Gated by STELLAOPS_ENABLE_DEMO_SEED environment variable.
+/// Admin endpoint for seeding demo data into module schemas.
 /// </summary>
 public static class SeedEndpoints
 {
+    private const string DemoSeedEnabledKey = "STELLAOPS_ENABLE_DEMO_SEED";
+
     public static IEndpointRouteBuilder MapSeedEndpoints(this IEndpointRouteBuilder app)
     {
         var seed = app.MapGroup("/api/v1/admin")
             .WithTags("Admin - Demo Seed")
-            .RequireAuthorization("admin");
+            .RequireAuthorization(PlatformPolicies.SetupAdmin);
 
         seed.MapPost("/seed-demo", HandleSeedDemoAsync)
             .WithName("SeedDemo")
             .WithSummary("Seed all databases with demo data")
             .Produces<SeedDemoResponse>(StatusCodes.Status200OK)
-            .Produces(StatusCodes.Status403Forbidden)
-            .Produces(StatusCodes.Status503ServiceUnavailable);
+            .Produces<ProblemDetails>(StatusCodes.Status400BadRequest)
+            .Produces<ProblemDetails>(StatusCodes.Status403Forbidden)
+            .Produces<ProblemDetails>(StatusCodes.Status503ServiceUnavailable)
+            .Produces<ProblemDetails>(StatusCodes.Status500InternalServerError);
 
         return app;
     }
@@ -51,97 +55,185 @@ public static class SeedEndpoints
         ILoggerFactory loggerFactory,
         CancellationToken ct)
     {
-        var enabled = configuration.GetValue<bool>("STELLAOPS_ENABLE_DEMO_SEED",
-            bool.TryParse(Environment.GetEnvironmentVariable("STELLAOPS_ENABLE_DEMO_SEED"), out var envVal) && envVal);
-
-        if (!enabled)
-        {
-            return Results.Json(new { error = "Demo seeding is disabled. Set STELLAOPS_ENABLE_DEMO_SEED=true to enable." },
-                statusCode: StatusCodes.Status503ServiceUnavailable);
-        }
-
-        var modules = request?.Modules ?? ["all"];
-        var dryRun = request?.DryRun ?? false;
         var logger = loggerFactory.CreateLogger("SeedEndpoints");
 
-        logger.LogInformation("Demo seed requested. Modules={Modules}, DryRun={DryRun}", string.Join(",", modules), dryRun);
-
-        // Resolve connection string
-        var connectionString = ResolveConnectionString(configuration);
-        if (string.IsNullOrEmpty(connectionString))
+        try
         {
-            return Results.Json(new { error = "No PostgreSQL connection string configured." },
-                statusCode: StatusCodes.Status503ServiceUnavailable);
+            if (!IsDemoSeedingEnabled(configuration))
+            {
+                return Results.Problem(
+                    statusCode: StatusCodes.Status503ServiceUnavailable,
+                    title: "Demo seeding is disabled",
+                    detail: $"Set {DemoSeedEnabledKey}=true to enable this endpoint.");
+            }
+
+            var moduleValidation = ValidateRequestedModules(request?.Modules);
+            if (moduleValidation.Error is not null)
+            {
+                return Results.Problem(
+                    statusCode: StatusCodes.Status400BadRequest,
+                    title: "Invalid module filter",
+                    detail: moduleValidation.Error);
+            }
+
+            var modules = moduleValidation.Modules;
+            var dryRun = request?.DryRun ?? false;
+            var moduleInfos = GetSeedModules(modules);
+
+            if (moduleInfos.Count == 0)
+            {
+                return Results.Problem(
+                    statusCode: StatusCodes.Status400BadRequest,
+                    title: "No modules selected",
+                    detail: "The request did not resolve to any seedable module.");
+            }
+
+            logger.LogInformation(
+                "Demo seed requested. Modules={Modules}, DryRun={DryRun}",
+                string.Join(",", modules),
+                dryRun);
+
+            var connectionString = ResolveConnectionString(configuration);
+            if (string.IsNullOrWhiteSpace(connectionString))
+            {
+                return Results.Problem(
+                    statusCode: StatusCodes.Status503ServiceUnavailable,
+                    title: "Database connection unavailable",
+                    detail: "No PostgreSQL connection string configured for demo seeding.");
+            }
+
+            var results = new List<SeedModuleResult>(moduleInfos.Count);
+
+            foreach (var module in moduleInfos)
+            {
+                try
+                {
+                    var runner = new MigrationRunner(
+                        connectionString,
+                        module.SchemaName,
+                        module.Name,
+                        loggerFactory.CreateLogger($"migration.seed.{module.Name}"));
+
+                    var options = new MigrationRunOptions
+                    {
+                        CategoryFilter = MigrationCategory.Seed,
+                        DryRun = dryRun,
+                        TimeoutSeconds = 300,
+                        ValidateChecksums = true,
+                        FailOnChecksumMismatch = true,
+                    };
+
+                    var result = await runner.RunFromAssemblyAsync(
+                        module.Assembly,
+                        module.ResourcePrefix,
+                        options,
+                        ct).ConfigureAwait(false);
+
+                    results.Add(new SeedModuleResult
+                    {
+                        Module = module.Name,
+                        Success = result.Success,
+                        Applied = result.AppliedCount,
+                        Skipped = result.SkippedCount,
+                        DurationMs = result.DurationMs,
+                        Error = result.ErrorMessage,
+                    });
+                }
+                catch (Exception ex)
+                {
+                    logger.LogError(ex, "Seed failed for module {Module}", module.Name);
+                    results.Add(new SeedModuleResult
+                    {
+                        Module = module.Name,
+                        Success = false,
+                        Error = ex.Message,
+                    });
+                }
+            }
+
+            var allSuccess = results.All(static result => result.Success);
+            var response = new SeedDemoResponse
+            {
+                Success = allSuccess,
+                DryRun = dryRun,
+                Modules = results,
+                Message = allSuccess
+                    ? (dryRun ? "Dry run complete. No data was modified." : "Demo data seeded successfully.")
+                    : "Some modules failed to seed. Check individual module results.",
+            };
+
+            return Results.Ok(response);
+        }
+        catch (Exception ex)
+        {
+            logger.LogError(ex, "Unhandled seed endpoint failure");
+            return Results.Problem(
+                statusCode: StatusCodes.Status500InternalServerError,
+                title: "Demo seeding failed",
+                detail: "Unexpected server error while processing demo seeding.");
+        }
+    }
+
+    private static bool IsDemoSeedingEnabled(IConfiguration configuration)
+    {
+        var configured = configuration.GetValue<bool?>(DemoSeedEnabledKey);
+        if (configured.HasValue)
+        {
+            return configured.Value;
         }
 
-        var results = new List<SeedModuleResult>();
+        return bool.TryParse(Environment.GetEnvironmentVariable(DemoSeedEnabledKey), out var envVal) && envVal;
+    }
 
-        // Get the module definitions matching MigrationModuleRegistry in the CLI
-        var moduleInfos = GetSeedModules(modules);
+    private static (string[] Modules, string? Error) ValidateRequestedModules(string[]? requestedModules)
+    {
+        var modules = requestedModules?
+            .Where(static module => !string.IsNullOrWhiteSpace(module))
+            .Select(static module => module.Trim())
+            .ToArray() ?? [];
 
-        foreach (var module in moduleInfos)
+        if (modules.Length == 0)
         {
-            try
-            {
-                var runner = new MigrationRunner(
-                    connectionString,
-                    module.SchemaName,
-                    module.Name,
-                    loggerFactory.CreateLogger($"migration.seed.{module.Name}"));
-
-                var options = new MigrationRunOptions
-                {
-                    CategoryFilter = MigrationCategory.Seed,
-                    DryRun = dryRun,
-                    TimeoutSeconds = 300,
-                    ValidateChecksums = true,
-                    FailOnChecksumMismatch = true,
-                };
-
-                var result = await runner.RunFromAssemblyAsync(
-                    module.Assembly, module.ResourcePrefix, options, ct);
-
-                results.Add(new SeedModuleResult
-                {
-                    Module = module.Name,
-                    Success = result.Success,
-                    Applied = result.AppliedCount,
-                    Skipped = result.SkippedCount,
-                    DurationMs = result.DurationMs,
-                    Error = result.ErrorMessage,
-                });
-            }
-            catch (Exception ex)
-            {
-                logger.LogError(ex, "Seed failed for module {Module}", module.Name);
-                results.Add(new SeedModuleResult
-                {
-                    Module = module.Name,
-                    Success = false,
-                    Error = ex.Message,
-                });
-            }
+            modules = ["all"];
         }
 
-        var allSuccess = results.All(r => r.Success);
-        var response = new SeedDemoResponse
+        var hasAll = modules.Any(static module => module.Equals("all", StringComparison.OrdinalIgnoreCase));
+        if (hasAll && modules.Length > 1)
         {
-            Success = allSuccess,
-            DryRun = dryRun,
-            Modules = results,
-            Message = allSuccess
-                ? (dryRun ? "Dry run complete. No data was modified." : "Demo data seeded successfully.")
-                : "Some modules failed to seed. Check individual module results.",
-        };
+            return (Array.Empty<string>(), "Module list cannot mix 'all' with specific module names.");
+        }
 
-        return Results.Ok(response);
+        if (hasAll)
+        {
+            return (["all"], null);
+        }
+
+        var knownModules = GetAllSeedModules()
+            .Select(static module => module.Name)
+            .ToHashSet(StringComparer.OrdinalIgnoreCase);
+
+        var unknownModules = modules
+            .Where(module => !knownModules.Contains(module))
+            .OrderBy(module => module, StringComparer.OrdinalIgnoreCase)
+            .ToArray();
+
+        if (unknownModules.Length > 0)
+        {
+            var known = string.Join(", ", knownModules.OrderBy(static module => module, StringComparer.OrdinalIgnoreCase));
+            var unknown = string.Join(", ", unknownModules);
+            return (Array.Empty<string>(), $"Unknown module(s): {unknown}. Known modules: {known}.");
+        }
+
+        return (modules, null);
     }
 
     private static string? ResolveConnectionString(IConfiguration configuration)
     {
-        // Check env vars first, then configuration
         var candidates = new[]
         {
+            configuration.GetConnectionString("Default"),
+            configuration["ConnectionStrings:Default"],
+            configuration["ConnectionStrings:Postgres"],
             Environment.GetEnvironmentVariable("STELLAOPS_POSTGRES_CONNECTION"),
             Environment.GetEnvironmentVariable("STELLAOPS_DB_CONNECTION"),
             configuration["StellaOps:Postgres:ConnectionString"],
@@ -149,32 +241,12 @@ public static class SeedEndpoints
             configuration["Database:ConnectionString"],
         };
 
-        return candidates.FirstOrDefault(c => !string.IsNullOrWhiteSpace(c));
+        return candidates.FirstOrDefault(static candidate => !string.IsNullOrWhiteSpace(candidate));
     }
 
     private static List<SeedModuleInfo> GetSeedModules(string[] moduleFilter)
     {
-        var all = new List<SeedModuleInfo>
-        {
-            new("Authority", "authority",
-                typeof(AuthorityDataSource).Assembly,
-                "StellaOps.Authority.Persistence.Migrations"),
-            new("Scheduler", "scheduler",
-                typeof(SchedulerDataSource).Assembly,
-                "StellaOps.Scheduler.Persistence.Migrations"),
-            new("Concelier", "vuln",
-                typeof(ConcelierDataSource).Assembly,
-                "StellaOps.Concelier.Persistence.Migrations"),
-            new("Policy", "policy",
-                typeof(PolicyDataSource).Assembly,
-                "StellaOps.Policy.Persistence.Migrations"),
-            new("Notify", "notify",
-                typeof(NotifyDataSource).Assembly,
-                "StellaOps.Notify.Persistence.Migrations"),
-            new("Excititor", "vex",
-                typeof(ExcititorDataSource).Assembly,
-                "StellaOps.Excititor.Persistence.Migrations"),
-        };
+        var all = GetAllSeedModules();
 
         if (moduleFilter.Length == 1 && moduleFilter[0].Equals("all", StringComparison.OrdinalIgnoreCase))
         {
@@ -182,10 +254,47 @@ public static class SeedEndpoints
         }
 
         var filterSet = new HashSet<string>(moduleFilter, StringComparer.OrdinalIgnoreCase);
-        return all.Where(m => filterSet.Contains(m.Name)).ToList();
+        return all
+            .Where(module => filterSet.Contains(module.Name))
+            .ToList();
     }
 
-    // ── DTOs ──────────────────────────────────────────────────────────────────
+    private static List<SeedModuleInfo> GetAllSeedModules()
+    {
+        return
+        [
+            new SeedModuleInfo(
+                Name: "Authority",
+                SchemaName: "authority",
+                Assembly: typeof(AuthorityDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Authority.Persistence.Migrations"),
+            new SeedModuleInfo(
+                Name: "Scheduler",
+                SchemaName: "scheduler",
+                Assembly: typeof(SchedulerDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Scheduler.Persistence.Migrations"),
+            new SeedModuleInfo(
+                Name: "Concelier",
+                SchemaName: "vuln",
+                Assembly: typeof(ConcelierDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Concelier.Persistence.Migrations"),
+            new SeedModuleInfo(
+                Name: "Policy",
+                SchemaName: "policy",
+                Assembly: typeof(PolicyDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Policy.Persistence.Migrations"),
+            new SeedModuleInfo(
+                Name: "Notify",
+                SchemaName: "notify",
+                Assembly: typeof(NotifyDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Notify.Persistence.Migrations"),
+            new SeedModuleInfo(
+                Name: "Excititor",
+                SchemaName: "vex",
+                Assembly: typeof(ExcititorDataSource).Assembly,
+                ResourcePrefix: "StellaOps.Excititor.Persistence.Migrations"),
+        ];
+    }
 
     private sealed record SeedModuleInfo(
         string Name,
@@ -203,13 +312,13 @@ public static class SeedEndpoints
     {
         public bool Success { get; set; }
         public bool DryRun { get; set; }
-        public string Message { get; set; } = "";
+        public string Message { get; set; } = string.Empty;
         public List<SeedModuleResult> Modules { get; set; } = [];
     }
 
     public sealed class SeedModuleResult
     {
-        public string Module { get; set; } = "";
+        public string Module { get; set; } = string.Empty;
         public bool Success { get; set; }
         public int Applied { get; set; }
         public int Skipped { get; set; }