notify doctors work, audit work, new product advisory sprints

src/Policy/StellaOps.Policy.Engine/Simulation/RiskSimulationService.cs

@@ -1,8 +1,10 @@
 using System.Diagnostics;
+using System.Globalization;
 using System.Text;
 using System.Text.Json;
 using Microsoft.Extensions.Logging;
 using StellaOps.Cryptography;
+using StellaOps.Determinism;
 using StellaOps.Policy.Engine.Services;
 using StellaOps.Policy.Engine.Telemetry;
 using StellaOps.Policy.RiskProfile.Hashing;
@@ -21,6 +23,7 @@ public sealed class RiskSimulationService
     private readonly RiskProfileConfigurationService _profileService;
     private readonly RiskProfileHasher _hasher;
     private readonly ICryptoHash _cryptoHash;
+    private readonly IGuidProvider _guidProvider;
     private readonly RiskSimulationBreakdownService? _breakdownService;
 
     private static readonly double[] PercentileLevels = { 0.25, 0.50, 0.75, 0.90, 0.95, 0.99 };
@@ -32,12 +35,14 @@ public sealed class RiskSimulationService
         TimeProvider timeProvider,
         RiskProfileConfigurationService profileService,
         ICryptoHash cryptoHash,
+        IGuidProvider guidProvider,
         RiskSimulationBreakdownService? breakdownService = null)
     {
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
         _timeProvider = timeProvider ?? throw new ArgumentNullException(nameof(timeProvider));
         _profileService = profileService ?? throw new ArgumentNullException(nameof(profileService));
         _cryptoHash = cryptoHash ?? throw new ArgumentNullException(nameof(cryptoHash));
+        _guidProvider = guidProvider ?? throw new ArgumentNullException(nameof(guidProvider));
         _hasher = new RiskProfileHasher(cryptoHash);
         _breakdownService = breakdownService;
     }
@@ -226,7 +231,7 @@ public sealed class RiskSimulationService
                 long l => l,
                 decimal dec => (double)dec,
                 JsonElement je when je.TryGetDouble(out var d) => d,
-                string s when double.TryParse(s, out var d) => d,
+                string s when double.TryParse(s, NumberStyles.Float, CultureInfo.InvariantCulture, out var d) => d,
                 _ => 0.0
             },
             RiskSignalType.Categorical => value switch
@@ -461,7 +466,7 @@ public sealed class RiskSimulationService
 
     private string GenerateSimulationId(RiskSimulationRequest request, string profileHash)
     {
-        var seed = $"{request.ProfileId}|{profileHash}|{request.Findings.Count}|{Guid.NewGuid()}";
+        var seed = $"{request.ProfileId}|{profileHash}|{request.Findings.Count}|{_guidProvider.NewGuid()}";
         var hash = _cryptoHash.ComputeHashHexForPurpose(Encoding.UTF8.GetBytes(seed), HashPurpose.Content);
         return $"rsim-{hash[..16]}";
     }