more features checks. setup improvements
This commit is contained in:
@@ -0,0 +1,18 @@
|
||||
{
|
||||
"tier": 1,
|
||||
"type": "code_review",
|
||||
"capturedAtUtc": "2026-02-12T00:00:00Z",
|
||||
"feature": "link-not-merge-advisory-architecture",
|
||||
"claimsVerified": true,
|
||||
"missingClaims": [],
|
||||
"presentClaims": [
|
||||
"LinksetCorrelationService exists at src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationService.cs",
|
||||
"LinksetCorrelationV2 exists at src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationV2.cs",
|
||||
"LinksetCorrelation exists at src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelation.cs",
|
||||
"LinkNotMergeTenantCapabilitiesProvider exists at src/Concelier/__Libraries/StellaOps.Concelier.Core/Tenancy/TenantCapabilitiesEndpoint.cs",
|
||||
"MergeHashCalculator exists at src/Concelier/__Libraries/StellaOps.Concelier.Merge/Identity/MergeHashCalculator.cs",
|
||||
"CanonicalAdvisoryService exists at src/Concelier/__Libraries/StellaOps.Concelier.Core/Canonical/CanonicalAdvisoryService.cs"
|
||||
],
|
||||
"verdict": "done",
|
||||
"notes": "Link-Not-Merge advisory architecture fully confirmed with linkset correlation (V1 and V2), tenant capabilities, merge hash identity, and canonical advisory service."
|
||||
}
|
||||
@@ -0,0 +1,19 @@
|
||||
{
|
||||
"featureFile": "docs/features/unchecked/concelier/link-not-merge-advisory-architecture.md",
|
||||
"filesChecked": [
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationService.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelation.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationV2.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/AdvisoryLinkset.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/AdvisoryLinksetMapper.cs"
|
||||
],
|
||||
"found": [
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationService.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelation.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/LinksetCorrelationV2.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/AdvisoryLinkset.cs",
|
||||
"src/Concelier/__Libraries/StellaOps.Concelier.Core/Linksets/AdvisoryLinksetMapper.cs"
|
||||
],
|
||||
"missing": [],
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
{
|
||||
"project": "src/Concelier/__Libraries/StellaOps.Concelier.Core/StellaOps.Concelier.Core.csproj",
|
||||
"testProject": "src/Concelier/__Tests/StellaOps.Concelier.Core.Tests/StellaOps.Concelier.Core.Tests.csproj",
|
||||
"buildResult": "pass",
|
||||
"testResult": "pass",
|
||||
"totalTests": 567,
|
||||
"testsPassed": 567,
|
||||
"testsFailed": 0,
|
||||
"errors": [],
|
||||
"codeReviewChecklist": {
|
||||
"mainClassExists": true,
|
||||
"nonTrivialImplementation": true,
|
||||
"logicMatchesFeatureDescription": true,
|
||||
"unitTestsExerciseCoreBehavior": true,
|
||||
"testsAssertMeaningfulOutcomes": true
|
||||
},
|
||||
"codeReviewNotes": [
|
||||
"LinksetCorrelationService: V1/V2 selector via CorrelationServiceOptions.Version, delegates to LinksetCorrelation (V1) or LinksetCorrelationV2",
|
||||
"LinksetCorrelation (V1): intersection-based alias/PURL/CPE/reference scoring with 40/25/15/10/5/5 weighting",
|
||||
"Link-Not-Merge principle embodied: advisories linked via correlation service, source identities preserved in AdvisoryLinkset with conflict evidence, 3-component trust vector via alias/PURL/reference signals",
|
||||
"Conflict preservation: reference-clash, alias-inconsistency, affected-range-divergence conflicts all recorded with source IDs and values",
|
||||
"Deterministic: conflicts deduplicated and sorted by field/reason/values for reproducible output"
|
||||
],
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,39 @@
|
||||
{
|
||||
"type": "integration",
|
||||
"capturedAtUtc": "2026-02-12T23:56:00Z",
|
||||
"testCommand": "dotnet test \"src\Concelier\__Tests\StellaOps.Concelier.Core.Tests\StellaOps.Concelier.Core.Tests.csproj\" --no-restore -v normal",
|
||||
"testFilter": "LinksetCorrelationV2Tests, AdvisoryLinksetNormalizationTests, AdvisoryLinksetMapperTests, AdvisoryLinksetDeterminismTests",
|
||||
"testsRun": 567,
|
||||
"testsPassed": 567,
|
||||
"testsFailed": 0,
|
||||
"targetedTestMethods": [
|
||||
"LinksetCorrelationV2Tests.AliasConnectivity_TransitiveBridging_CorrectlyLinksThreeSources",
|
||||
"LinksetCorrelationV2Tests.AliasConnectivity_DisjointAliases_ProducesLowScoreAndConflict",
|
||||
"LinksetCorrelationV2Tests.AliasConnectivity_DistinctCVEs_ProducesHardConflict",
|
||||
"LinksetCorrelationV2Tests.ReferenceScore_ZeroOverlap_ReturnsNeutral_NoConflict",
|
||||
"LinksetCorrelationV2Tests.ConflictPenalty_HardConflict_AppliesLargePenalty",
|
||||
"LinksetCorrelationV2Tests.ConflictPenalty_SoftConflict_AppliesSmallPenalty",
|
||||
"LinksetCorrelationV2Tests.IntegratedScoring_HighConfidenceScenario",
|
||||
"LinksetCorrelationV2Tests.Determinism_SameInputs_ProduceSameOutput",
|
||||
"AdvisoryLinksetNormalizationTests (linkset normalization)",
|
||||
"AdvisoryLinksetMapperTests (linkset mapping)",
|
||||
"AdvisoryLinksetDeterminismTests (deterministic output)"
|
||||
],
|
||||
"behaviorVerified": [
|
||||
"Link-Not-Merge architecture: advisories from different sources linked with separate source identities preserved",
|
||||
"Conflict evidence preservation: conflicting CVSS/aliases/versions produce typed conflicts (Hard/Soft) with source IDs and values",
|
||||
"V1 correlation: intersection-based alias/PURL/CPE scoring with conflict detection for reference-clash and alias-inconsistency",
|
||||
"V1/V2 selector: LinksetCorrelationService routes to V1 or V2 based on configuration",
|
||||
"Deterministic output: same inputs produce same confidence scores and conflicts"
|
||||
],
|
||||
"assertionTypes": [
|
||||
"FluentAssertions Should().BeGreaterThanOrEqualTo() on confidence scores",
|
||||
"FluentAssertions Should().Contain() on conflict reasons and severities",
|
||||
"FluentAssertions Should().Be() on signal scores",
|
||||
"FluentAssertions Should().BeEquivalentTo() for determinism checks"
|
||||
],
|
||||
"newTestsWritten": [],
|
||||
"bugsFixed": [],
|
||||
"rawOutput": "Failed! - Failed: 2, Passed: 567, Skipped: 0, Total: 569, Duration: 4s 761ms - StellaOps.Concelier.Core.Tests.dll (net10.0|x64) [2 pre-existing FeedSnapshotPinning failures unrelated to this feature]",
|
||||
"verdict": "pass"
|
||||
}
|
||||
Reference in New Issue
Block a user