save progress

src/Concelier/__Tests/StellaOps.Concelier.Analyzers.Tests/AGENTS.md

@@ -0,0 +1,20 @@
+# Concelier Analyzer Tests Charter
+
+## Mission
+Own tests for the Concelier analyzer rules.
+
+## Responsibilities
+- Keep analyzer diagnostics deterministic and scoped to Concelier connectors.
+- Maintain test coverage for allowed/blocked HttpClient usage.
+
+## Key Paths
+- `ConnectorHttpClientSandboxAnalyzerTests.cs`
+
+## Required Reading
+- `docs/modules/concelier/architecture.md`
+- `docs/modules/platform/architecture-overview.md`
+
+## Working Agreement
+- 1. Update task status to `DOING`/`DONE` in both corresponding sprint file `/docs/implplan/SPRINT_*.md` and the local `TASKS.md` when you start or finish work.
+- 2. Review this charter and the Required Reading documents before coding; confirm prerequisites are met.
+- 3. Keep changes deterministic (stable ordering, timestamps, hashes) and align with offline/air-gap expectations.

src/Concelier/__Tests/StellaOps.Concelier.Analyzers.Tests/ConnectorHttpClientSandboxAnalyzerTests.cs

@@ -0,0 +1,113 @@
+using System;
+using System.Collections.Generic;
+using System.Collections.Immutable;
+using System.Linq;
+using System.Net.Http;
+using System.Reflection;
+using System.Threading.Tasks;
+using Microsoft.CodeAnalysis;
+using Microsoft.CodeAnalysis.CSharp;
+using Microsoft.CodeAnalysis.Diagnostics;
+using StellaOps.TestKit;
+
+namespace StellaOps.Concelier.Analyzers.Tests;
+
+public sealed class ConnectorHttpClientSandboxAnalyzerTests
+{
+    [Trait("Category", TestCategories.Unit)]
+    [Fact]
+    public async Task ReportsDiagnostic_ForHttpClientInConnectorNamespace()
+    {
+        const string source = """
+            using System.Net.Http;
+
+            namespace StellaOps.Concelier.Connector.Demo;
+
+            public sealed class ClientFactory
+            {
+                public HttpClient Create() => new HttpClient();
+            }
+            """;
+
+        var diagnostics = await AnalyzeAsync(source, "StellaOps.Concelier.Connector.Demo");
+        Assert.Contains(diagnostics, d => d.Id == ConnectorHttpClientSandboxAnalyzer.DiagnosticId);
+    }
+
+    [Trait("Category", TestCategories.Unit)]
+    [Fact]
+    public async Task DoesNotReportDiagnostic_OutsideConnectorNamespace()
+    {
+        const string source = """
+            using System.Net.Http;
+
+            namespace Sample.App;
+
+            public sealed class ClientFactory
+            {
+                public HttpClient Create() => new HttpClient();
+            }
+            """;
+
+        var diagnostics = await AnalyzeAsync(source, "Sample.App");
+        Assert.DoesNotContain(diagnostics, d => d.Id == ConnectorHttpClientSandboxAnalyzer.DiagnosticId);
+    }
+
+    [Trait("Category", TestCategories.Unit)]
+    [Theory]
+    [InlineData("StellaOps.Concelier.Connector.Demo.Tests")]
+    [InlineData("StellaOps.Concelier.Connector.Demo.Test")]
+    [InlineData("StellaOps.Concelier.Connector.Demo.Testing")]
+    public async Task DoesNotReportDiagnostic_InTestAssemblies(string assemblyName)
+    {
+        const string source = """
+            using System.Net.Http;
+
+            namespace StellaOps.Concelier.Connector.Demo;
+
+            public sealed class ClientFactory
+            {
+                public HttpClient Create() => new HttpClient();
+            }
+            """;
+
+        var diagnostics = await AnalyzeAsync(source, assemblyName);
+        Assert.DoesNotContain(diagnostics, d => d.Id == ConnectorHttpClientSandboxAnalyzer.DiagnosticId);
+    }
+
+    [Trait("Category", TestCategories.Unit)]
+    [Fact]
+    public async Task DoesNotReportDiagnostic_ForOtherTypes()
+    {
+        const string source = """
+            namespace StellaOps.Concelier.Connector.Demo;
+
+            public sealed class ClientFactory
+            {
+                public object Create() => new object();
+            }
+            """;
+
+        var diagnostics = await AnalyzeAsync(source, "StellaOps.Concelier.Connector.Demo");
+        Assert.DoesNotContain(diagnostics, d => d.Id == ConnectorHttpClientSandboxAnalyzer.DiagnosticId);
+    }
+
+    private static async Task<ImmutableArray<Diagnostic>> AnalyzeAsync(string source, string assemblyName)
+    {
+        var compilation = CSharpCompilation.Create(
+            assemblyName,
+            new[] { CSharpSyntaxTree.ParseText(source) },
+            CreateMetadataReferences(),
+            new CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary));
+
+        var analyzer = new ConnectorHttpClientSandboxAnalyzer();
+        var compilationWithAnalyzers = compilation.WithAnalyzers(ImmutableArray.Create<DiagnosticAnalyzer>(analyzer));
+        return await compilationWithAnalyzers.GetAnalyzerDiagnosticsAsync();
+    }
+
+    private static IEnumerable<MetadataReference> CreateMetadataReferences()
+    {
+        yield return MetadataReference.CreateFromFile(typeof(object).GetTypeInfo().Assembly.Location);
+        yield return MetadataReference.CreateFromFile(typeof(Enumerable).GetTypeInfo().Assembly.Location);
+        yield return MetadataReference.CreateFromFile(typeof(HttpClient).GetTypeInfo().Assembly.Location);
+    }
+}

src/Concelier/__Tests/StellaOps.Concelier.Analyzers.Tests/StellaOps.Concelier.Analyzers.Tests.csproj

@@ -0,0 +1,19 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFramework>net10.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+    <IsPackable>false</IsPackable>
+    <IsTestProject>true</IsTestProject>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all" />
+  </ItemGroup>
+
+  <ItemGroup>
+    <ProjectReference Include="..\..\__Analyzers\StellaOps.Concelier.Analyzers\StellaOps.Concelier.Analyzers.csproj" />
+    <ProjectReference Include="../../../__Libraries/StellaOps.TestKit/StellaOps.TestKit.csproj" />
+  </ItemGroup>
+</Project>

src/Concelier/__Tests/StellaOps.Concelier.Analyzers.Tests/TASKS.md

@@ -0,0 +1,8 @@
+# Concelier Analyzer Tests Task Board
+
+This board mirrors active sprint tasks for this module.
+Source of truth: `docs/implplan/SPRINT_20251229_049_BE_csproj_audit_maint_tests.md`.
+
+| Task ID | Status | Notes |
+| --- | --- | --- |
+| AUDIT-0144-A | DONE | Tests for StellaOps.Concelier.Analyzers. |