synergy moats product advisory implementations
This commit is contained in:
master
@@ -0,0 +1,123 @@
|
||||
// -----------------------------------------------------------------------------
|
||||
// DiskSpaceCheckTests.cs
|
||||
// Sprint: SPRINT_20260117_025_Doctor_coverage_expansion
|
||||
// Task: DOC-EXP-002 - Storage Health Check Plugin Tests
|
||||
// Description: Unit tests for DiskSpaceCheck
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
using System.Runtime.InteropServices;
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Moq;
|
||||
using StellaOps.Doctor.Plugin.Storage.Checks;
|
||||
using StellaOps.Doctor.Plugins;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Doctor.Plugin.Storage.Tests;
|
||||
|
||||
public sealed class DiskSpaceCheckTests
|
||||
{
|
||||
private readonly DiskSpaceCheck _check;
|
||||
|
||||
public DiskSpaceCheckTests()
|
||||
{
|
||||
_check = new DiskSpaceCheck();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CheckId_ReturnsExpectedValue()
|
||||
{
|
||||
Assert.Equal("check.storage.diskspace", _check.CheckId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Tags_ContainsStorageTag()
|
||||
{
|
||||
Assert.Contains("storage", _check.Tags);
|
||||
Assert.Contains("disk", _check.Tags);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CanRun_ReturnsTrue()
|
||||
{
|
||||
var context = CreateContext();
|
||||
Assert.True(_check.CanRun(context));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RunAsync_ReturnsResult()
|
||||
{
|
||||
var context = CreateContext();
|
||||
var result = await _check.RunAsync(context, CancellationToken.None);
|
||||
|
||||
Assert.NotNull(result);
|
||||
Assert.Equal(_check.CheckId, result.CheckId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RunAsync_WithValidPath_ReturnsPassOrWarn()
|
||||
{
|
||||
var tempDir = Path.GetTempPath();
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["Storage:DataPath"] = tempDir
|
||||
})
|
||||
.Build();
|
||||
|
||||
var context = CreateContext(config);
|
||||
var result = await _check.RunAsync(context, CancellationToken.None);
|
||||
|
||||
// Should pass or warn based on actual disk usage
|
||||
Assert.True(result.Status is DoctorStatus.Pass or DoctorStatus.Warn or DoctorStatus.Fail);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RunAsync_IsDeterministic()
|
||||
{
|
||||
var context = CreateContext();
|
||||
|
||||
var result1 = await _check.RunAsync(context, CancellationToken.None);
|
||||
var result2 = await _check.RunAsync(context, CancellationToken.None);
|
||||
|
||||
// Results should be structurally consistent
|
||||
Assert.Equal(result1.CheckId, result2.CheckId);
|
||||
Assert.Equal(result1.PluginId, result2.PluginId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task RunAsync_WithNonExistentPath_ReturnsSkip()
|
||||
{
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["Storage:DataPath"] = "/nonexistent/path/that/should/not/exist"
|
||||
})
|
||||
.Build();
|
||||
|
||||
var context = CreateContext(config);
|
||||
var result = await _check.RunAsync(context, CancellationToken.None);
|
||||
|
||||
// Should skip if path doesn't exist (on most systems)
|
||||
// Note: On Windows C:\ always exists, so this might not skip
|
||||
Assert.NotNull(result);
|
||||
}
|
||||
|
||||
private static DoctorPluginContext CreateContext(IConfiguration? config = null)
|
||||
{
|
||||
config ??= new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["Storage:DataPath"] = RuntimeInformation.IsOSPlatform(OSPlatform.Windows)
|
||||
? "C:\\Windows\\Temp"
|
||||
: "/tmp"
|
||||
})
|
||||
.Build();
|
||||
|
||||
var services = new Mock<IServiceProvider>();
|
||||
|
||||
return new DoctorPluginContext(
|
||||
Configuration: config,
|
||||
Services: services.Object,
|
||||
CancellationToken: CancellationToken.None);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,31 @@
|
||||
<Project Sdk="Microsoft.NET.Sdk">
|
||||
|
||||
<PropertyGroup>
|
||||
<TargetFramework>net10.0</TargetFramework>
|
||||
<ImplicitUsings>enable</ImplicitUsings>
|
||||
<Nullable>enable</Nullable>
|
||||
<LangVersion>preview</LangVersion>
|
||||
<IsPackable>false</IsPackable>
|
||||
<IsTestProject>true</IsTestProject>
|
||||
</PropertyGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<PackageReference Include="Microsoft.NET.Test.Sdk" />
|
||||
<PackageReference Include="Moq" />
|
||||
<PackageReference Include="xunit" />
|
||||
<PackageReference Include="xunit.runner.visualstudio">
|
||||
<PrivateAssets>all</PrivateAssets>
|
||||
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
|
||||
</PackageReference>
|
||||
<PackageReference Include="coverlet.collector">
|
||||
<PrivateAssets>all</PrivateAssets>
|
||||
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
|
||||
</PackageReference>
|
||||
</ItemGroup>
|
||||
|
||||
<ItemGroup>
|
||||
<ProjectReference Include="..\..\..\src\Doctor\__Plugins\StellaOps.Doctor.Plugin.Storage\StellaOps.Doctor.Plugin.Storage.csproj" />
|
||||
<ProjectReference Include="..\..\..\src\Doctor\__Libraries\StellaOps.Doctor\StellaOps.Doctor.csproj" />
|
||||
</ItemGroup>
|
||||
|
||||
</Project>
|
||||
@@ -0,0 +1,195 @@
|
||||
// -----------------------------------------------------------------------------
|
||||
// PostgresReportStorageServiceTests.cs
|
||||
// Sprint: SPRINT_20260117_025_Doctor_coverage_expansion
|
||||
// Task: DOC-EXP-005 - Persistent Report Storage Tests
|
||||
// Description: Unit tests for PostgresReportStorageService
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
using Microsoft.Extensions.Configuration;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Microsoft.Extensions.Options;
|
||||
using Moq;
|
||||
using StellaOps.Doctor.Models;
|
||||
using StellaOps.Doctor.WebService.Options;
|
||||
using StellaOps.Doctor.WebService.Services;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Doctor.WebService.Tests.Services;
|
||||
|
||||
public sealed class PostgresReportStorageServiceTests
|
||||
{
|
||||
[Fact]
|
||||
public void Constructor_WithMissingConnectionString_ThrowsException()
|
||||
{
|
||||
// Arrange
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>())
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions());
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
// Act & Assert
|
||||
Assert.Throws<InvalidOperationException>(() =>
|
||||
new PostgresReportStorageService(config, options, logger.Object));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Constructor_WithValidConnectionString_Succeeds()
|
||||
{
|
||||
// Arrange
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["ConnectionStrings:StellaOps"] = "Host=localhost;Database=test"
|
||||
})
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions { ReportRetentionDays = 0 });
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
// Act
|
||||
using var service = new PostgresReportStorageService(config, options, logger.Object);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(service);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Constructor_WithRetentionDays_StartsCleanupTimer()
|
||||
{
|
||||
// Arrange
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["ConnectionStrings:StellaOps"] = "Host=localhost;Database=test"
|
||||
})
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions { ReportRetentionDays = 30 });
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
// Act
|
||||
using var service = new PostgresReportStorageService(config, options, logger.Object);
|
||||
|
||||
// Assert - service should be created without error
|
||||
Assert.NotNull(service);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Dispose_CanBeCalledMultipleTimes()
|
||||
{
|
||||
// Arrange
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["Database:ConnectionString"] = "Host=localhost;Database=test"
|
||||
})
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions());
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
var service = new PostgresReportStorageService(config, options, logger.Object);
|
||||
|
||||
// Act & Assert - should not throw
|
||||
service.Dispose();
|
||||
service.Dispose();
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Integration tests for PostgresReportStorageService.
|
||||
/// These require a PostgreSQL instance and are skipped in CI unless configured.
|
||||
/// </summary>
|
||||
public sealed class PostgresReportStorageServiceIntegrationTests
|
||||
{
|
||||
private static bool IsPostgresAvailable()
|
||||
{
|
||||
var connString = Environment.GetEnvironmentVariable("STELLA_TEST_POSTGRES");
|
||||
return !string.IsNullOrEmpty(connString);
|
||||
}
|
||||
|
||||
[Fact(Skip = "Requires PostgreSQL instance")]
|
||||
public async Task StoreAndRetrieveReport_RoundTrip()
|
||||
{
|
||||
if (!IsPostgresAvailable())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// Arrange
|
||||
var connString = Environment.GetEnvironmentVariable("STELLA_TEST_POSTGRES")!;
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["ConnectionStrings:StellaOps"] = connString
|
||||
})
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions { ReportRetentionDays = 1 });
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
using var service = new PostgresReportStorageService(config, options, logger.Object);
|
||||
|
||||
var report = new DoctorReport
|
||||
{
|
||||
RunId = $"test-{Guid.NewGuid()}",
|
||||
StartedAt = DateTimeOffset.UtcNow,
|
||||
CompletedAt = DateTimeOffset.UtcNow.AddSeconds(5),
|
||||
OverallSeverity = DoctorSeverity.Pass,
|
||||
Summary = new DoctorSummary
|
||||
{
|
||||
Passed = 5,
|
||||
Warnings = 1,
|
||||
Failed = 0,
|
||||
Skipped = 2,
|
||||
Info = 1,
|
||||
Total = 9
|
||||
},
|
||||
Results = []
|
||||
};
|
||||
|
||||
// Act
|
||||
await service.StoreReportAsync(report, CancellationToken.None);
|
||||
var retrieved = await service.GetReportAsync(report.RunId, CancellationToken.None);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(retrieved);
|
||||
Assert.Equal(report.RunId, retrieved.RunId);
|
||||
Assert.Equal(report.OverallSeverity, retrieved.OverallSeverity);
|
||||
Assert.Equal(report.Summary.Passed, retrieved.Summary.Passed);
|
||||
|
||||
// Cleanup
|
||||
await service.DeleteReportAsync(report.RunId, CancellationToken.None);
|
||||
}
|
||||
|
||||
[Fact(Skip = "Requires PostgreSQL instance")]
|
||||
public async Task ListReports_ReturnsPaginatedResults()
|
||||
{
|
||||
if (!IsPostgresAvailable())
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// Arrange
|
||||
var connString = Environment.GetEnvironmentVariable("STELLA_TEST_POSTGRES")!;
|
||||
var config = new ConfigurationBuilder()
|
||||
.AddInMemoryCollection(new Dictionary<string, string?>
|
||||
{
|
||||
["ConnectionStrings:StellaOps"] = connString
|
||||
})
|
||||
.Build();
|
||||
|
||||
var options = Options.Create(new DoctorServiceOptions());
|
||||
var logger = new Mock<ILogger<PostgresReportStorageService>>();
|
||||
|
||||
using var service = new PostgresReportStorageService(config, options, logger.Object);
|
||||
|
||||
// Act
|
||||
var reports = await service.ListReportsAsync(limit: 10, offset: 0, CancellationToken.None);
|
||||
|
||||
// Assert
|
||||
Assert.NotNull(reports);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user