up

tests/reachability/StellaOps.Signals.Reachability.Tests/ReachabilityScoringTests.cs

@@ -8,7 +8,6 @@ using System.Threading.Tasks;
 using FluentAssertions;
 using Microsoft.Extensions.Logging.Abstractions;
 using Microsoft.Extensions.Options;
-using MongoDB.Bson;
 using StellaOps.Signals.Models;
 using StellaOps.Signals.Options;
 using StellaOps.Signals.Parsing;
@@ -47,15 +46,31 @@ public sealed class ReachabilityScoringTests
     public async Task RecomputedFactsMatchTruthFixtures(string caseId, string variant)
     {
         var casePath = Path.Combine(FixtureRoot, caseId);
-        var variantPath = Path.Combine(casePath, "images", variant);
-        var truth = JsonDocument.Parse(File.ReadAllText(Path.Combine(variantPath, "reachgraph.truth.json"))).RootElement;
-        var sinks = truth.GetProperty("sinks").EnumerateArray().Select(x => x.GetProperty("sid").GetString()!).ToList();
-        var entryPoints = truth.GetProperty("paths").EnumerateArray()
-            .Select(path => path[0].GetString()!)
+        var caseJson = JsonDocument.Parse(File.ReadAllText(Path.Combine(casePath, "case.json"))).RootElement;
+        var reachablePathsNode = caseJson
+            .GetProperty("ground_truth")
+            .GetProperty("reachable_variant")
+            .GetProperty("evidence")
+            .GetProperty("paths");
+
+        var paths = reachablePathsNode.EnumerateArray()
+            .Select(path => path.EnumerateArray().Select(x => x.GetString()!).Where(x => !string.IsNullOrWhiteSpace(x)).ToList())
+            .Where(path => path.Count > 0)
+            .ToList();
+
+        var entryPoints = paths
+            .Select(path => path[0])
+            .Where(p => !string.IsNullOrWhiteSpace(p))
             .Distinct(StringComparer.Ordinal)
             .ToList();
 
-        var callgraph = await LoadCallgraphAsync(caseId, variant, variantPath);
+        var sinks = paths
+            .Select(path => path[^1])
+            .Where(p => !string.IsNullOrWhiteSpace(p))
+            .Distinct(StringComparer.Ordinal)
+            .ToList();
+
+        var callgraph = BuildCallgraphFromPaths(caseId, paths);
         var callgraphRepo = new InMemoryCallgraphRepository(callgraph);
         var factRepo = new InMemoryReachabilityFactRepository();
         var options = new SignalsOptions();
@@ -66,7 +81,7 @@ public sealed class ReachabilityScoringTests
             callgraphRepo,
             factRepo,
             TimeProvider.System,
-            Options.Create(options),
+            Microsoft.Extensions.Options.Options.Create(options),
             cache,
             unknowns,
             eventsPublisher,
@@ -149,41 +164,46 @@ public sealed class ReachabilityScoringTests
         };
     }
 
-    private static async Task<CallgraphDocument> LoadCallgraphAsync(string caseId, string variant, string variantPath)
+    private static CallgraphDocument BuildCallgraphFromPaths(string caseId, IReadOnlyList<IReadOnlyList<string>> paths)
     {
-        var parser = new SimpleJsonCallgraphParser("fixture");
         var nodes = new Dictionary<string, CallgraphNode>(StringComparer.Ordinal);
         var edges = new List<CallgraphEdge>();
 
-        foreach (var fileName in new[] { "callgraph.static.json", "callgraph.framework.json" })
+        foreach (var path in paths)
         {
-            var path = Path.Combine(variantPath, fileName);
-            if (!File.Exists(path))
+            if (path.Count == 0)
             {
                 continue;
             }
 
-            await using var stream = File.OpenRead(path);
-            var result = await parser.ParseAsync(stream, CancellationToken.None);
-            foreach (var node in result.Nodes)
+            foreach (var nodeId in path)
             {
-                nodes[node.Id] = node;
+                if (!nodes.ContainsKey(nodeId))
+                {
+                    nodes[nodeId] = new CallgraphNode(nodeId, nodeId, "function", null, null, null);
+                }
             }
 
-            edges.AddRange(result.Edges);
+            for (var i = 0; i < path.Count - 1; i++)
+            {
+                edges.Add(new CallgraphEdge(path[i], path[i + 1], "call"));
+            }
         }
 
         return new CallgraphDocument
         {
-            Id = ObjectId.GenerateNewId().ToString(),
+            Id = caseId,
             Language = "fixture",
             Component = caseId,
-            Version = variant,
-            Nodes = nodes.Values.ToList(),
-            Edges = edges,
+            Version = "truth",
+            Nodes = nodes.Values.OrderBy(n => n.Id, StringComparer.Ordinal).ToList(),
+            Edges = edges
+                .OrderBy(e => e.SourceId, StringComparer.Ordinal)
+                .ThenBy(e => e.TargetId, StringComparer.Ordinal)
+                .ToList(),
             Artifact = new CallgraphArtifactMetadata
             {
-                Path = $"cas://fixtures/{caseId}/{variant}",
+                Path = $"cas://fixtures/{caseId}",
                 Hash = "stub",
                 ContentType = "application/json",
                 Length = 0