diff --git a/docs/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md b/docs-archived/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md similarity index 71% rename from docs/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md rename to docs-archived/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md index 607c04195..f22bf1eae 100644 --- a/docs/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md +++ b/docs-archived/implplan/SPRINT_20260308_007_FE_platform_setup_canonical_route_preservation.md @@ -24,7 +24,7 @@ ## Delivery Tracker ### FE-PLATFORMSETUP-001 - Reproduce and bound the canonical rewrite defect -Status: TODO +Status: DONE Dependency: none Owners: QA, Developer (FE) Task description: @@ -32,12 +32,12 @@ Task description: - Keep the evidence concrete: original URL, landed URL, expected canonical URL preservation, and the route/component boundary responsible. Completion criteria: -- [ ] A bounded list exists for the affected `ops/platform-setup/*` canonical routes. -- [ ] Each affected route includes real Playwright evidence showing the original and landed URLs. -- [ ] The owning route tree and overlapping files are documented before any fix is applied. +- [x] A bounded list exists for the affected `ops/platform-setup/*` canonical routes. +- [x] Each affected route includes real Playwright evidence showing the original and landed URLs. +- [x] The owning route tree and overlapping files are documented before any fix is applied. ### FE-PLATFORMSETUP-002 - Preserve canonical platform-setup URLs in the Web router -Status: TODO +Status: DONE Dependency: FE-PLATFORMSETUP-001 Owners: Developer (FE) Task description: @@ -45,12 +45,12 @@ Task description: - Prefer route aliasing or shared leaf mounting that keeps operator bookmarks stable and does not fork the actual feature behavior. Completion criteria: -- [ ] `ops/platform-setup/*` leaves remain on their requested canonical URLs. -- [ ] The rendered content matches the intended platform-setup/topology surface for each repaired leaf. -- [ ] The fix does not regress the existing `setup/topology/*` routes. +- [x] `ops/platform-setup/*` leaves remain on their requested canonical URLs. +- [x] The rendered content matches the intended platform-setup/topology surface for each repaired leaf. +- [x] The fix does not regress the existing `setup/topology/*` routes. ### FE-PLATFORMSETUP-003 - Add focused regression coverage and retest -Status: TODO +Status: DONE Dependency: FE-PLATFORMSETUP-002 Owners: Test Automation, QA Task description: @@ -58,20 +58,27 @@ Task description: - Re-run the affected slice of `prealpha-canonical-full-sweep.spec.ts` and record the exact passing commands. Completion criteria: -- [ ] Focused Angular route tests cover the preserved canonical aliases. -- [ ] Focused Playwright coverage passes for the repaired `ops/platform-setup/*` routes. -- [ ] The sprint log records the exact retest commands and outcomes. +- [x] Focused Angular route tests cover the preserved canonical aliases. +- [x] Focused Playwright coverage passes for the repaired `ops/platform-setup/*` routes. +- [x] The sprint log records the exact retest commands and outcomes. ## Execution Log | Date (UTC) | Update | Owner | | --- | --- | --- | | 2026-03-08 | Sprint created after the refreshed broad Playwright canonical sweep proved the remaining open defect was no longer search/policy related: `ops/platform-setup/regions-environments` rewrote to `setup/topology/regions`, leaving canonical URL preservation broken during the setup/topology cutover. | Developer | +| 2026-03-08 | Bounded the drift to four canonical platform-setup leaves: `regions-environments`, `promotion-paths`, `workflows-gates`, and `gate-profiles`, all redirected by `platform-setup.routes.ts` and reinforced by stale page-local links. | Developer | +| 2026-03-08 | Replaced redirect-only leaves with mounted canonical pages, repaired platform-setup quick links and internal handoffs, and verified with focused Angular tests, Playwright route preservation flows, and a production build. | Developer | ## Decisions & Risks - Decision: treat this as a dedicated setup/topology canonical-route sprint, not a continuation of the search-adjacent QA loop. - Decision: canonical URLs must stay stable for operator bookmarks and routed entry points even when the rendered feature surface is shared with setup/topology. +- Decision: preserve `/ops/platform-setup/*` only for the leaves that already have mounted platform-setup page components; environment and agent detail drill-ins still use `Setup > Topology`. - Risk: overlapping ownership already exists in active setup/topology files. - Mitigation: keep fixes narrowly focused on route preservation, add targeted route tests, and avoid broad shell/navigation churn. +- Verification: + - `npm run test -- --watch=false --include src/tests/platform/platform-setup-routes.spec.ts --include src/tests/platform/platform-setup-canonical-links.spec.ts --include src/tests/setup/setup-topology-trust-cutover.spec.ts --include src/tests/topology/topology-routes.spec.ts` + - `npx playwright test --config playwright.config.ts tests/e2e/platform-setup-canonical-route-preservation.spec.ts tests/e2e/topology-trust-admin-cutover.spec.ts --workers=1` + - `npm run build` ## Next Checkpoints - 2026-03-08: reproduce the full `ops/platform-setup/*` drift set with Playwright and bound the affected leaves. diff --git a/docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md b/docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md new file mode 100644 index 000000000..605495e36 --- /dev/null +++ b/docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md @@ -0,0 +1,55 @@ +# Platform Setup Canonical Route Preservation UI + +## Module +Web + +## Status +VERIFIED + +## Description +Shipped the `Ops > Platform Setup` follow-up that preserves canonical `/ops/platform-setup/*` URLs for the platform setup leaf pages. The shared setup/topology cutover remains intact, but direct entry and in-product navigation no longer rewrite those canonical ops URLs into `/setup/topology/*`. + +## Implementation Details +- **Feature directories**: + - `src/Web/StellaOps.Web/src/app/features/platform/setup/` + - `src/Web.StellaOps.Web/src/app/routes/` +- **Primary components**: + - `platform-setup-home` (`src/Web.StellaOps.Web/src/app/features/platform/setup/platform-setup-home.component.ts`) + - `platform-setup-regions-environments-page` (`src/Web.StellaOps.Web/src/app/features/platform/setup/platform-setup-regions-environments-page.component.ts`) + - `platform-setup-promotion-paths-page` (`src/Web.StellaOps.Web/src/app/features/platform/setup/platform-setup-promotion-paths-page.component.ts`) + - `platform-setup-workflows-gates-page` (`src/Web.StellaOps.Web/src/app/features/platform/setup/platform-setup-workflows-gates-page.component.ts`) + - `platform-setup-gate-profiles-page` (`src/Web.StellaOps.Web/src/app/features/platform/setup/platform-setup-gate-profiles-page.component.ts`) +- **Preserved canonical routes**: + - `/ops/platform-setup` + - `/ops/platform-setup/regions-environments` + - `/ops/platform-setup/promotion-paths` + - `/ops/platform-setup/workflows-gates` + - `/ops/platform-setup/gate-profiles` +- **Shared setup routes still used for explicit drill-ins**: + - `/setup/topology/environments` + - `/setup/topology/promotion-graph` + - `/setup/topology/workflows` + - `/setup/trust-signing` + +## E2E Test Plan +- **Setup**: + - [x] Start the local Angular test server with `npm run serve:test`. + - [x] Use a test session with setup and ops scopes. +- **Core verification**: + - [x] Open `/ops/platform-setup`, click the `Regions & Environments` quick link, and verify the browser stays on `/ops/platform-setup/regions-environments`. + - [x] Open `/ops/platform-setup/promotion-paths`, `/workflows-gates`, and `/gate-profiles` directly and verify each page keeps its canonical ops URL. + - [x] Re-run the topology/trust cutover browser flow and verify the platform-setup handoff uses the preserved canonical leaf instead of rewriting into setup/topology. + +## Verification +- Run: + - `npm run test -- --watch=false --include src/tests/platform/platform-setup-routes.spec.ts --include src/tests/platform/platform-setup-canonical-links.spec.ts --include src/tests/setup/setup-topology-trust-cutover.spec.ts --include src/tests/topology/topology-routes.spec.ts` + - `npx playwright test --config playwright.config.ts tests/e2e/platform-setup-canonical-route-preservation.spec.ts tests/e2e/topology-trust-admin-cutover.spec.ts --workers=1` + - `npm run build` +- Tier 0 (source): pass +- Tier 1 (build/tests): pass +- Tier 2 (behavior): pass +- Notes: + - Angular targeted tests passed: `4` files, `19` tests. + - Playwright passed: `2` canonical platform-setup scenarios. + - Production build passed; existing bundle-budget warnings remain unchanged from the baseline. +- Verified on (UTC): 2026-03-08T09:07:27Z diff --git a/docs/features/checked/web/topology-trust-administration-ui.md b/docs/features/checked/web/topology-trust-administration-ui.md index 88926977c..21df180fe 100644 --- a/docs/features/checked/web/topology-trust-administration-ui.md +++ b/docs/features/checked/web/topology-trust-administration-ui.md @@ -9,6 +9,8 @@ VERIFIED ## Description Shipped the canonical `Setup > Topology` and `Setup > Trust & Signing` cutover so operators land on mounted setup shells instead of stale `settings`, `administration`, `admin`, or `platform/setup` routes. The topology shell now exposes the preserved setup pages directly, and the trust workspace replaces the live placeholder settings page. +Follow-up note: canonical `Ops > Platform Setup` leaf URLs are preserved by `docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md`; the shared setup cutover no longer rewrites those canonical ops URLs into `setup/topology/*`. + ## Implementation Details - **Feature directories**: - `src/Web/StellaOps.Web/src/app/features/topology/` @@ -49,7 +51,7 @@ Shipped the canonical `Setup > Topology` and `Setup > Trust & Signing` cutover s - [x] Open `/settings/trust` and verify redirect into the canonical trust shell. - [x] Open the `Trusted Issuers` tab and verify issuer data renders. - [x] Open `/admin/trust` and verify bookmark compatibility into the same trust shell. - - [x] Open `/ops/platform-setup`, use the setup quick-link handoff, and verify navigation into canonical topology routes. + - [x] Open `/ops/platform-setup`, use the setup quick-link handoff, and verify the preserved canonical platform-setup leaf renders. ## Verification - Run: diff --git a/docs/modules/ui/README.md b/docs/modules/ui/README.md index 55a846166..e7ec22be2 100644 --- a/docs/modules/ui/README.md +++ b/docs/modules/ui/README.md @@ -9,6 +9,8 @@ The Console presents operator dashboards for scans, policies, VEX evidence, runtime posture, and admin workflows. ## Latest updates (2026-03-08) +- Preserved canonical `Ops > Platform Setup` leaf URLs so `regions-environments`, `promotion-paths`, `workflows-gates`, and `gate-profiles` no longer rewrite into `Setup > Topology` on direct entry or quick-link navigation. +- Added checked-feature verification for canonical platform-setup route preservation at `../../features/checked/web/platform-setup-canonical-route-preservation-ui.md`. - Shipped the `Mission Control`, `Security`, and `Ops > Operations` security-leaves cutover, including canonical surfacing for alerts, activity, unknowns, and notifications plus repaired `/analyze/unknowns*` and `/notify` ownership. - Added checked-feature verification for the security operations leaves cutover at `../../features/checked/web/security-operations-leaves-ui.md`. - Shipped the canonical `Setup > Topology` and `Setup > Trust & Signing` cutover, including repaired legacy trust bookmarks, fixed `Platform Setup` handoffs, and expanded topology shell exposure. @@ -86,6 +88,7 @@ The Console presents operator dashboards for scans, policies, VEX evidence, runt - ./execution-operations/README.md - ./topology-trust-administration/README.md - ./security-operations-leaves/README.md +- ./platform-setup-canonical-route-preservation/README.md - ./triage-explainability-workspace/README.md - ./workflow-visualization-replay/README.md - ./contextual-actions-patterns/README.md diff --git a/docs/modules/ui/TASKS.md b/docs/modules/ui/TASKS.md index 0ab98da80..08954125d 100644 --- a/docs/modules/ui/TASKS.md +++ b/docs/modules/ui/TASKS.md @@ -108,6 +108,9 @@ - [DONE] FE-SOL-002 Surface the leaves from the live shells - [DONE] FE-SOL-003 Repair leaf-local workflow links and actions - [DONE] FE-SOL-004 Verify cutover, sync docs, and archive +- [DONE] FE-PLATFORMSETUP-001 Reproduce and bound the canonical rewrite defect +- [DONE] FE-PLATFORMSETUP-002 Preserve canonical platform-setup URLs in the Web router +- [DONE] FE-PLATFORMSETUP-003 Add focused regression coverage and retest - [DONE] FE-PO-001 Freeze Operations overview taxonomy and submenu structure - [DONE] FE-PO-002 Overview page regrouping and blocking-card contract - [DONE] FE-PO-003 Legacy widget absorption matrix for Platform Ops diff --git a/docs/modules/ui/implementation_plan.md b/docs/modules/ui/implementation_plan.md index 96d9ba102..840de0c63 100644 --- a/docs/modules/ui/implementation_plan.md +++ b/docs/modules/ui/implementation_plan.md @@ -33,6 +33,7 @@ Provide a living plan for UI deliverables, dependencies, and evidence. - `docs/features/checked/web/execution-operations-ui.md` - shipped verification note for canonical execution routes, repaired jobengine and scheduler aliases, completed dead-letter actions, and usable scanner-support workflows. - `docs/features/checked/web/topology-trust-administration-ui.md` - shipped verification note for canonical topology and trust setup shells, repaired settings/admin/platform aliases, and platform-setup handoffs. - `docs/features/checked/web/security-operations-leaves-ui.md` - shipped verification note for mission alerts/activity surfacing, unknowns route repair, notifications ownership, and legacy security alias cutover. +- `docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md` - shipped verification note for preserved `/ops/platform-setup/*` URLs during the shared setup/topology cutover. - `docs/modules/ui/reachability-witnessing/README.md` - detailed witness and proof UX dossier plus cross-shell deep-link contract. - `docs/modules/ui/platform-ops-consolidation/README.md` - detailed Operations overview taxonomy and legacy absorption plan. - `docs/modules/ui/offline-operations/README.md` - detailed owner-shell contract for Offline Kit, Feeds & Airgap, Evidence handoffs, and stale alias policy. @@ -40,6 +41,7 @@ Provide a living plan for UI deliverables, dependencies, and evidence. - `docs/modules/ui/execution-operations/README.md` - canonical execution owner-shell contract for JobEngine, Scheduler, Dead-Letter, and companion Scanner Ops workflows. - `docs/modules/ui/topology-trust-administration/README.md` - canonical setup owner contract for topology inventory, trust administration, legacy trust redirects, and platform-setup handoffs. - `docs/modules/ui/security-operations-leaves/README.md` - canonical owner contract for mission alerts/activity, security unknowns, notifications, and stale `/analyze`/`/notify` handoffs. +- `docs/modules/ui/platform-setup-canonical-route-preservation/README.md` - preserved route contract for canonical `/ops/platform-setup/*` leaves during the shared setup/topology cutover. - `docs/modules/ui/triage-explainability-workspace/README.md` - detailed artifact workspace and audit-bundle UX dossier. - `docs/modules/ui/workflow-visualization-replay/README.md` - detailed run-detail graph, timeline, replay, and evidence UX dossier. - `docs/modules/ui/contextual-actions-patterns/README.md` - shared placement contract for stray actions, pages, drawers, and tabs. diff --git a/docs/modules/ui/platform-setup-canonical-route-preservation/README.md b/docs/modules/ui/platform-setup-canonical-route-preservation/README.md new file mode 100644 index 000000000..526dd4f8a --- /dev/null +++ b/docs/modules/ui/platform-setup-canonical-route-preservation/README.md @@ -0,0 +1,46 @@ +# Platform Setup Canonical Route Preservation + +## Purpose +- Keep `/ops/platform-setup/*` as a stable canonical route family while the shared setup/topology cutover continues. +- Preserve bookmarked operator entry points without forking the actual setup behavior into a second product shell. + +## Canonical Owner +- Owner shell: + - `Ops > Platform Setup` +- Preserved canonical leaf routes: + - `/ops/platform-setup` + - `/ops/platform-setup/regions-environments` + - `/ops/platform-setup/promotion-paths` + - `/ops/platform-setup/workflows-gates` + - `/ops/platform-setup/gate-profiles` + - `/ops/platform-setup/release-templates` + - `/ops/platform-setup/policy-bindings` + - `/ops/platform-setup/defaults-guardrails` +- Shared setup/trust destinations still owned elsewhere: + - `/setup/topology/*` + - `/setup/trust-signing` + +## Route Contract +- `ops/platform-setup/*` must render their intended platform-setup pages without rewriting the browser URL to `setup/topology/*`. +- Explicit drill-ins into the broader topology product may still link to `/setup/topology/*` when the destination has no canonical `ops/platform-setup` equivalent. +- `trust-signing` stays a redirect into `Setup > Trust & Signing`; it is not owned by `Platform Setup`. + +## Preserved Value +- Keep: + - stable operator bookmarks for legacy platform-setup leaves + - the lighter platform-setup summaries for regions, promotion paths, workflows, and gate profiles + - a clear distinction between the `Ops > Platform Setup` handoff shell and the broader `Setup > Topology` workspace +- Why: + - these leaves are still referenced from live setup and ops surfaces + - the defect was URL drift, not missing product value + +## Shipped In This Cut +- Replaced redirect-only platform-setup topology leaves with mounted canonical pages. +- Updated Platform Setup home quick links to stay on `/ops/platform-setup/*`. +- Repaired stale page-local `/platform/setup/*` and `/topology/*` links to either canonical platform-setup leaves or valid setup/topology drill-ins. +- Added focused Angular and Playwright regression coverage for preserved canonical URLs. + +## Related Docs +- `docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md` +- `docs/features/checked/web/topology-trust-administration-ui.md` +- `docs/modules/ui/topology-trust-administration/README.md` diff --git a/docs/modules/ui/topology-trust-administration/README.md b/docs/modules/ui/topology-trust-administration/README.md index 149369507..3158aa189 100644 --- a/docs/modules/ui/topology-trust-administration/README.md +++ b/docs/modules/ui/topology-trust-administration/README.md @@ -75,11 +75,13 @@ - Canonical setup alias helpers for trust and platform-setup handoffs. - Top-level `/admin/*` compatibility redirects for trust and notification bookmarks. - Expanded `Topology` shell tabs so preserved mounted pages are reachable from the live setup shell. -- Fixed `Platform Setup` quick links so they hand off into canonical `Setup` routes. +- Preserved canonical `/ops/platform-setup/*` leaf URLs while keeping explicit topology drill-ins under `Setup > Topology`. - Retired live trust-placeholder ownership in favor of the real `Trust Management` shell. ## Related Docs - `docs/features/checked/web/topology-trust-administration-ui.md` +- `docs/features/checked/web/platform-setup-canonical-route-preservation-ui.md` - `docs/modules/ui/watchlist-operations/README.md` - `docs/modules/ui/platform-ops-consolidation/README.md` +- `docs/modules/ui/platform-setup-canonical-route-preservation/README.md` - `docs/modules/ui/component-preservation-map/RESTORATION_PRIORITIES.md` diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-defaults-guardrails-page.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-defaults-guardrails-page.component.ts index 2f5851b80..9adac9d75 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-defaults-guardrails-page.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-defaults-guardrails-page.component.ts @@ -54,8 +54,8 @@ interface GuardrailRow { diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-gate-profiles-page.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-gate-profiles-page.component.ts index 58ba7d563..78b17a8c1 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-gate-profiles-page.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-gate-profiles-page.component.ts @@ -57,8 +57,8 @@ interface GateProfileRow { diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-home.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-home.component.ts index 3508a6912..bc04402e8 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-home.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-home.component.ts @@ -370,10 +370,10 @@ export class PlatformSetupHomeComponent implements AfterViewInit, OnDestroy { private allLinks: TopoLink[] = []; readonly quickLinks = [ - { title: 'Regions & Environments', description: 'Region-first setup and risk tiers.', route: '/setup/topology/regions' }, - { title: 'Promotion Paths', description: 'Promotion flow graph and rules.', route: '/setup/topology/promotion-graph' }, - { title: 'Workflows & Gates', description: 'Workflow inventory and gate bindings.', route: '/setup/topology/workflows' }, - { title: 'Gate Profiles', description: 'Strict, risk-aware, and expedited lanes.', route: '/setup/topology/gate-profiles' }, + { title: 'Regions & Environments', description: 'Region-first setup and risk tiers.', route: '/ops/platform-setup/regions-environments' }, + { title: 'Promotion Paths', description: 'Promotion flow graph and rules.', route: '/ops/platform-setup/promotion-paths' }, + { title: 'Workflows & Gates', description: 'Workflow inventory and gate bindings.', route: '/ops/platform-setup/workflows-gates' }, + { title: 'Gate Profiles', description: 'Strict, risk-aware, and expedited lanes.', route: '/ops/platform-setup/gate-profiles' }, { title: 'Release Templates', description: 'Release template and evidence defaults.', route: '/ops/platform-setup/release-templates' }, { title: 'Policy Bindings', description: 'Freshness thresholds and feed-policy bindings.', route: '/ops/platform-setup/policy-bindings' }, { title: 'Defaults & Guardrails', description: 'Policy impact labels and degraded-mode.', route: '/ops/platform-setup/defaults-guardrails' }, @@ -795,7 +795,7 @@ export class PlatformSetupHomeComponent implements AfterViewInit, OnDestroy { case 'tenant': break; // Already on this page case 'region': - void this.router.navigate(['/setup/topology/regions']); + void this.router.navigate(['/ops/platform-setup/regions-environments']); break; case 'environment': if (node.environmentId) { diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-promotion-paths-page.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-promotion-paths-page.component.ts index fb83f937b..1ad679ee4 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-promotion-paths-page.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-promotion-paths-page.component.ts @@ -54,7 +54,7 @@ interface PromotionRule { `, diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-regions-environments-page.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-regions-environments-page.component.ts index 484c92480..ce2aa7b8c 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-regions-environments-page.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-regions-environments-page.component.ts @@ -79,7 +79,7 @@ interface RegionRow { diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-workflows-gates-page.component.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-workflows-gates-page.component.ts index 4e8e785d3..cfa660a7a 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-workflows-gates-page.component.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup-workflows-gates-page.component.ts @@ -57,7 +57,7 @@ interface WorkflowRow { `, diff --git a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup.routes.ts b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup.routes.ts index fa185cdc1..754c5b8bd 100644 --- a/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup.routes.ts +++ b/src/Web/StellaOps.Web/src/app/features/platform/setup/platform-setup.routes.ts @@ -12,22 +12,28 @@ export const PLATFORM_SETUP_ROUTES: Routes = [ path: 'regions-environments', title: 'Setup Regions & Environments', data: { breadcrumb: 'Regions & Environments' }, - redirectTo: '/setup/topology/regions', - pathMatch: 'full', + loadComponent: () => + import('./platform-setup-regions-environments-page.component').then( + (m) => m.PlatformSetupRegionsEnvironmentsPageComponent, + ), }, { path: 'promotion-paths', title: 'Setup Promotion Paths', data: { breadcrumb: 'Promotion Paths' }, - redirectTo: '/setup/topology/promotion-graph', - pathMatch: 'full', + loadComponent: () => + import('./platform-setup-promotion-paths-page.component').then( + (m) => m.PlatformSetupPromotionPathsPageComponent, + ), }, { path: 'workflows-gates', title: 'Setup Workflows & Gates', data: { breadcrumb: 'Workflows & Gates' }, - redirectTo: '/setup/topology/workflows', - pathMatch: 'full', + loadComponent: () => + import('./platform-setup-workflows-gates-page.component').then( + (m) => m.PlatformSetupWorkflowsGatesPageComponent, + ), }, { path: 'release-templates', @@ -51,8 +57,10 @@ export const PLATFORM_SETUP_ROUTES: Routes = [ path: 'gate-profiles', title: 'Gate Profiles', data: { breadcrumb: 'Gate Profiles' }, - redirectTo: '/setup/topology/gate-profiles', - pathMatch: 'full', + loadComponent: () => + import('./platform-setup-gate-profiles-page.component').then( + (m) => m.PlatformSetupGateProfilesPageComponent, + ), }, { path: 'defaults-guardrails', diff --git a/src/Web/StellaOps.Web/src/tests/platform/platform-setup-canonical-links.spec.ts b/src/Web/StellaOps.Web/src/tests/platform/platform-setup-canonical-links.spec.ts new file mode 100644 index 000000000..e79a7008a --- /dev/null +++ b/src/Web/StellaOps.Web/src/tests/platform/platform-setup-canonical-links.spec.ts @@ -0,0 +1,102 @@ +import { signal, Type } from '@angular/core'; +import { ComponentFixture, TestBed } from '@angular/core/testing'; +import { provideRouter, Router } from '@angular/router'; +import { of } from 'rxjs'; + +import { ConsoleSessionStore } from '../../app/core/console/console-session.store'; +import { PlatformContextStore } from '../../app/core/context/platform-context.store'; +import { PlatformSetupDefaultsGuardrailsPageComponent } from '../../app/features/platform/setup/platform-setup-defaults-guardrails-page.component'; +import { PlatformSetupGateProfilesPageComponent } from '../../app/features/platform/setup/platform-setup-gate-profiles-page.component'; +import { PlatformSetupHomeComponent } from '../../app/features/platform/setup/platform-setup-home.component'; +import { PlatformSetupPromotionPathsPageComponent } from '../../app/features/platform/setup/platform-setup-promotion-paths-page.component'; +import { PlatformSetupRegionsEnvironmentsPageComponent } from '../../app/features/platform/setup/platform-setup-regions-environments-page.component'; +import { PlatformSetupWorkflowsGatesPageComponent } from '../../app/features/platform/setup/platform-setup-workflows-gates-page.component'; +import { TopologyDataService } from '../../app/features/topology/topology-data.service'; + +describe('platform setup canonical links', () => { + it('keeps home quick links on canonical ops/platform-setup leaves', async () => { + const topologyApi = { + list: jasmine.createSpy('list').and.returnValue(of([])), + }; + + await TestBed.configureTestingModule({ + imports: [PlatformSetupHomeComponent], + providers: [ + provideRouter([]), + { + provide: PlatformContextStore, + useValue: { + initialize: jasmine.createSpy('initialize'), + contextVersion: signal(0), + }, + }, + { + provide: ConsoleSessionStore, + useValue: { + currentTenant: () => ({ id: 'tenant-default', displayName: 'Default Tenant' }), + }, + }, + { provide: TopologyDataService, useValue: topologyApi }, + ], + }).compileComponents(); + + const fixture = TestBed.createComponent(PlatformSetupHomeComponent); + const component = fixture.componentInstance; + const router = TestBed.inject(Router); + spyOn(router, 'navigate').and.returnValue(Promise.resolve(true)); + + expect(component.quickLinks.slice(0, 4).map((link) => link.route)).toEqual([ + '/ops/platform-setup/regions-environments', + '/ops/platform-setup/promotion-paths', + '/ops/platform-setup/workflows-gates', + '/ops/platform-setup/gate-profiles', + ]); + + (component as unknown as { navigateToNode(node: { kind: string; id: string }): void }).navigateToNode({ + kind: 'region', + id: 'region:eu-west', + }); + + expect(router.navigate).toHaveBeenCalledWith(['/ops/platform-setup/regions-environments']); + }); + + it('keeps page-local platform setup links inside the canonical ops subtree', async () => { + const gateProfilesFixture = await createFixture(PlatformSetupGateProfilesPageComponent); + const defaultsFixture = await createFixture(PlatformSetupDefaultsGuardrailsPageComponent); + + expect(extractHrefs(gateProfilesFixture)).toContain('/ops/platform-setup/workflows-gates'); + expect(extractHrefs(gateProfilesFixture)).toContain('/ops/platform-setup/defaults-guardrails'); + expect(extractHrefs(defaultsFixture)).toContain('/ops/platform-setup/gate-profiles'); + expect(extractHrefs(defaultsFixture)).toContain('/ops/platform-setup/policy-bindings'); + }); + + it('uses valid mounted topology routes for explicit topology drill-ins', async () => { + const regionsFixture = await createFixture(PlatformSetupRegionsEnvironmentsPageComponent); + const promotionFixture = await createFixture(PlatformSetupPromotionPathsPageComponent); + const workflowsFixture = await createFixture(PlatformSetupWorkflowsGatesPageComponent); + + expect(extractHrefs(regionsFixture)).toContain('/setup/topology/environments'); + expect(extractHrefs(promotionFixture)).toContain('/setup/topology/promotion-graph'); + expect(extractHrefs(workflowsFixture)).toContain('/setup/topology/workflows'); + }); +}); + +async function createFixture(component: Type): Promise> { + TestBed.resetTestingModule(); + await TestBed.configureTestingModule({ + imports: [component], + providers: [provideRouter([])], + }).compileComponents(); + + const fixture = TestBed.createComponent(component); + fixture.detectChanges(); + await fixture.whenStable(); + fixture.detectChanges(); + return fixture; +} + +function extractHrefs(fixture: ComponentFixture): string[] { + return Array.from(fixture.nativeElement.querySelectorAll('a') as NodeListOf) + .map((link) => link.getAttribute('href')) + .filter((href): href is string => typeof href === 'string'); +} diff --git a/src/Web/StellaOps.Web/src/tests/platform/platform-setup-routes.spec.ts b/src/Web/StellaOps.Web/src/tests/platform/platform-setup-routes.spec.ts index 68bd1f5c0..dd2cd2c51 100644 --- a/src/Web/StellaOps.Web/src/tests/platform/platform-setup-routes.spec.ts +++ b/src/Web/StellaOps.Web/src/tests/platform/platform-setup-routes.spec.ts @@ -15,22 +15,34 @@ describe('PLATFORM_SETUP_ROUTES (pre-alpha)', () => { expect(defaults?.loadComponent).toBeDefined(); }); - it('redirects absorbed topology and trust pages into canonical setup owners', () => { + it('keeps canonical platform-setup topology leaves mounted under ops/platform-setup', () => { const regions = PLATFORM_SETUP_ROUTES.find((item) => item.path === 'regions-environments'); const promotion = PLATFORM_SETUP_ROUTES.find((item) => item.path === 'promotion-paths'); const workflows = PLATFORM_SETUP_ROUTES.find((item) => item.path === 'workflows-gates'); const gateProfiles = PLATFORM_SETUP_ROUTES.find((item) => item.path === 'gate-profiles'); + + expect(regions?.loadComponent).toBeDefined(); + expect(promotion?.loadComponent).toBeDefined(); + expect(workflows?.loadComponent).toBeDefined(); + expect(gateProfiles?.loadComponent).toBeDefined(); + }); + + it('keeps trust signing as a redirect into the canonical setup trust owner', () => { const trustSigning = PLATFORM_SETUP_ROUTES.find((item) => item.path === 'trust-signing'); - expect(regions?.redirectTo).toBe('/setup/topology/regions'); - expect(promotion?.redirectTo).toBe('/setup/topology/promotion-graph'); - expect(workflows?.redirectTo).toBe('/setup/topology/workflows'); - expect(gateProfiles?.redirectTo).toBe('/setup/topology/gate-profiles'); expect(trustSigning?.redirectTo).toBe('/setup/trust-signing'); }); it('retains mounted routes for the remaining platform setup surfaces', () => { - const mountedPaths = ['policy-bindings', 'release-templates', 'defaults-guardrails']; + const mountedPaths = [ + 'regions-environments', + 'promotion-paths', + 'workflows-gates', + 'gate-profiles', + 'policy-bindings', + 'release-templates', + 'defaults-guardrails', + ]; for (const path of mountedPaths) { const route = PLATFORM_SETUP_ROUTES.find((item) => item.path === path); diff --git a/src/Web/StellaOps.Web/tests/e2e/platform-setup-canonical-route-preservation.spec.ts b/src/Web/StellaOps.Web/tests/e2e/platform-setup-canonical-route-preservation.spec.ts new file mode 100644 index 000000000..ae36330a3 --- /dev/null +++ b/src/Web/StellaOps.Web/tests/e2e/platform-setup-canonical-route-preservation.spec.ts @@ -0,0 +1,195 @@ +import { expect, test, type Page, type Route } from '@playwright/test'; + +import type { StubAuthSession } from '../../src/app/testing/auth-fixtures'; + +const operatorSession: StubAuthSession = { + subjectId: 'platform-setup-e2e-user', + tenant: 'tenant-default', + scopes: ['admin', 'ui.read', 'ui.admin', 'orch:read', 'orch:operate', 'release:read'], +}; + +const mockConfig = { + authority: { + issuer: '/authority', + clientId: 'stella-ops-ui', + authorizeEndpoint: '/authority/connect/authorize', + tokenEndpoint: '/authority/connect/token', + logoutEndpoint: '/authority/connect/logout', + redirectUri: 'https://127.0.0.1:4400/auth/callback', + postLogoutRedirectUri: 'https://127.0.0.1:4400/', + scope: 'openid profile email ui.read', + audience: '/gateway', + dpopAlgorithms: ['ES256'], + refreshLeewaySeconds: 60, + }, + apiBaseUrls: { + authority: '/authority', + scanner: '/scanner', + policy: '/policy', + concelier: '/concelier', + attestor: '/attestor', + gateway: '/gateway', + }, + quickstartMode: true, + setup: 'complete', +}; + +const topologyRegions = [{ regionId: 'eu-west', displayName: 'EU West', environmentCount: 1, targetCount: 2 }]; +const topologyEnvironments = [ + { + environmentId: 'prod', + regionId: 'eu-west', + environmentType: 'prod', + displayName: 'Production', + targetCount: 2, + }, +]; +const topologyAgents = [ + { + agentId: 'agent-001', + agentName: 'Agent One', + regionId: 'eu-west', + environmentId: 'prod', + status: 'active', + assignedTargetCount: 2, + }, +]; +const promotionPaths = [ + { + pathId: 'path-001', + regionId: 'eu-west', + sourceEnvironmentId: 'stage', + targetEnvironmentId: 'prod', + status: 'running', + requiredApprovals: 1, + }, +]; + +async function fulfillJson(route: Route, body: unknown, status = 200): Promise { + await route.fulfill({ + status, + contentType: 'application/json', + body: JSON.stringify(body), + }); +} + +async function setupHarness(page: Page): Promise { + await page.addInitScript((session) => { + (window as { __stellaopsTestSession?: unknown }).__stellaopsTestSession = session; + }, operatorSession); + + await page.route('**/api/**', (route) => fulfillJson(route, {})); + await page.route('**/platform/envsettings.json', (route) => fulfillJson(route, mockConfig)); + await page.route('**/platform/i18n/*.json', (route) => fulfillJson(route, {})); + await page.route('**/config.json', (route) => fulfillJson(route, mockConfig)); + await page.route('**/.well-known/openid-configuration', (route) => + fulfillJson(route, { + issuer: 'https://127.0.0.1:4400/authority', + authorization_endpoint: 'https://127.0.0.1:4400/authority/connect/authorize', + token_endpoint: 'https://127.0.0.1:4400/authority/connect/token', + jwks_uri: 'https://127.0.0.1:4400/authority/.well-known/jwks.json', + response_types_supported: ['code'], + subject_types_supported: ['public'], + id_token_signing_alg_values_supported: ['RS256'], + }), + ); + await page.route('**/authority/.well-known/jwks.json', (route) => fulfillJson(route, { keys: [] })); + await page.route('**/console/branding**', (route) => + fulfillJson(route, { + tenantId: operatorSession.tenant, + appName: 'Stella Ops', + logoUrl: null, + cssVariables: {}, + }), + ); + await page.route('**/console/profile**', (route) => + fulfillJson(route, { + subjectId: operatorSession.subjectId, + username: 'platform-setup-e2e', + displayName: 'Platform Setup E2E', + tenant: operatorSession.tenant, + roles: ['platform-admin'], + scopes: operatorSession.scopes, + }), + ); + await page.route('**/console/token/introspect**', (route) => + fulfillJson(route, { + active: true, + tenant: operatorSession.tenant, + subject: operatorSession.subjectId, + scopes: operatorSession.scopes, + }), + ); + await page.route('**/authority/console/tenants**', (route) => + fulfillJson(route, { + tenants: [ + { + tenantId: operatorSession.tenant, + displayName: 'Default Tenant', + isDefault: true, + isActive: true, + }, + ], + }), + ); + await page.route('**/api/v2/context/regions**', (route) => + fulfillJson(route, [{ regionId: 'eu-west', displayName: 'EU West', sortOrder: 1, enabled: true }]), + ); + await page.route('**/api/v2/context/environments**', (route) => + fulfillJson(route, [ + { + environmentId: 'prod', + regionId: 'eu-west', + environmentType: 'prod', + displayName: 'Production', + sortOrder: 1, + enabled: true, + }, + ]), + ); + await page.route('**/api/v2/context/preferences**', (route) => + fulfillJson(route, { + tenantId: operatorSession.tenant, + actorId: operatorSession.subjectId, + regions: ['eu-west'], + environments: ['prod'], + timeWindow: '24h', + stage: 'all', + updatedAt: '2026-03-08T07:00:00Z', + updatedBy: operatorSession.subjectId, + }), + ); + + await page.route(/\/api\/v2\/topology\/regions(?:\?.*)?$/, (route) => fulfillJson(route, topologyRegions)); + await page.route(/\/api\/v2\/topology\/environments(?:\?.*)?$/, (route) => + fulfillJson(route, topologyEnvironments), + ); + await page.route(/\/api\/v2\/topology\/agents(?:\?.*)?$/, (route) => fulfillJson(route, topologyAgents)); + await page.route(/\/api\/v2\/topology\/promotion-paths(?:\?.*)?$/, (route) => + fulfillJson(route, promotionPaths), + ); +} + +test.beforeEach(async ({ page }) => { + await setupHarness(page); +}); + +test('platform setup canonical leaves preserve ops urls during setup topology cutover', async ({ page }) => { + await page.goto('/ops/platform-setup', { waitUntil: 'networkidle' }); + const regionsCard = page.locator('.setup-home__card').filter({ hasText: 'Regions & Environments' }); + await regionsCard.getByRole('link', { name: 'Open' }).click(); + await expect(page).toHaveURL(/\/ops\/platform-setup\/regions-environments(?:\?.*)?$/); + await expect(page.getByRole('heading', { name: 'Regions & Environments' })).toBeVisible(); + + await page.goto('/ops/platform-setup/promotion-paths', { waitUntil: 'networkidle' }); + await expect(page).toHaveURL(/\/ops\/platform-setup\/promotion-paths(?:\?.*)?$/); + await expect(page.getByRole('heading', { name: 'Promotion Paths' })).toBeVisible(); + + await page.goto('/ops/platform-setup/workflows-gates', { waitUntil: 'networkidle' }); + await expect(page).toHaveURL(/\/ops\/platform-setup\/workflows-gates(?:\?.*)?$/); + await expect(page.getByRole('heading', { name: 'Workflows & Gates' })).toBeVisible(); + + await page.goto('/ops/platform-setup/gate-profiles', { waitUntil: 'networkidle' }); + await expect(page).toHaveURL(/\/ops\/platform-setup\/gate-profiles(?:\?.*)?$/); + await expect(page.getByRole('heading', { name: 'Gate Profiles' })).toBeVisible(); +}); diff --git a/src/Web/StellaOps.Web/tests/e2e/topology-trust-admin-cutover.spec.ts b/src/Web/StellaOps.Web/tests/e2e/topology-trust-admin-cutover.spec.ts index 71657e111..051996edc 100644 --- a/src/Web/StellaOps.Web/tests/e2e/topology-trust-admin-cutover.spec.ts +++ b/src/Web/StellaOps.Web/tests/e2e/topology-trust-admin-cutover.spec.ts @@ -281,7 +281,6 @@ test('topology and trust cutover keeps setup handoffs and legacy trust entry poi await page.goto('/ops/platform-setup', { waitUntil: 'networkidle' }); const regionsCard = page.locator('.setup-home__card').filter({ hasText: 'Regions & Environments' }); await regionsCard.getByRole('link', { name: 'Open' }).click(); - await expect(page).toHaveURL(/\/setup\/topology\/regions(?:\?.*)?$/); - await expect(page.getByRole('heading', { name: 'Topology' })).toBeVisible(); + await expect(page).toHaveURL(/\/ops\/platform-setup\/regions-environments(?:\?.*)?$/); await expect(page.getByRole('heading', { name: 'Regions & Environments' })).toBeVisible(); });