audit work, fixed StellaOps.sln warnings/errors, fixed tests, sprints work, new advisories

src/Attestor/StellaOps.Attestor.Verify/AttestorVerificationEngine.cs

@@ -1,5 +1,6 @@
 using System.Collections.Immutable;
 using System.Formats.Asn1;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Net;
@@ -626,7 +627,7 @@ public sealed class AttestorVerificationEngine : IAttestorVerificationEngine
 
         if (entry.Proof?.Checkpoint?.Timestamp is not null)
         {
-            attributes = attributes.Add("checkpointTs", entry.Proof.Checkpoint.Timestamp.Value.ToString("O"));
+            attributes = attributes.Add("checkpointTs", entry.Proof.Checkpoint.Timestamp.Value.ToString("O", CultureInfo.InvariantCulture));
         }
 
         return new PolicyEvaluationResult

src/Attestor/StellaOps.Attestor.Verify/Providers/DistributedVerificationProvider.cs

@@ -26,25 +26,28 @@ public class DistributedVerificationProvider : IVerificationProvider
     private readonly ILogger<DistributedVerificationProvider> _logger;
     private readonly DistributedVerificationOptions _options;
     private readonly HttpClient _httpClient;
+    private readonly TimeProvider _timeProvider;
     private readonly ConcurrentDictionary<string, CircuitBreakerState> _circuitStates = new();
     private readonly ConsistentHashRing _hashRing;
 
     public DistributedVerificationProvider(
         ILogger<DistributedVerificationProvider> logger,
         IOptions<DistributedVerificationOptions> options,
-        HttpClient httpClient)
+        HttpClient httpClient,
+        TimeProvider? timeProvider = null)
     {
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
         _options = options?.Value ?? throw new ArgumentNullException(nameof(options));
         _httpClient = httpClient ?? throw new ArgumentNullException(nameof(httpClient));
-        
+        _timeProvider = timeProvider ?? TimeProvider.System;
+
         if (_options.Nodes == null || _options.Nodes.Count == 0)
         {
             throw new ArgumentException("At least one verification node must be configured");
         }
 
         _hashRing = new ConsistentHashRing(_options.Nodes, _options.VirtualNodeMultiplier);
-        
+
         _logger.LogInformation("Initialized distributed verification provider with {NodeCount} nodes", _options.Nodes.Count);
     }
 
@@ -106,7 +109,7 @@ public class DistributedVerificationProvider : IVerificationProvider
             RequestId = request.RequestId,
             Status = VerificationStatus.Error,
             ErrorMessage = $"All verification nodes failed. {exceptions.Count} errors occurred.",
-            Timestamp = DateTimeOffset.UtcNow,
+            Timestamp = _timeProvider.GetUtcNow(),
         };
     }
 
@@ -144,7 +147,7 @@ public class DistributedVerificationProvider : IVerificationProvider
             HealthyNodeCount = healthyCount,
             TotalNodeCount = totalCount,
             NodeStatuses = results.ToDictionary(r => r.Key, r => r.Value),
-            Timestamp = DateTimeOffset.UtcNow,
+            Timestamp = _timeProvider.GetUtcNow(),
         };
     }
 
@@ -237,8 +240,8 @@ public class DistributedVerificationProvider : IVerificationProvider
         }
 
         // Allow recovery after cooldown period
-        if (state.LastFailure.HasValue && 
-            DateTimeOffset.UtcNow - state.LastFailure.Value > _options.CircuitBreakerCooldown)
+        if (state.LastFailure.HasValue &&
+            _timeProvider.GetUtcNow() - state.LastFailure.Value > _options.CircuitBreakerCooldown)
         {
             state.FailureCount = 0;
             state.LastFailure = null;
@@ -252,7 +255,7 @@ public class DistributedVerificationProvider : IVerificationProvider
     {
         var state = _circuitStates.GetOrAdd(node.Id, _ => new CircuitBreakerState());
         state.FailureCount++;
-        state.LastFailure = DateTimeOffset.UtcNow;
+        state.LastFailure = _timeProvider.GetUtcNow();
 
         if (state.FailureCount >= _options.CircuitBreakerThreshold)
         {