audit work, fixed StellaOps.sln warnings/errors, fixed tests, sprints work, new advisories

src/AdvisoryAI/StellaOps.AdvisoryAI/PolicyStudio/AiPolicyIntentParser.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Security.Cryptography;
 using System.Text;
 using System.Text.Json;
@@ -14,6 +15,7 @@ public sealed class AiPolicyIntentParser : IPolicyIntentParser
     private readonly IPolicyPromptService _promptService;
     private readonly IPolicyInferenceClient _inferenceClient;
     private readonly IPolicyIntentStore _intentStore;
+    private readonly TimeProvider _timeProvider;
 
     private static readonly string[] FewShotExamples = new[]
     {
@@ -27,11 +29,13 @@ public sealed class AiPolicyIntentParser : IPolicyIntentParser
     public AiPolicyIntentParser(
         IPolicyPromptService promptService,
         IPolicyInferenceClient inferenceClient,
-        IPolicyIntentStore intentStore)
+        IPolicyIntentStore intentStore,
+        TimeProvider? timeProvider = null)
     {
         _promptService = promptService;
         _inferenceClient = inferenceClient;
         _intentStore = intentStore;
+        _timeProvider = timeProvider ?? TimeProvider.System;
     }
 
     public async Task<PolicyParseResult> ParseAsync(
@@ -61,7 +65,7 @@ public sealed class AiPolicyIntentParser : IPolicyIntentParser
             Success = intent.Confidence >= 0.7,
             ErrorMessage = intent.Confidence < 0.7 ? "Ambiguous input - clarification needed" : null,
             ModelId = inferenceResult.ModelId,
-            ParsedAt = DateTime.UtcNow.ToString("O")
+            ParsedAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
         };
     }
 
@@ -93,7 +97,7 @@ public sealed class AiPolicyIntentParser : IPolicyIntentParser
             Intent = clarifiedIntent,
             Success = clarifiedIntent.Confidence >= 0.8,
             ModelId = inferenceResult.ModelId,
-            ParsedAt = DateTime.UtcNow.ToString("O")
+            ParsedAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
         };
     }
 

src/AdvisoryAI/StellaOps.AdvisoryAI/PolicyStudio/LatticeRuleGenerator.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Security.Cryptography;
 using System.Text;
 
@@ -10,6 +11,13 @@ namespace StellaOps.AdvisoryAI.PolicyStudio;
 /// </summary>
 public sealed class LatticeRuleGenerator : IPolicyRuleGenerator
 {
+    private readonly TimeProvider _timeProvider;
+
+    public LatticeRuleGenerator(TimeProvider? timeProvider = null)
+    {
+        _timeProvider = timeProvider ?? TimeProvider.System;
+    }
+
     public Task<RuleGenerationResult> GenerateAsync(
         PolicyIntent intent,
         CancellationToken cancellationToken = default)
@@ -58,7 +66,7 @@ public sealed class LatticeRuleGenerator : IPolicyRuleGenerator
             Success = true,
             Warnings = warnings,
             IntentId = intent.IntentId,
-            GeneratedAt = DateTime.UtcNow.ToString("O")
+            GeneratedAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
         });
     }
 

src/AdvisoryAI/StellaOps.AdvisoryAI/PolicyStudio/PolicyBundleCompiler.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Security.Cryptography;
 using System.Text;
 using System.Text.Json;
@@ -391,7 +392,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
                 Warnings = warnings,
                 ValidationReport = validationReport,
                 TestReport = testReport,
-                CompiledAt = _timeProvider.GetUtcNow().ToString("O")
+                CompiledAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
             };
         }
 
@@ -412,7 +413,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
             Warnings = warnings,
             ValidationReport = validationReport,
             TestReport = testReport,
-            CompiledAt = DateTime.UtcNow.ToString("O"),
+            CompiledAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture),
             BundleDigest = bundleDigest
         };
     }
@@ -492,7 +493,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
                 ContentDigest = contentDigest,
                 Signature = string.Empty,
                 Algorithm = "none",
-                SignedAt = _timeProvider.GetUtcNow().ToString("O")
+                SignedAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
             };
         }
 
@@ -509,7 +510,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
             Algorithm = signature.Algorithm,
             KeyId = options.KeyId,
             SignerIdentity = options.SignerIdentity,
-            SignedAt = _timeProvider.GetUtcNow().ToString("O"),
+            SignedAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture),
             CertificateChain = signature.CertificateChain
         };
     }

src/AdvisoryAI/StellaOps.AdvisoryAI/PolicyStudio/PropertyBasedTestSynthesizer.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Security.Cryptography;
 using System.Text;
 
@@ -10,6 +11,13 @@ namespace StellaOps.AdvisoryAI.PolicyStudio;
 /// </summary>
 public sealed class PropertyBasedTestSynthesizer : ITestCaseSynthesizer
 {
+    private readonly TimeProvider _timeProvider;
+
+    public PropertyBasedTestSynthesizer(TimeProvider? timeProvider = null)
+    {
+        _timeProvider = timeProvider ?? TimeProvider.System;
+    }
+
     public Task<IReadOnlyList<PolicyTestCase>> SynthesizeAsync(
         IReadOnlyList<LatticeRule> rules,
         CancellationToken cancellationToken = default)
@@ -53,7 +61,7 @@ public sealed class PropertyBasedTestSynthesizer : ITestCaseSynthesizer
             Passed = results.Count(r => r.Passed),
             Failed = results.Count(r => !r.Passed),
             Results = results,
-            RunAt = DateTime.UtcNow.ToString("O")
+            RunAt = _timeProvider.GetUtcNow().ToString("O", CultureInfo.InvariantCulture)
         });
     }