save checkpoint. addition features and their state. check some ofthem
This commit is contained in:
master
@@ -0,0 +1,20 @@
|
||||
{
|
||||
"feature": "graph-analytics-engine",
|
||||
"module": "graph",
|
||||
"confirmedAtUtc": "2026-02-09T18:00:00Z",
|
||||
"sharedConfirmationRef": "graph-edge-metadata-with-reason-evidence-provenance/run-001/confirmation.json",
|
||||
"confirmations": [
|
||||
{
|
||||
"issueId": "issue-1",
|
||||
"approved": true,
|
||||
"reason": "Confirmed via dotnet build. Program.cs line 460: .ToList() on EdgeMetadataResponse (sealed record, not IEnumerable). CS1061 build error verified. See shared confirmation for full details."
|
||||
},
|
||||
{
|
||||
"issueId": "issue-2",
|
||||
"approved": true,
|
||||
"reason": "Confirmed via dotnet build. Directory.Build.props auto-injects Concelier.Testing into all .Tests projects. Concelier.Core has 16 compile errors, Attestor.ProofChain has 4. See shared confirmation for full details."
|
||||
}
|
||||
],
|
||||
"overallApproved": true,
|
||||
"overallNotes": "Both shared root causes confirmed. This feature is blocked by the same two issues as all 7 Graph features."
|
||||
}
|
||||
@@ -0,0 +1,28 @@
|
||||
{
|
||||
"feature": "graph-module-shared",
|
||||
"module": "graph",
|
||||
"filesModified": [
|
||||
"src/Graph/StellaOps.Graph.Api/Program.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/StellaOps.Graph.Api.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/StellaOps.Graph.Indexer.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Core.Tests/StellaOps.Graph.Core.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Persistence.Tests/StellaOps.Graph.Indexer.Persistence.Tests.csproj"
|
||||
],
|
||||
"testsAdded": [],
|
||||
"description": "Fixed Graph.Api CS1061 bug (Program.cs:460 .ToList() -> Results.Ok(edges)). Opted 4 Graph test projects out of Concelier test infra via UseConcelierTestInfra=false. Added Microsoft.Extensions.TimeProvider.Testing to Graph.Api.Tests for FakeTimeProvider after opt-out.",
|
||||
"buildVerified": "partial",
|
||||
"buildResults": {
|
||||
"Graph.Api": "pass (CS1061 fixed)",
|
||||
"Graph.Indexer.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Core.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Indexer.Persistence.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Api.Tests": "fail (EdgeMetadataServiceTests.cs has matching .ToList() bug + missing timeProvider constructor arg)"
|
||||
},
|
||||
"testResults": {
|
||||
"Graph.Indexer.Tests": "pass (37/37)",
|
||||
"Graph.Core.Tests": "pass (19/19)",
|
||||
"Graph.Api.Tests": "fail (compile error - cannot run)",
|
||||
"Graph.Indexer.Persistence.Tests": "fail (17/17 runtime failures - likely need Postgres)"
|
||||
},
|
||||
"notes": "Partial success. Issue 1 (CS1061) fixed. Issue 2 (opt-out) partially fixed -- 3/4 test projects now build and pass. Graph.Api.Tests has residual compile errors in EdgeMetadataServiceTests.cs (same .ToList() pattern as the production code bug, plus missing constructor arg). Graph.Indexer.Persistence.Tests all fail at runtime (likely require PostgreSQL). Fixer stopped because EdgeMetadataServiceTests.cs was not in the confirmed triage file list."
|
||||
}
|
||||
@@ -0,0 +1,23 @@
|
||||
{
|
||||
"previousFailures": [
|
||||
{ "tier": 1, "reason": "Build error CS1061: 'EdgeMetadataResponse' does not contain a definition for 'ToList' at Program.cs(460,70) in StellaOps.Graph.Api" },
|
||||
{ "tier": 1, "reason": "All test projects failed to build due to transitive dependency on StellaOps.Concelier.Testing pulling in broken Concelier.Core and Attestor.ProofChain modules" }
|
||||
],
|
||||
"retestResults": [
|
||||
{ "tier": 1, "check": "build", "result": "pass", "evidence": "All 4 source projects and all 4 test projects build successfully with 0 errors after CS1061 fix and UseConcelierTestInfra=false opt-out" },
|
||||
{ "tier": 1, "check": "tests-indexer-overlay", "result": "pass", "evidence": "Graph.Indexer.Tests: 37 passed, 0 failed, 0 skipped. Overlay exporter tests pass." },
|
||||
{ "tier": 1, "check": "tests-core-overlay", "result": "pass", "evidence": "Graph.Core.Tests: 19 passed, 0 failed, 0 skipped. Core overlay types pass." },
|
||||
{ "tier": 1, "check": "tests-api-metrics", "result": "fail", "evidence": "Graph.Api.Tests MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails with Assert.Equal() Expected: 1, Actual: 3 at line 103. This tests overlay cache metrics counters." }
|
||||
],
|
||||
"regressionCheck": {
|
||||
"testsRun": 108,
|
||||
"testsPassed": 103,
|
||||
"testsFailed": 6,
|
||||
"newTestsRun": 0,
|
||||
"newTestsPassed": 0,
|
||||
"notes": "1 overlay-related MetricsTests failure (OverlayCacheCounters_RecordHitsAndMisses). 5 EdgeMetadataServiceTests failures are in a different feature area. Graph.Indexer.Tests (37/37) and Graph.Core.Tests (19/19) all pass — these are the primary overlay system test coverage."
|
||||
},
|
||||
"verdict": "fail",
|
||||
"failureDetails": "MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails (Assert.Equal Expected: 1, Actual: 3). This test directly validates overlay cache counter instrumentation which is part of the overlay system feature. While the core overlay system tests pass (Graph.Indexer.Tests overlay exporter + Graph.Core.Tests), the cache metrics test indicates a counting bug in overlay cache instrumentation.",
|
||||
"notes": "Previous failures (CS1061 build error + Concelier transitive dependency) are fully resolved. Overlay exporter (Indexer) and overlay types (Core) tests all pass. However, MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails — this tests overlay cache metrics counters and is directly relevant to this feature. Needs investigation: counter is recording 3 instead of expected 1."
|
||||
}
|
||||
@@ -0,0 +1,34 @@
|
||||
{
|
||||
"filesChecked": [
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Analytics/GraphOverlayExporter.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayProcessor.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/IPolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IReachabilityDeltaService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryReachabilityDeltaService.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/GraphOverlayExporterTests.cs"
|
||||
],
|
||||
"found": [
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Analytics/GraphOverlayExporter.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayProcessor.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/IPolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IReachabilityDeltaService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryReachabilityDeltaService.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/GraphOverlayExporterTests.cs"
|
||||
],
|
||||
"missing": [],
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,24 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"tier": 1,
|
||||
"buildResults": [
|
||||
{ "project": "src/Graph/__Libraries/StellaOps.Graph.Core/StellaOps.Graph.Core.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/__Libraries/StellaOps.Graph.Indexer.Persistence/StellaOps.Graph.Indexer.Persistence.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/StellaOps.Graph.Indexer/StellaOps.Graph.Indexer.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/StellaOps.Graph.Api/StellaOps.Graph.Api.csproj", "result": "fail", "errors": ["CS1061: 'EdgeMetadataResponse' does not contain a definition for 'ToList' at Program.cs(460,70)"] }
|
||||
],
|
||||
"testResults": [
|
||||
{
|
||||
"project": "src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/StellaOps.Graph.Indexer.Tests.csproj",
|
||||
"filter": "FullyQualifiedName~Overlay",
|
||||
"result": "fail",
|
||||
"passed": 0, "failed": 0, "skipped": 0,
|
||||
"errors": ["Test project failed to build due to transitive dependency errors from Concelier.Core (16 errors) and Attestor.ProofChain (4 errors). Not Graph module bugs."]
|
||||
}
|
||||
],
|
||||
"overallBuildResult": "fail",
|
||||
"overallTestResult": "fail",
|
||||
"verdict": "failed",
|
||||
"notes": "Graph.Indexer (overlay exporter) and Graph.Api (overlay service) are split across two projects. Graph.Indexer builds OK; Graph.Api fails with CS1061. Test projects blocked by upstream transitive breakage (Concelier.Core, Attestor.ProofChain). Overlay source code in Graph.Indexer compiles cleanly."
|
||||
}
|
||||
@@ -0,0 +1,26 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"issues": [
|
||||
{
|
||||
"id": "issue-1",
|
||||
"rootCause": "Program.cs line 460 calls .ToList() on EdgeMetadataResponse object instead of accessing its .Edges property.",
|
||||
"category": "bug",
|
||||
"affectedFiles": ["src/Graph/StellaOps.Graph.Api/Program.cs"],
|
||||
"confidence": 1.0,
|
||||
"severity": "blocking",
|
||||
"fixStrategy": "Change line 460 from 'edges.ToList()' to 'edges.Edges'."
|
||||
},
|
||||
{
|
||||
"id": "issue-2",
|
||||
"rootCause": "Upstream transitive dependency breakage in Concelier.Core and Attestor.ProofChain blocks all test projects.",
|
||||
"category": "env_issue",
|
||||
"affectedFiles": ["src/Concelier/StellaOps.Concelier.Core/", "src/Attestor/StellaOps.Attestor.ProofChain/"],
|
||||
"confidence": 0.95,
|
||||
"severity": "blocking",
|
||||
"fixStrategy": "Fix upstream modules (outside Graph scope)."
|
||||
}
|
||||
],
|
||||
"overallConfidence": 0.98,
|
||||
"notes": "Overlay feature spans both Graph.Indexer (exporter, builds OK) and Graph.Api (overlay service, fails due to CS1061). Test projects blocked by upstream breakage."
|
||||
}
|
||||
@@ -0,0 +1,17 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"approved": true,
|
||||
"reason": "Confirmed: MeterListener cross-contamination via meter name matching. The OverlayCacheCounters_RecordHitsAndMisses test subscribes to instruments by meter NAME ('StellaOps.Graph.Api') at line 67, while BudgetDeniedCounter_IncrementsOnEdgeBudgetExceeded correctly subscribes by meter INSTANCE reference (instrument.Meter == metrics.Meter) at line 25. When run in parallel with QueryServiceTests.OverlayMerge_IncludesExplainTrace, which creates an undisposed GraphMetrics and triggers 2 overlay cache misses (2 nodes with IncludeOverlays=true), the listener picks up those 2 extra miss events + 1 from its own test = 3 total (matches the observed 'Expected: 1, Actual: 3'). Verified experimentally: test passes in isolation (-class MetricsTests, 2/2 pass), fails with QueryServiceTests (-class MetricsTests -class QueryServiceTests, 1 fail with exact Expected:1 Actual:3), and passes with -maxThreads 1 (serial execution, 0 MetricsTests failures).",
|
||||
"revisedRootCause": "The OverlayCacheCounters_RecordHitsAndMisses test's MeterListener subscribes by meter name string ('StellaOps.Graph.Api') instead of by meter instance reference, causing it to receive overlay cache miss events from undisposed GraphMetrics instances in other test classes (specifically QueryServiceTests.OverlayMerge_IncludesExplainTrace which creates an undisposed GraphMetrics and triggers 2 cache misses for 2 nodes). The BudgetDeniedCounter test in the same class is not affected because it correctly filters by instance reference. This is a parallelism + resource disposal issue, not just meter naming.",
|
||||
"revisedCategory": "test_gap",
|
||||
"revisedAffectedFiles": [
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/MetricsTests.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/QueryServiceTests.cs"
|
||||
],
|
||||
"blastRadius": "low",
|
||||
"regressionRisk": "none - fix is limited to test instrumentation subscription, not production code",
|
||||
"revisedSuggestedFix": "Change line 67 in MetricsTests.cs from 'instrument.Meter.Name == \"StellaOps.Graph.Api\"' to 'instrument.Meter == metrics.Meter' (matching the pattern already used in BudgetDeniedCounter test at line 25). This is the simplest fix — it uses instance-level filtering to isolate from other tests' meters. Additionally, QueryServiceTests.cs line 78 and line 117 should add 'using' to dispose GraphMetrics instances, preventing leaked meters from affecting other tests. The triage's suggested fix of unique meter names per test would also work but is unnecessarily invasive — it requires modifying production code (GraphMetrics constructor) when the real issue is purely in test listener subscription.",
|
||||
"additionalContext": "15 other test files in the project create GraphMetrics() without 'using' disposal. While fixing the listener subscription in MetricsTests.cs is sufficient to fix THIS test, the broader pattern of undisposed meters is a latent test hygiene issue that could cause similar problems if other tests add MeterListener-based assertions.",
|
||||
"confidence": 0.98,
|
||||
"verificationMethod": "Ran tests in 3 configurations: (1) MetricsTests alone: 2/2 pass; (2) MetricsTests + QueryServiceTests: OverlayCacheCounters fails with Expected:1 Actual:3; (3) All tests with -maxThreads 1: MetricsTests passes (only EdgeMetadataServiceTests fail, unrelated). This conclusively proves parallel cross-contamination via name-based MeterListener subscription."
|
||||
}
|
||||
@@ -0,0 +1,16 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"filesModified": [
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/MetricsTests.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/QueryServiceTests.cs"
|
||||
],
|
||||
"testsAdded": [],
|
||||
"description": "Aligned overlay cache counter listener to subscribe by GraphMetrics meter instance instead of meter name and updated QueryServiceTests to dispose GraphMetrics instances with using to prevent MeterListener cross-test contamination.",
|
||||
"buildVerified": true,
|
||||
"testResults": {
|
||||
"passed": 52,
|
||||
"failed": 0
|
||||
},
|
||||
"notes": "dotnet build and dotnet test both pass for StellaOps.Graph.Api.Tests after the test-only fixes."
|
||||
}
|
||||
@@ -0,0 +1,32 @@
|
||||
{
|
||||
"previousFailures": [
|
||||
{
|
||||
"tier": 1,
|
||||
"reason": "1 MetricsTests.OverlayCacheCounters failed due to MeterListener cross-contamination between tests — name-based meter filtering picked up instruments from other tests' GraphMetrics instances"
|
||||
}
|
||||
],
|
||||
"retestResults": [
|
||||
{
|
||||
"tier": 1,
|
||||
"result": "pass",
|
||||
"evidence": "dotnet build succeeded with 0 errors, 0 warnings. dotnet test Graph.Api.Tests: 52 passed, 0 failed, 0 skipped. MetricsTests: 2/2 passed (OverlayCacheCounters now passes with instance-based meter filtering). QueryServiceTests: 3/3 passed (using statements for GraphMetrics confirmed no regression)."
|
||||
}
|
||||
],
|
||||
"regressionCheck": {
|
||||
"testsRun": 108,
|
||||
"testsPassed": 108,
|
||||
"testsFailed": 0,
|
||||
"newTestsRun": 2,
|
||||
"newTestsPassed": 2,
|
||||
"details": {
|
||||
"Graph.Api.Tests": { "total": 52, "passed": 52, "failed": 0 },
|
||||
"Graph.Core.Tests": { "total": 19, "passed": 19, "failed": 0 },
|
||||
"Graph.Indexer.Tests": { "total": 37, "passed": 37, "failed": 0 },
|
||||
"Graph.Indexer.Persistence.Tests": { "total": 17, "passed": 0, "failed": 17, "skipped": true, "skipReason": "Requires Docker/PostgreSQL Testcontainers — environment not available" }
|
||||
}
|
||||
},
|
||||
"verdict": "pass",
|
||||
"failureDetails": null,
|
||||
"notes": "MetricsTests.OverlayCacheCounters now passes with instance-based meter filtering fix. QueryServiceTests (3/3) pass with GraphMetrics using statements — no regression. All 108 non-persistence tests pass. Persistence tests (17) skipped due to Docker/PostgreSQL unavailability — pre-existing, not a regression.",
|
||||
"retestDateUtc": "2026-02-09T21:43:00Z"
|
||||
}
|
||||
@@ -0,0 +1,20 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"rootCause": "MeterListener in test picks up overlay cache miss events from previous test's undisposed Meter instance, causing accumulated miss count of 3 instead of expected 1",
|
||||
"category": "test_gap",
|
||||
"affectedFiles": [
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/MetricsTests.cs"
|
||||
],
|
||||
"confidence": 0.75,
|
||||
"details": {
|
||||
"failedTests": [
|
||||
{
|
||||
"testName": "MetricsTests.OverlayCacheCounters_RecordHitsAndMisses",
|
||||
"rootCause": "MeterListener subscribes to all Meter instances with name 'StellaOps.Graph.Api' globally, not just the current test's metrics instance. The first test (BudgetDeniedCounter_IncrementsOnEdgeBudgetExceeded) creates a GraphMetrics instance with a Meter of the same name. Even though the first test uses 'using var metrics', the Meter disposal may not complete before the second test's listener starts, causing the listener to aggregate events from both tests. The test expects 1 cache miss (first query) and 1 cache hit (second query), but gets 3 misses total, suggesting cross-test contamination.",
|
||||
"suggestedFix": "Isolate each test's meter by using unique meter names (e.g., include test name or GUID in meter name), OR use a test-specific MeterListener that filters by meter instance rather than meter name, OR ensure meters are fully disposed before starting the next test's listener (e.g., add explicit disposal wait or use AsyncTestSyncContext), OR restructure the test to avoid shared meter naming by creating separate test classes for each metrics test"
|
||||
}
|
||||
]
|
||||
},
|
||||
"suggestedFix": "Use unique meter names per test to prevent MeterListener cross-contamination. Change GraphMetrics constructor to accept an optional meter name suffix, and modify the test to pass a unique identifier (e.g., test method name or GUID) when creating GraphMetrics instances in tests."
|
||||
}
|
||||
Reference in New Issue
Block a user