stabilizaiton work - projects rework for maintenanceability and ui livening
This commit is contained in:
@@ -1,8 +1,8 @@
|
||||
using StellaOps.TestKit;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using StellaOps.TestKit;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Policy.Tools.Tests;
|
||||
@@ -11,7 +11,7 @@ public sealed class PolicySchemaExporterRunnerTests
|
||||
{
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_WritesLfLineEndings()
|
||||
public async Task RunAsync_WritesLfLineEndingsAsync()
|
||||
{
|
||||
using var temp = new TempDirectory("schema-export");
|
||||
var runner = new PolicySchemaExporterRunner();
|
||||
|
||||
@@ -0,0 +1,99 @@
|
||||
using StellaOps.TestKit;
|
||||
using System.Collections.Generic;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Policy.Tools.Tests;
|
||||
|
||||
public sealed class PolicySimulationSmokeRunnerInvalidInputTests
|
||||
{
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_ReportsInvalidSeverityAsync()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-invalid-severity");
|
||||
PolicySimulationSmokeTestHelpers.WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "invalid-severity",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "F-1", Severity = "NotASeverity" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>()
|
||||
};
|
||||
|
||||
var scenarioRoot = PolicySimulationSmokeTestHelpers.WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = PolicySimulationSmokeTestHelpers.BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(1, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
Assert.False(entry.GetProperty("Success").GetBoolean());
|
||||
|
||||
var failures = entry.GetProperty("Failures")
|
||||
.EnumerateArray()
|
||||
.Select(value => value.GetString())
|
||||
.ToArray();
|
||||
|
||||
Assert.Contains("Scenario 'invalid-severity' finding 'F-1' has invalid severity 'NotASeverity'.", failures);
|
||||
}
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_ReportsInvalidBaselineStatusAsync()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-invalid-status");
|
||||
PolicySimulationSmokeTestHelpers.WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "invalid-status",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "F-1", Severity = "Low" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>(),
|
||||
Baseline = new List<ScenarioBaseline>
|
||||
{
|
||||
new() { FindingId = "F-1", Status = "BadStatus" }
|
||||
}
|
||||
};
|
||||
|
||||
var scenarioRoot = PolicySimulationSmokeTestHelpers.WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = PolicySimulationSmokeTestHelpers.BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(1, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
Assert.False(entry.GetProperty("Success").GetBoolean());
|
||||
|
||||
var failures = entry.GetProperty("Failures")
|
||||
.EnumerateArray()
|
||||
.Select(value => value.GetString())
|
||||
.ToArray();
|
||||
|
||||
Assert.Contains("Scenario 'invalid-status' baseline 'F-1' has invalid status 'BadStatus'.", failures);
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,66 @@
|
||||
using StellaOps.TestKit;
|
||||
using System.Collections.Generic;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Policy.Tools.Tests;
|
||||
|
||||
public sealed class PolicySimulationSmokeRunnerOrderingTests
|
||||
{
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_SortsActualStatusesInSummaryAsync()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-ordering");
|
||||
PolicySimulationSmokeTestHelpers.WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "ordering",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "b", Severity = "Low" },
|
||||
new() { FindingId = "a", Severity = "Low" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>
|
||||
{
|
||||
new() { FindingId = "b", Status = "Blocked" },
|
||||
new() { FindingId = "a", Status = "Blocked" }
|
||||
}
|
||||
};
|
||||
|
||||
var scenarioRoot = PolicySimulationSmokeTestHelpers.WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = PolicySimulationSmokeTestHelpers.BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(0, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
var actualStatuses = entry.GetProperty("ActualStatuses")
|
||||
.EnumerateObject()
|
||||
.Select(pair => pair.Name)
|
||||
.ToArray();
|
||||
|
||||
Assert.Equal(new[] { "a", "b" }, actualStatuses);
|
||||
}
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public void ResolveFixedTime_UsesDefaultWhenMissing()
|
||||
{
|
||||
var resolved = PolicySimulationSmokeDefaults.ResolveFixedTime(null);
|
||||
|
||||
Assert.Equal(PolicySimulationSmokeDefaults.DefaultFixedTime, resolved);
|
||||
}
|
||||
}
|
||||
@@ -1,181 +0,0 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using System.Threading;
|
||||
using System.Threading.Tasks;
|
||||
using StellaOps.TestKit;
|
||||
using Xunit;
|
||||
|
||||
namespace StellaOps.Policy.Tools.Tests;
|
||||
|
||||
public sealed class PolicySimulationSmokeRunnerTests
|
||||
{
|
||||
private const string PolicyJson = "{\n \"version\": \"1.0\",\n \"rules\": [\n {\n \"name\": \"block-low\",\n \"action\": \"block\",\n \"severity\": [\"low\"]\n }\n ]\n}\n";
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_ReportsInvalidSeverity()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-invalid-severity");
|
||||
WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "invalid-severity",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "F-1", Severity = "NotASeverity" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>()
|
||||
};
|
||||
|
||||
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(1, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
Assert.False(entry.GetProperty("Success").GetBoolean());
|
||||
|
||||
var failures = entry.GetProperty("Failures")
|
||||
.EnumerateArray()
|
||||
.Select(value => value.GetString())
|
||||
.ToArray();
|
||||
|
||||
Assert.Contains("Scenario 'invalid-severity' finding 'F-1' has invalid severity 'NotASeverity'.", failures);
|
||||
}
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_ReportsInvalidBaselineStatus()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-invalid-status");
|
||||
WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "invalid-status",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "F-1", Severity = "Low" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>(),
|
||||
Baseline = new List<ScenarioBaseline>
|
||||
{
|
||||
new() { FindingId = "F-1", Status = "BadStatus" }
|
||||
}
|
||||
};
|
||||
|
||||
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(1, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
Assert.False(entry.GetProperty("Success").GetBoolean());
|
||||
|
||||
var failures = entry.GetProperty("Failures")
|
||||
.EnumerateArray()
|
||||
.Select(value => value.GetString())
|
||||
.ToArray();
|
||||
|
||||
Assert.Contains("Scenario 'invalid-status' baseline 'F-1' has invalid status 'BadStatus'.", failures);
|
||||
}
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public async Task RunAsync_SortsActualStatusesInSummary()
|
||||
{
|
||||
using var temp = new TempDirectory("policy-sim-ordering");
|
||||
WritePolicy(temp.RootPath);
|
||||
|
||||
var scenario = new PolicySimulationScenario
|
||||
{
|
||||
Name = "ordering",
|
||||
PolicyPath = "policy.json",
|
||||
Findings = new List<ScenarioFinding>
|
||||
{
|
||||
new() { FindingId = "b", Severity = "Low" },
|
||||
new() { FindingId = "a", Severity = "Low" }
|
||||
},
|
||||
ExpectedDiffs = new List<ScenarioExpectedDiff>
|
||||
{
|
||||
new() { FindingId = "b", Status = "Blocked" },
|
||||
new() { FindingId = "a", Status = "Blocked" }
|
||||
}
|
||||
};
|
||||
|
||||
var scenarioRoot = WriteScenario(temp.RootPath, scenario);
|
||||
var outputRoot = Path.Combine(temp.RootPath, "out");
|
||||
var options = BuildOptions(scenarioRoot, outputRoot, temp.RootPath);
|
||||
|
||||
var runner = new PolicySimulationSmokeRunner();
|
||||
var exitCode = await runner.RunAsync(options, CancellationToken.None);
|
||||
|
||||
Assert.Equal(0, exitCode);
|
||||
|
||||
var summaryPath = Path.Combine(outputRoot, "policy-simulation-summary.json");
|
||||
using var document = JsonDocument.Parse(await File.ReadAllTextAsync(summaryPath, CancellationToken.None));
|
||||
var entry = document.RootElement.EnumerateArray().Single();
|
||||
|
||||
var actualStatuses = entry.GetProperty("ActualStatuses").EnumerateObject().Select(pair => pair.Name).ToArray();
|
||||
|
||||
Assert.Equal(new[] { "a", "b" }, actualStatuses);
|
||||
}
|
||||
|
||||
[Trait("Category", TestCategories.Unit)]
|
||||
[Fact]
|
||||
public void ResolveFixedTime_UsesDefaultWhenMissing()
|
||||
{
|
||||
var resolved = PolicySimulationSmokeDefaults.ResolveFixedTime(null);
|
||||
|
||||
Assert.Equal(PolicySimulationSmokeDefaults.DefaultFixedTime, resolved);
|
||||
}
|
||||
|
||||
private static PolicySimulationSmokeOptions BuildOptions(string scenarioRoot, string outputRoot, string repoRoot)
|
||||
=> new()
|
||||
{
|
||||
ScenarioRoot = scenarioRoot,
|
||||
OutputDirectory = outputRoot,
|
||||
RepoRoot = repoRoot,
|
||||
FixedTime = new DateTimeOffset(2025, 1, 1, 0, 0, 0, TimeSpan.Zero)
|
||||
};
|
||||
|
||||
private static void WritePolicy(string rootPath)
|
||||
{
|
||||
var policyPath = Path.Combine(rootPath, "policy.json");
|
||||
File.WriteAllText(policyPath, PolicyJson);
|
||||
}
|
||||
|
||||
private static string WriteScenario(string rootPath, PolicySimulationScenario scenario)
|
||||
{
|
||||
var scenarioRoot = Path.Combine(rootPath, "scenarios");
|
||||
Directory.CreateDirectory(scenarioRoot);
|
||||
|
||||
var scenarioPath = Path.Combine(scenarioRoot, "scenario.json");
|
||||
var scenarioJson = JsonSerializer.Serialize(
|
||||
scenario,
|
||||
new JsonSerializerOptions(JsonSerializerDefaults.Web) { WriteIndented = true });
|
||||
File.WriteAllText(scenarioPath, scenarioJson);
|
||||
|
||||
return scenarioRoot;
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,39 @@
|
||||
using System;
|
||||
using System.IO;
|
||||
using System.Text.Json;
|
||||
|
||||
namespace StellaOps.Policy.Tools.Tests;
|
||||
|
||||
internal static class PolicySimulationSmokeTestHelpers
|
||||
{
|
||||
internal const string PolicyJson = "{\n \"version\": \"1.0\",\n \"rules\": [\n {\n \"name\": \"block-low\",\n \"action\": \"block\",\n \"severity\": [\"low\"]\n }\n ]\n}\n";
|
||||
|
||||
internal static PolicySimulationSmokeOptions BuildOptions(string scenarioRoot, string outputRoot, string repoRoot)
|
||||
=> new()
|
||||
{
|
||||
ScenarioRoot = scenarioRoot,
|
||||
OutputDirectory = outputRoot,
|
||||
RepoRoot = repoRoot,
|
||||
FixedTime = new DateTimeOffset(2025, 1, 1, 0, 0, 0, TimeSpan.Zero)
|
||||
};
|
||||
|
||||
internal static void WritePolicy(string rootPath)
|
||||
{
|
||||
var policyPath = Path.Combine(rootPath, "policy.json");
|
||||
File.WriteAllText(policyPath, PolicyJson);
|
||||
}
|
||||
|
||||
internal static string WriteScenario(string rootPath, PolicySimulationScenario scenario)
|
||||
{
|
||||
var scenarioRoot = Path.Combine(rootPath, "scenarios");
|
||||
Directory.CreateDirectory(scenarioRoot);
|
||||
|
||||
var scenarioPath = Path.Combine(scenarioRoot, "scenario.json");
|
||||
var scenarioJson = JsonSerializer.Serialize(
|
||||
scenario,
|
||||
new JsonSerializerOptions(JsonSerializerDefaults.Web) { WriteIndented = true });
|
||||
File.WriteAllText(scenarioPath, scenarioJson);
|
||||
|
||||
return scenarioRoot;
|
||||
}
|
||||
}
|
||||
@@ -3,6 +3,7 @@
|
||||
<TargetFramework>net10.0</TargetFramework>
|
||||
<ImplicitUsings>enable</ImplicitUsings>
|
||||
<Nullable>enable</Nullable>
|
||||
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
|
||||
</PropertyGroup>
|
||||
|
||||
<ItemGroup>
|
||||
|
||||
@@ -7,3 +7,6 @@ Source of truth: `docs-archived/implplan/2025-12-29-csproj-audit/SPRINT_20251229
|
||||
| --- | --- | --- |
|
||||
| AUDIT-0096-A | DONE | Added Policy.Tools runner coverage 2026-01-14. |
|
||||
| REMED-06 | DONE | SOLID review notes captured for SPRINT_20260130_002. |
|
||||
| REMED-03 | DONE | Tier 0 remediation (usings sorted, deterministic temp paths, warnings as errors); dotnet test passed 2026-02-02. |
|
||||
| REMED-04 | DONE | Async naming updates; ConfigureAwait(false) skipped in tests per xUnit1030; dotnet test passed 2026-02-02. |
|
||||
| REMED-05 | DONE | PolicySimulationSmokeRunner tests split to keep files <= 100 lines; dotnet test passed 2026-02-02. |
|
||||
|
||||
@@ -7,7 +7,11 @@ internal sealed class TempDirectory : IDisposable
|
||||
{
|
||||
public TempDirectory(string name)
|
||||
{
|
||||
RootPath = Path.Combine(Path.GetTempPath(), "stellaops-policy-tools-tests", $"{name}-{Guid.NewGuid():N}");
|
||||
RootPath = Path.Combine(Path.GetTempPath(), "stellaops-policy-tools-tests", name);
|
||||
if (Directory.Exists(RootPath))
|
||||
{
|
||||
Directory.Delete(RootPath, recursive: true);
|
||||
}
|
||||
Directory.CreateDirectory(RootPath);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user