stabilizaiton work - projects rework for maintenanceability and ui livening

src/Concelier/__Tests/StellaOps.Concelier.Core.Tests/TASKS.md

@@ -8,3 +8,4 @@ Source of truth: `docs-archived/implplan/2025-12-29-csproj-audit/SPRINT_20251229
 | AUDIT-0212-M | DONE | Revalidated 2026-01-06. |
 | AUDIT-0212-T | DONE | Revalidated 2026-01-06. |
 | AUDIT-0212-A | DONE | Waived (test project; revalidated 2026-01-06). |
+| REMED-08 | DONE | Added ingestion telemetry metric tag tests; `dotnet test src/Concelier/__Tests/StellaOps.Concelier.Core.Tests/StellaOps.Concelier.Core.Tests.csproj` passed (2026-02-03). |

src/Concelier/__Tests/StellaOps.Concelier.Core.Tests/Telemetry/IngestionTelemetryMetricsTestHelpers.cs

@@ -0,0 +1,74 @@
+using System.Diagnostics.Metrics;
+using StellaOps.Ingestion.Telemetry;
+
+namespace StellaOps.Concelier.Core.Tests.Telemetry;
+
+internal static class IngestionTelemetryMetricsTestHelpers
+{
+    internal static List<KeyValuePair<string, object?>[]> CaptureCounter(
+        string instrumentName,
+        Action action)
+    {
+        var measurements = new List<KeyValuePair<string, object?>[]>();
+        using var listener = new MeterListener();
+        listener.InstrumentPublished += (instrument, meterListener) =>
+        {
+            if (instrument.Meter.Name == IngestionTelemetry.MeterName && instrument.Name == instrumentName)
+            {
+                meterListener.EnableMeasurementEvents(instrument);
+            }
+        };
+
+        listener.SetMeasurementEventCallback<long>((instrument, measurement, tags, state) =>
+        {
+            if (instrument.Name == instrumentName)
+            {
+                measurements.Add(tags.ToArray());
+            }
+        });
+
+        listener.Start();
+        action();
+        return measurements;
+    }
+
+    internal static List<KeyValuePair<string, object?>[]> CaptureHistogram(
+        string instrumentName,
+        Action action)
+    {
+        var measurements = new List<KeyValuePair<string, object?>[]>();
+        using var listener = new MeterListener();
+        listener.InstrumentPublished += (instrument, meterListener) =>
+        {
+            if (instrument.Meter.Name == IngestionTelemetry.MeterName && instrument.Name == instrumentName)
+            {
+                meterListener.EnableMeasurementEvents(instrument);
+            }
+        };
+
+        listener.SetMeasurementEventCallback<double>((instrument, measurement, tags, state) =>
+        {
+            if (instrument.Name == instrumentName)
+            {
+                measurements.Add(tags.ToArray());
+            }
+        });
+
+        listener.Start();
+        action();
+        return measurements;
+    }
+
+    internal static object? GetTagValue(IEnumerable<KeyValuePair<string, object?>> tags, string key)
+    {
+        foreach (var tag in tags)
+        {
+            if (string.Equals(tag.Key, key, StringComparison.Ordinal))
+            {
+                return tag.Value;
+            }
+        }
+
+        return null;
+    }
+}

src/Concelier/__Tests/StellaOps.Concelier.Core.Tests/Telemetry/IngestionTelemetryMetricsTests.cs

@@ -0,0 +1,76 @@
+using StellaOps.Ingestion.Telemetry;
+using Xunit;
+
+namespace StellaOps.Concelier.Core.Tests.Telemetry;
+
+public sealed class IngestionTelemetryMetricsTests
+{
+    [Fact]
+    public void RecordWriteAttempt_EmitsResultTag()
+    {
+        var measurements = IngestionTelemetryMetricsTestHelpers.CaptureCounter(
+            "ingestion_write_total",
+            () => IngestionTelemetry.RecordWriteAttempt("tenant-1", "source-1", IngestionTelemetry.ResultOk));
+
+        Assert.Contains(
+            measurements,
+            tags => string.Equals(
+                IngestionTelemetryMetricsTestHelpers.GetTagValue(tags, "result") as string,
+                IngestionTelemetry.ResultOk,
+                StringComparison.Ordinal));
+    }
+
+    [Fact]
+    public void RecordWriteAttempt_BlankResult_DoesNotEmit()
+    {
+        var measurements = IngestionTelemetryMetricsTestHelpers.CaptureCounter(
+            "ingestion_write_total",
+            () => IngestionTelemetry.RecordWriteAttempt("tenant-1", "source-1", " "));
+
+        Assert.Empty(measurements);
+    }
+
+    [Fact]
+    public void RecordViolation_EmitsCodeTag()
+    {
+        var measurements = IngestionTelemetryMetricsTestHelpers.CaptureCounter(
+            "aoc_violation_total",
+            () => IngestionTelemetry.RecordViolation("tenant-1", "source-1", "ERR_AOC_001"));
+
+        Assert.Contains(
+            measurements,
+            tags => string.Equals(
+                IngestionTelemetryMetricsTestHelpers.GetTagValue(tags, "code") as string,
+                "ERR_AOC_001",
+                StringComparison.Ordinal));
+    }
+
+    [Fact]
+    public void RecordLatency_EmitsPhaseTag()
+    {
+        var measurements = IngestionTelemetryMetricsTestHelpers.CaptureHistogram(
+            "ingestion_latency_seconds",
+            () => IngestionTelemetry.RecordLatency(
+                "tenant-1",
+                "source-1",
+                IngestionTelemetry.PhaseFetch,
+                TimeSpan.FromSeconds(1)));
+
+        Assert.Contains(
+            measurements,
+            tags => string.Equals(
+                IngestionTelemetryMetricsTestHelpers.GetTagValue(tags, "phase") as string,
+                IngestionTelemetry.PhaseFetch,
+                StringComparison.Ordinal));
+    }
+
+    [Fact]
+    public void RecordLatency_BlankPhase_DoesNotEmit()
+    {
+        var measurements = IngestionTelemetryMetricsTestHelpers.CaptureHistogram(
+            "ingestion_latency_seconds",
+            () => IngestionTelemetry.RecordLatency("tenant-1", "source-1", "", TimeSpan.FromSeconds(1)));
+
+        Assert.Empty(measurements);
+    }
+}