more audit work
This commit is contained in:
@@ -1,6 +1,5 @@
|
||||
using System.Collections.Concurrent;
|
||||
using System.Security.Cryptography;
|
||||
using System.Text;
|
||||
using Microsoft.IdentityModel.Tokens;
|
||||
using StellaOps.Cryptography;
|
||||
|
||||
@@ -98,25 +97,7 @@ public sealed class KmsCryptoProvider : ICryptoProvider
|
||||
|
||||
if (material.D.Length == 0)
|
||||
{
|
||||
// Remote KMS keys may withhold private scalars; represent them as raw keys using public coordinates.
|
||||
var privateHandle = Encoding.UTF8.GetBytes(string.IsNullOrWhiteSpace(material.VersionId) ? material.KeyId : material.VersionId);
|
||||
if (privateHandle.Length == 0)
|
||||
{
|
||||
privateHandle = material.Qx.Length > 0
|
||||
? material.Qx
|
||||
: material.Qy.Length > 0
|
||||
? material.Qy
|
||||
: throw new InvalidOperationException($"KMS key '{material.KeyId}' does not expose public coordinates.");
|
||||
}
|
||||
|
||||
var publicKey = CombineCoordinates(material.Qx, material.Qy);
|
||||
signingKey = new CryptoSigningKey(
|
||||
reference,
|
||||
material.Algorithm,
|
||||
privateHandle,
|
||||
material.CreatedAt,
|
||||
metadata: metadata,
|
||||
publicKey: publicKey);
|
||||
continue;
|
||||
}
|
||||
else
|
||||
{
|
||||
@@ -150,26 +131,6 @@ public sealed class KmsCryptoProvider : ICryptoProvider
|
||||
public const string Version = "kms.version";
|
||||
}
|
||||
|
||||
private static byte[] CombineCoordinates(byte[] qx, byte[] qy)
|
||||
{
|
||||
if (qx.Length == 0 && qy.Length == 0)
|
||||
{
|
||||
return Array.Empty<byte>();
|
||||
}
|
||||
|
||||
var buffer = new byte[qx.Length + qy.Length];
|
||||
if (qx.Length > 0)
|
||||
{
|
||||
Buffer.BlockCopy(qx, 0, buffer, 0, qx.Length);
|
||||
}
|
||||
|
||||
if (qy.Length > 0)
|
||||
{
|
||||
Buffer.BlockCopy(qy, 0, buffer, qx.Length, qy.Length);
|
||||
}
|
||||
|
||||
return buffer;
|
||||
}
|
||||
}
|
||||
|
||||
internal sealed record KmsSigningRegistration(string KeyId, string VersionId, string Algorithm);
|
||||
|
||||
@@ -5,6 +5,6 @@ Source of truth: `docs/implplan/SPRINT_20251229_049_BE_csproj_audit_maint_tests.
|
||||
|
||||
| Task ID | Status | Notes |
|
||||
| --- | --- | --- |
|
||||
| AUDIT-0249-M | DONE | Revalidated 2026-01-07. |
|
||||
| AUDIT-0249-T | DONE | Revalidated 2026-01-07. |
|
||||
| AUDIT-0249-A | TODO | Revalidated 2026-01-07 (open findings). |
|
||||
| AUDIT-0051-M | DONE | Revalidated 2026-01-08. |
|
||||
| AUDIT-0051-T | DONE | Revalidated 2026-01-08. |
|
||||
| AUDIT-0051-A | TODO | Revalidated 2026-01-08 (open findings). |
|
||||
|
||||
Reference in New Issue
Block a user