documentation cleanse, sprints work and planning. remaining non EF DAL migration to EF
This commit is contained in:
@@ -0,0 +1,32 @@
|
||||
{
|
||||
"type": "source-verification",
|
||||
"capturedAtUtc": "2026-02-12T22:55:00Z",
|
||||
"feature": "registry-webhook-handlers",
|
||||
"module": "integrations",
|
||||
"sourceFilesExpected": [
|
||||
"src/Integrations/StellaOps.Integrations.WebService/IntegrationEndpoints.cs",
|
||||
"src/Integrations/StellaOps.Integrations.WebService/IntegrationService.cs",
|
||||
"src/Integrations/__Plugins/StellaOps.Integrations.Plugin.Harbor/HarborConnectorPlugin.cs",
|
||||
"src/Integrations/__Plugins/StellaOps.Integrations.Plugin.GitHubApp/GitHubAppConnectorPlugin.cs",
|
||||
"src/Integrations/__Libraries/StellaOps.Integrations.Contracts/IntegrationDtos.cs",
|
||||
"src/Integrations/StellaOps.Integrations.WebService/Program.cs"
|
||||
],
|
||||
"sourceFilesFound": [
|
||||
"src/Integrations/StellaOps.Integrations.WebService/IntegrationEndpoints.cs",
|
||||
"src/Integrations/StellaOps.Integrations.WebService/IntegrationService.cs",
|
||||
"src/Integrations/__Plugins/StellaOps.Integrations.Plugin.Harbor/HarborConnectorPlugin.cs",
|
||||
"src/Integrations/__Plugins/StellaOps.Integrations.Plugin.GitHubApp/GitHubAppConnectorPlugin.cs",
|
||||
"src/Integrations/__Libraries/StellaOps.Integrations.Contracts/IntegrationDtos.cs",
|
||||
"src/Integrations/StellaOps.Integrations.WebService/Program.cs"
|
||||
],
|
||||
"sourceFilesPercent": 100,
|
||||
"missingBehavior": [
|
||||
"No webhook handler endpoints found at /api/v1/webhooks/registry/* or similar. IntegrationEndpoints.cs only maps /api/v1/integrations/* (CRUD + test + health + providers).",
|
||||
"No Channel-based queue or background worker for gate evaluation found in any Integrations source file.",
|
||||
"No 'webhook' string found in any .cs file under src/Integrations/.",
|
||||
"No webhook payload parsing, signature validation, or Docker Registry v2 event handling code exists.",
|
||||
"The webhook concept only appears in the Angular wizard UI as a toggle (webhookEnabled/webhookSecret) for future use."
|
||||
],
|
||||
"verdict": "fail",
|
||||
"notes": "While the listed source files exist (they are shared with other features), the feature-specific webhook handler behavior (receiving webhook payloads at /api/v1/webhooks/registry/*, Channel-based async queue, background worker for gate evaluation, Docker/Harbor webhook payload parsing) is NOT implemented. The feature spec overstates what exists."
|
||||
}
|
||||
@@ -0,0 +1,31 @@
|
||||
{
|
||||
"type": "code-review",
|
||||
"capturedAtUtc": "2026-02-12T22:55:00Z",
|
||||
"feature": "registry-webhook-handlers",
|
||||
"module": "integrations",
|
||||
"checklist": {
|
||||
"mainClassExistsWithNonTrivialImplementation": false,
|
||||
"logicMatchesFeatureDescription": false,
|
||||
"unitTestsExerciseCoreBehavior": false,
|
||||
"testsAssertMeaningfulOutcomes": false
|
||||
},
|
||||
"sourceReview": {
|
||||
"IntegrationEndpoints.cs (134 lines)": "Maps /api/v1/integrations/* with CRUD, test connection, health, providers. NO webhook receiver endpoints at /api/v1/webhooks/registry/* or similar.",
|
||||
"IntegrationService.cs (324 lines)": "Integration lifecycle management. No webhook payload processing or gate evaluation queuing logic.",
|
||||
"HarborConnectorPlugin.cs (175 lines)": "Harbor registry connector with TestConnection (/api/v2.0/health) and CheckHealth. No webhook payload parsing or event handling.",
|
||||
"GitHubAppConnectorPlugin.cs (200 lines)": "GitHub App connector with auth (/app) and health (/rate_limit). No webhook processing.",
|
||||
"IntegrationDtos.cs (98 lines)": "CRUD DTOs only. No webhook payload models (Docker Registry v2 event, Harbor push event).",
|
||||
"Program.cs (92 lines)": "Registers integration services and maps IntegrationEndpoints. No webhook endpoint registration, no Channel-based queue, no background worker."
|
||||
},
|
||||
"missingImplementation": [
|
||||
"No webhook receiver endpoint (POST /api/v1/webhooks/registry/{provider})",
|
||||
"No Docker Registry v2 webhook event model",
|
||||
"No Harbor image-push webhook event model",
|
||||
"No Channel<T> based gate evaluation queue",
|
||||
"No BackgroundService worker for processing queued gate evaluations",
|
||||
"No webhook signature validation logic",
|
||||
"No webhook-specific tests"
|
||||
],
|
||||
"verdict": "fail",
|
||||
"notes": "The feature spec claims webhook handlers for Docker Registry v2 and Harbor image-push events with Channel-based queue and background worker. None of this exists in the codebase. The only webhook reference is the Angular wizard UI toggle (webhookEnabled) which is a configuration flag, not a handler implementation."
|
||||
}
|
||||
@@ -0,0 +1,25 @@
|
||||
{
|
||||
"type": "integration",
|
||||
"capturedAtUtc": "2026-02-12T22:55:00Z",
|
||||
"feature": "registry-webhook-handlers",
|
||||
"module": "integrations",
|
||||
"testProjects": [
|
||||
"src/Integrations/__Tests/StellaOps.Integrations.Tests/StellaOps.Integrations.Tests.csproj",
|
||||
"src/Integrations/__Tests/StellaOps.Integrations.Plugin.Tests/StellaOps.Integrations.Plugin.Tests.csproj"
|
||||
],
|
||||
"testFilter": "N/A - no webhook-specific tests exist",
|
||||
"testsRun": 0,
|
||||
"testsPassed": 0,
|
||||
"testsFailed": 0,
|
||||
"behaviorVerified": [],
|
||||
"missingBehavior": [
|
||||
"No webhook receiver endpoint to test",
|
||||
"No Docker Registry v2 event acceptance test",
|
||||
"No Harbor image-push event acceptance test",
|
||||
"No Channel-based queue processing test",
|
||||
"No webhook signature validation test",
|
||||
"No gate evaluation job queuing test"
|
||||
],
|
||||
"notes": "Tier 2d cannot be performed because the webhook handler feature is not implemented. No webhook-specific code exists in the Integrations module. The general integration tests (46 total, 37+9) all pass but do not cover webhook handling. The feature should be reclassified as UNIMPLEMENTED.",
|
||||
"verdict": "fail"
|
||||
}
|
||||
Reference in New Issue
Block a user