documentation cleanse, sprints work and planning. remaining non EF DAL migration to EF
This commit is contained in:
master
@@ -0,0 +1,20 @@
|
||||
{
|
||||
"feature": "graph-analytics-engine",
|
||||
"module": "graph",
|
||||
"confirmedAtUtc": "2026-02-09T18:00:00Z",
|
||||
"sharedConfirmationRef": "graph-edge-metadata-with-reason-evidence-provenance/run-001/confirmation.json",
|
||||
"confirmations": [
|
||||
{
|
||||
"issueId": "issue-1",
|
||||
"approved": true,
|
||||
"reason": "Confirmed via dotnet build. Program.cs line 460: .ToList() on EdgeMetadataResponse (sealed record, not IEnumerable). CS1061 build error verified. See shared confirmation for full details."
|
||||
},
|
||||
{
|
||||
"issueId": "issue-2",
|
||||
"approved": true,
|
||||
"reason": "Confirmed via dotnet build. Directory.Build.props auto-injects Concelier.Testing into all .Tests projects. Concelier.Core has 16 compile errors, Attestor.ProofChain has 4. See shared confirmation for full details."
|
||||
}
|
||||
],
|
||||
"overallApproved": true,
|
||||
"overallNotes": "Both shared root causes confirmed. This feature is blocked by the same two issues as all 7 Graph features."
|
||||
}
|
||||
@@ -0,0 +1,28 @@
|
||||
{
|
||||
"feature": "graph-module-shared",
|
||||
"module": "graph",
|
||||
"filesModified": [
|
||||
"src/Graph/StellaOps.Graph.Api/Program.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Api.Tests/StellaOps.Graph.Api.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/StellaOps.Graph.Indexer.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Core.Tests/StellaOps.Graph.Core.Tests.csproj",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Persistence.Tests/StellaOps.Graph.Indexer.Persistence.Tests.csproj"
|
||||
],
|
||||
"testsAdded": [],
|
||||
"description": "Fixed Graph.Api CS1061 bug (Program.cs:460 .ToList() -> Results.Ok(edges)). Opted 4 Graph test projects out of Concelier test infra via UseConcelierTestInfra=false. Added Microsoft.Extensions.TimeProvider.Testing to Graph.Api.Tests for FakeTimeProvider after opt-out.",
|
||||
"buildVerified": "partial",
|
||||
"buildResults": {
|
||||
"Graph.Api": "pass (CS1061 fixed)",
|
||||
"Graph.Indexer.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Core.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Indexer.Persistence.Tests": "pass (builds after opt-out)",
|
||||
"Graph.Api.Tests": "fail (EdgeMetadataServiceTests.cs has matching .ToList() bug + missing timeProvider constructor arg)"
|
||||
},
|
||||
"testResults": {
|
||||
"Graph.Indexer.Tests": "pass (37/37)",
|
||||
"Graph.Core.Tests": "pass (19/19)",
|
||||
"Graph.Api.Tests": "fail (compile error - cannot run)",
|
||||
"Graph.Indexer.Persistence.Tests": "fail (17/17 runtime failures - likely need Postgres)"
|
||||
},
|
||||
"notes": "Partial success. Issue 1 (CS1061) fixed. Issue 2 (opt-out) partially fixed -- 3/4 test projects now build and pass. Graph.Api.Tests has residual compile errors in EdgeMetadataServiceTests.cs (same .ToList() pattern as the production code bug, plus missing constructor arg). Graph.Indexer.Persistence.Tests all fail at runtime (likely require PostgreSQL). Fixer stopped because EdgeMetadataServiceTests.cs was not in the confirmed triage file list."
|
||||
}
|
||||
@@ -0,0 +1,23 @@
|
||||
{
|
||||
"previousFailures": [
|
||||
{ "tier": 1, "reason": "Build error CS1061: 'EdgeMetadataResponse' does not contain a definition for 'ToList' at Program.cs(460,70) in StellaOps.Graph.Api" },
|
||||
{ "tier": 1, "reason": "All test projects failed to build due to transitive dependency on StellaOps.Concelier.Testing pulling in broken Concelier.Core and Attestor.ProofChain modules" }
|
||||
],
|
||||
"retestResults": [
|
||||
{ "tier": 1, "check": "build", "result": "pass", "evidence": "All 4 source projects and all 4 test projects build successfully with 0 errors after CS1061 fix and UseConcelierTestInfra=false opt-out" },
|
||||
{ "tier": 1, "check": "tests-indexer-overlay", "result": "pass", "evidence": "Graph.Indexer.Tests: 37 passed, 0 failed, 0 skipped. Overlay exporter tests pass." },
|
||||
{ "tier": 1, "check": "tests-core-overlay", "result": "pass", "evidence": "Graph.Core.Tests: 19 passed, 0 failed, 0 skipped. Core overlay types pass." },
|
||||
{ "tier": 1, "check": "tests-api-metrics", "result": "fail", "evidence": "Graph.Api.Tests MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails with Assert.Equal() Expected: 1, Actual: 3 at line 103. This tests overlay cache metrics counters." }
|
||||
],
|
||||
"regressionCheck": {
|
||||
"testsRun": 108,
|
||||
"testsPassed": 103,
|
||||
"testsFailed": 6,
|
||||
"newTestsRun": 0,
|
||||
"newTestsPassed": 0,
|
||||
"notes": "1 overlay-related MetricsTests failure (OverlayCacheCounters_RecordHitsAndMisses). 5 EdgeMetadataServiceTests failures are in a different feature area. Graph.Indexer.Tests (37/37) and Graph.Core.Tests (19/19) all pass — these are the primary overlay system test coverage."
|
||||
},
|
||||
"verdict": "fail",
|
||||
"failureDetails": "MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails (Assert.Equal Expected: 1, Actual: 3). This test directly validates overlay cache counter instrumentation which is part of the overlay system feature. While the core overlay system tests pass (Graph.Indexer.Tests overlay exporter + Graph.Core.Tests), the cache metrics test indicates a counting bug in overlay cache instrumentation.",
|
||||
"notes": "Previous failures (CS1061 build error + Concelier transitive dependency) are fully resolved. Overlay exporter (Indexer) and overlay types (Core) tests all pass. However, MetricsTests.OverlayCacheCounters_RecordHitsAndMisses fails — this tests overlay cache metrics counters and is directly relevant to this feature. Needs investigation: counter is recording 3 instead of expected 1."
|
||||
}
|
||||
@@ -0,0 +1,34 @@
|
||||
{
|
||||
"filesChecked": [
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Analytics/GraphOverlayExporter.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayProcessor.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/IPolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IReachabilityDeltaService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryReachabilityDeltaService.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/GraphOverlayExporterTests.cs"
|
||||
],
|
||||
"found": [
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryOverlayService.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Analytics/GraphOverlayExporter.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayProcessor.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/PolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Policy/IPolicyOverlayMetrics.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlayTransformer.cs",
|
||||
"src/Graph/StellaOps.Graph.Indexer/Ingestion/Vex/VexOverlaySnapshot.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/IReachabilityDeltaService.cs",
|
||||
"src/Graph/StellaOps.Graph.Api/Services/InMemoryReachabilityDeltaService.cs",
|
||||
"src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/GraphOverlayExporterTests.cs"
|
||||
],
|
||||
"missing": [],
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,24 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"tier": 1,
|
||||
"buildResults": [
|
||||
{ "project": "src/Graph/__Libraries/StellaOps.Graph.Core/StellaOps.Graph.Core.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/__Libraries/StellaOps.Graph.Indexer.Persistence/StellaOps.Graph.Indexer.Persistence.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/StellaOps.Graph.Indexer/StellaOps.Graph.Indexer.csproj", "result": "pass", "errors": [] },
|
||||
{ "project": "src/Graph/StellaOps.Graph.Api/StellaOps.Graph.Api.csproj", "result": "fail", "errors": ["CS1061: 'EdgeMetadataResponse' does not contain a definition for 'ToList' at Program.cs(460,70)"] }
|
||||
],
|
||||
"testResults": [
|
||||
{
|
||||
"project": "src/Graph/__Tests/StellaOps.Graph.Indexer.Tests/StellaOps.Graph.Indexer.Tests.csproj",
|
||||
"filter": "FullyQualifiedName~Overlay",
|
||||
"result": "fail",
|
||||
"passed": 0, "failed": 0, "skipped": 0,
|
||||
"errors": ["Test project failed to build due to transitive dependency errors from Concelier.Core (16 errors) and Attestor.ProofChain (4 errors). Not Graph module bugs."]
|
||||
}
|
||||
],
|
||||
"overallBuildResult": "fail",
|
||||
"overallTestResult": "fail",
|
||||
"verdict": "failed",
|
||||
"notes": "Graph.Indexer (overlay exporter) and Graph.Api (overlay service) are split across two projects. Graph.Indexer builds OK; Graph.Api fails with CS1061. Test projects blocked by upstream transitive breakage (Concelier.Core, Attestor.ProofChain). Overlay source code in Graph.Indexer compiles cleanly."
|
||||
}
|
||||
@@ -0,0 +1,26 @@
|
||||
{
|
||||
"feature": "graph-overlay-system",
|
||||
"module": "graph",
|
||||
"issues": [
|
||||
{
|
||||
"id": "issue-1",
|
||||
"rootCause": "Program.cs line 460 calls .ToList() on EdgeMetadataResponse object instead of accessing its .Edges property.",
|
||||
"category": "bug",
|
||||
"affectedFiles": ["src/Graph/StellaOps.Graph.Api/Program.cs"],
|
||||
"confidence": 1.0,
|
||||
"severity": "blocking",
|
||||
"fixStrategy": "Change line 460 from 'edges.ToList()' to 'edges.Edges'."
|
||||
},
|
||||
{
|
||||
"id": "issue-2",
|
||||
"rootCause": "Upstream transitive dependency breakage in Concelier.Core and Attestor.ProofChain blocks all test projects.",
|
||||
"category": "env_issue",
|
||||
"affectedFiles": ["src/Concelier/StellaOps.Concelier.Core/", "src/Attestor/StellaOps.Attestor.ProofChain/"],
|
||||
"confidence": 0.95,
|
||||
"severity": "blocking",
|
||||
"fixStrategy": "Fix upstream modules (outside Graph scope)."
|
||||
}
|
||||
],
|
||||
"overallConfidence": 0.98,
|
||||
"notes": "Overlay feature spans both Graph.Indexer (exporter, builds OK) and Graph.Api (overlay service, fails due to CS1061). Test projects blocked by upstream breakage."
|
||||
}
|
||||
Reference in New Issue
Block a user