documentation cleanse, sprints work and planning. remaining non EF DAL migration to EF
This commit is contained in:
master
@@ -0,0 +1,6 @@
|
||||
{
|
||||
"approved": true,
|
||||
"reason": "Startup stack trace directly identifies missing IBinaryVulnerabilityService dependency in ResolutionService. Registering a deterministic fallback implementation in WebService composition root is required.",
|
||||
"revisedRootCause": "Missing DI registration for IBinaryVulnerabilityService in WebService Program.cs",
|
||||
"capturedAtUtc": "2026-02-11T18:30:40.1125058Z"
|
||||
}
|
||||
Binary file not shown.
@@ -0,0 +1,57 @@
|
||||
{
|
||||
"type": "source",
|
||||
"feature": "binaryindex-ops-endpoints",
|
||||
"module": "binaryindex",
|
||||
"runId": "run-001",
|
||||
"capturedAtUtc": "2026-02-11T18:25:51.0113267Z",
|
||||
"filesChecked": [
|
||||
"src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPool.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/FunctionIrCacheService.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPoolOptions.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOptions.cs"
|
||||
],
|
||||
"found": [
|
||||
"src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPool.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/FunctionIrCacheService.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPoolOptions.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOptions.cs"
|
||||
],
|
||||
"missing": [
|
||||
|
||||
],
|
||||
"declarations": [
|
||||
{
|
||||
"symbol": "BinaryIndexOpsController",
|
||||
"path": "src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs",
|
||||
"declared": true,
|
||||
"match": "class BinaryIndexOpsController"
|
||||
},
|
||||
{
|
||||
"symbol": "B2R2LifterPool",
|
||||
"path": "src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPool.cs",
|
||||
"declared": true,
|
||||
"match": "class B2R2LifterPool"
|
||||
},
|
||||
{
|
||||
"symbol": "FunctionIrCacheService",
|
||||
"path": "src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/FunctionIrCacheService.cs",
|
||||
"declared": true,
|
||||
"match": "class FunctionIrCacheService"
|
||||
},
|
||||
{
|
||||
"symbol": "B2R2LifterPoolOptions",
|
||||
"path": "src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPoolOptions.cs",
|
||||
"declared": true,
|
||||
"match": "class B2R2LifterPoolOptions"
|
||||
},
|
||||
{
|
||||
"symbol": "BinaryIndexOptions",
|
||||
"path": "src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOptions.cs",
|
||||
"declared": true,
|
||||
"match": "class BinaryIndexOptions"
|
||||
}
|
||||
],
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,53 @@
|
||||
{
|
||||
"type": "build",
|
||||
"module": "binaryindex",
|
||||
"feature": "binaryindex-ops-endpoints",
|
||||
"runId": "run-001",
|
||||
"capturedAtUtc": "2026-02-11T18:29:32.0704715Z",
|
||||
"project": "src/BinaryIndex/StellaOps.BinaryIndex.WebService/StellaOps.BinaryIndex.WebService.csproj",
|
||||
"testProject": "src/BinaryIndex/__Tests/StellaOps.BinaryIndex.WebService.Tests/StellaOps.BinaryIndex.WebService.Tests.csproj",
|
||||
"buildResult": "pass",
|
||||
"testResult": "pass",
|
||||
"testsRun": 38,
|
||||
"testsPassed": 38,
|
||||
"testsFailed": 0,
|
||||
"warnings": [
|
||||
"MTP0001: VSTestLogger ignored by Microsoft.Testing.Platform"
|
||||
],
|
||||
"codeReview": {
|
||||
"keyFilesReviewed": [
|
||||
"src/BinaryIndex/StellaOps.BinaryIndex.WebService/Controllers/BinaryIndexOpsController.cs",
|
||||
"src/BinaryIndex/StellaOps.BinaryIndex.WebService/Program.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Disassembly.B2R2/B2R2LifterPool.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Cache/FunctionIrCacheService.cs",
|
||||
"src/BinaryIndex/__Libraries/StellaOps.BinaryIndex.Core/Configuration/BinaryIndexOptions.cs"
|
||||
],
|
||||
"checklist": [
|
||||
{
|
||||
"item": "Main controller/service implementation exists and is non-trivial",
|
||||
"result": "yes",
|
||||
"evidence": "BinaryIndexOpsController implements health, bench, cache, config logic with validation and deterministic DTOs."
|
||||
},
|
||||
{
|
||||
"item": "Logic matches feature claims",
|
||||
"result": "yes",
|
||||
"evidence": "Controller exposes health/bench/cache/config ops endpoints and computes latency/cache stats."
|
||||
},
|
||||
{
|
||||
"item": "Unit/integration tests cover core behavior",
|
||||
"result": "partial",
|
||||
"evidence": "Model/options tests pass; no direct API startup coverage for ops endpoints."
|
||||
},
|
||||
{
|
||||
"item": "Assertions are meaningful",
|
||||
"result": "yes",
|
||||
"evidence": "Tests assert deterministic serialization, option bounds, and config redaction keys."
|
||||
}
|
||||
]
|
||||
},
|
||||
"evidence": {
|
||||
"buildLog": "evidence/tier1-build.log",
|
||||
"testLog": "evidence/tier1-test.log"
|
||||
},
|
||||
"verdict": "pass"
|
||||
}
|
||||
@@ -0,0 +1,23 @@
|
||||
{
|
||||
"type": "api",
|
||||
"module": "binaryindex",
|
||||
"feature": "binaryindex-ops-endpoints",
|
||||
"runId": "run-001",
|
||||
"baseUrl": "http://127.0.0.1:19061",
|
||||
"capturedAtUtc": "2026-02-11T18:28:58.9530616Z",
|
||||
"requests": [
|
||||
{
|
||||
"description": "Service startup prerequisite for ops API checks",
|
||||
"method": "RUN",
|
||||
"path": "dotnet run StellaOps.BinaryIndex.WebService",
|
||||
"expectedStatus": 0,
|
||||
"actualStatus": -532462766,
|
||||
"assertion": "WebService should start successfully so ops endpoints can be exercised",
|
||||
"result": "fail",
|
||||
"requestCapturedAtUtc": "2026-02-11T18:28:58.9595385Z",
|
||||
"evidence": "evidence/00-service-startup.txt",
|
||||
"responseSnippet": "Service failed to start: Unable to resolve service for type IBinaryVulnerabilityService when activating ResolutionService."
|
||||
}
|
||||
],
|
||||
"verdict": "fail"
|
||||
}
|
||||
@@ -0,0 +1,12 @@
|
||||
{
|
||||
"rootCause": "BinaryIndex WebService DI graph lacks any registration for IBinaryVulnerabilityService, causing ResolutionService construction failure during host startup.",
|
||||
"category": "config",
|
||||
"affectedFiles": [
|
||||
"src/BinaryIndex/StellaOps.BinaryIndex.WebService/Program.cs"
|
||||
],
|
||||
"confidence": 0.98,
|
||||
"capturedAtUtc": "2026-02-11T18:30:40.0198892Z",
|
||||
"evidence": [
|
||||
"evidence/00-service-startup.txt"
|
||||
]
|
||||
}
|
||||
Reference in New Issue
Block a user