docs consolidation and others

src/AdvisoryAI/StellaOps.AdvisoryAI/PolicyStudio/PolicyBundleCompiler.cs

@@ -317,15 +317,18 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
     private readonly IPolicyRuleGenerator _ruleGenerator;
     private readonly IPolicyBundleSigner? _signer;
     private readonly ILogger<PolicyBundleCompiler> _logger;
+    private readonly TimeProvider _timeProvider;
 
     public PolicyBundleCompiler(
         IPolicyRuleGenerator ruleGenerator,
         IPolicyBundleSigner? signer,
-        ILogger<PolicyBundleCompiler> logger)
+        ILogger<PolicyBundleCompiler> logger,
+        TimeProvider? timeProvider = null)
     {
         _ruleGenerator = ruleGenerator ?? throw new ArgumentNullException(nameof(ruleGenerator));
         _signer = signer;
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
+        _timeProvider = timeProvider ?? TimeProvider.System;
     }
 
     public async Task<PolicyCompilationResult> CompileAsync(
@@ -388,7 +391,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
                 Warnings = warnings,
                 ValidationReport = validationReport,
                 TestReport = testReport,
-                CompiledAt = DateTime.UtcNow.ToString("O")
+                CompiledAt = _timeProvider.GetUtcNow().ToString("O")
             };
         }
 
@@ -425,7 +428,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
         // Validate trust roots
         foreach (var root in bundle.TrustRoots)
         {
-            if (root.ExpiresAt.HasValue && root.ExpiresAt.Value < DateTimeOffset.UtcNow)
+            if (root.ExpiresAt.HasValue && root.ExpiresAt.Value < _timeProvider.GetUtcNow())
             {
                 semanticWarnings.Add($"Trust root '{root.Principal.Id}' has expired");
             }
@@ -489,7 +492,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
                 ContentDigest = contentDigest,
                 Signature = string.Empty,
                 Algorithm = "none",
-                SignedAt = DateTime.UtcNow.ToString("O")
+                SignedAt = _timeProvider.GetUtcNow().ToString("O")
             };
         }
 
@@ -506,7 +509,7 @@ public sealed class PolicyBundleCompiler : IPolicyBundleCompiler
             Algorithm = signature.Algorithm,
             KeyId = options.KeyId,
             SignerIdentity = options.SignerIdentity,
-            SignedAt = DateTime.UtcNow.ToString("O"),
+            SignedAt = _timeProvider.GetUtcNow().ToString("O"),
             CertificateChain = signature.CertificateChain
         };
     }