Refactor code structure for improved readability and maintainability; optimize performance in key functions.

2025-12-22 19:06:31 +02:00
parent dfaa2079aa
commit 4602ccc3a3
1444 changed files with 109919 additions and 8058 deletions
--- a/src/__Libraries/StellaOps.Replay/Loaders/FeedSnapshotLoader.cs
+++ b/src/__Libraries/StellaOps.Replay/Loaders/FeedSnapshotLoader.cs
@@ -0,0 +1,82 @@
+using System.Security.Cryptography;
+using System.Text;
+using Microsoft.Extensions.Logging;
+using StellaOps.Canonicalization.Json;
+using StellaOps.Replay.Engine;
+using StellaOps.Testing.Manifests.Models;
+
+namespace StellaOps.Replay.Loaders;
+
+public sealed class FeedSnapshotLoader : IFeedLoader
+{
+    private readonly IFeedStorage _storage;
+    private readonly ILogger<FeedSnapshotLoader> _logger;
+
+    public FeedSnapshotLoader(IFeedStorage storage, ILogger<FeedSnapshotLoader> logger)
+    {
+        _storage = storage;
+        _logger = logger;
+    }
+
+    public async Task<FeedSnapshot> LoadByDigestAsync(string digest, CancellationToken ct = default)
+    {
+        _logger.LogDebug("Loading feed snapshot with digest {Digest}", digest);
+
+        var localPath = GetLocalPath(digest);
+        if (File.Exists(localPath))
+        {
+            var feed = await LoadFromFileAsync(localPath, ct).ConfigureAwait(false);
+            VerifyDigest(feed, digest);
+            return feed;
+        }
+
+        var storedFeed = await _storage.GetByDigestAsync(digest, ct).ConfigureAwait(false);
+        if (storedFeed is not null)
+        {
+            VerifyDigest(storedFeed, digest);
+            return storedFeed;
+        }
+
+        throw new FeedNotFoundException($"Feed snapshot not found: {digest}");
+    }
+
+    private static void VerifyDigest(FeedSnapshot feed, string expected)
+    {
+        var actual = ComputeDigest(feed);
+        if (!string.Equals(actual, expected, StringComparison.OrdinalIgnoreCase))
+        {
+            throw new DigestMismatchException($"Feed digest mismatch: expected {expected}, got {actual}");
+        }
+    }
+
+    private static string ComputeDigest(FeedSnapshot feed)
+    {
+        var json = CanonicalJsonSerializer.Serialize(feed);
+        return Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(json))).ToLowerInvariant();
+    }
+
+    private static string GetLocalPath(string digest) =>
+        Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
+            "stellaops", "feeds", digest[..2], digest);
+
+    private static async Task<FeedSnapshot> LoadFromFileAsync(string path, CancellationToken ct)
+    {
+        var json = await File.ReadAllTextAsync(path, ct).ConfigureAwait(false);
+        return CanonicalJsonSerializer.Deserialize<FeedSnapshot>(json);
+    }
+}
+
+public interface IFeedStorage
+{
+    Task<FeedSnapshot?> GetByDigestAsync(string digest, CancellationToken ct = default);
+}
+
+public sealed class FeedNotFoundException : Exception
+{
+    public FeedNotFoundException(string message) : base(message) { }
+}
+
+public sealed class DigestMismatchException : Exception
+{
+    public DigestMismatchException(string message) : base(message) { }
+}
--- a/src/__Libraries/StellaOps.Replay/Loaders/PolicySnapshotLoader.cs
+++ b/src/__Libraries/StellaOps.Replay/Loaders/PolicySnapshotLoader.cs
@@ -0,0 +1,77 @@
+using System.Security.Cryptography;
+using System.Text;
+using Microsoft.Extensions.Logging;
+using StellaOps.Canonicalization.Json;
+using StellaOps.Replay.Engine;
+using StellaOps.Testing.Manifests.Models;
+
+namespace StellaOps.Replay.Loaders;
+
+public sealed class PolicySnapshotLoader : IPolicyLoader
+{
+    private readonly IPolicyStorage _storage;
+    private readonly ILogger<PolicySnapshotLoader> _logger;
+
+    public PolicySnapshotLoader(IPolicyStorage storage, ILogger<PolicySnapshotLoader> logger)
+    {
+        _storage = storage;
+        _logger = logger;
+    }
+
+    public async Task<PolicySnapshot> LoadByDigestAsync(string digest, CancellationToken ct = default)
+    {
+        _logger.LogDebug("Loading policy snapshot with digest {Digest}", digest);
+
+        var localPath = GetLocalPath(digest);
+        if (File.Exists(localPath))
+        {
+            var policy = await LoadFromFileAsync(localPath, ct).ConfigureAwait(false);
+            VerifyDigest(policy, digest);
+            return policy;
+        }
+
+        var stored = await _storage.GetByDigestAsync(digest, ct).ConfigureAwait(false);
+        if (stored is not null)
+        {
+            VerifyDigest(stored, digest);
+            return stored;
+        }
+
+        throw new PolicyNotFoundException($"Policy snapshot not found: {digest}");
+    }
+
+    private static void VerifyDigest(PolicySnapshot policy, string expected)
+    {
+        var actual = ComputeDigest(policy);
+        if (!string.Equals(actual, expected, StringComparison.OrdinalIgnoreCase))
+        {
+            throw new DigestMismatchException($"Policy digest mismatch: expected {expected}, got {actual}");
+        }
+    }
+
+    private static string ComputeDigest(PolicySnapshot policy)
+    {
+        var json = CanonicalJsonSerializer.Serialize(policy);
+        return Convert.ToHexString(SHA256.HashData(Encoding.UTF8.GetBytes(json))).ToLowerInvariant();
+    }
+
+    private static string GetLocalPath(string digest) =>
+        Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData),
+            "stellaops", "policies", digest[..2], digest);
+
+    private static async Task<PolicySnapshot> LoadFromFileAsync(string path, CancellationToken ct)
+    {
+        var json = await File.ReadAllTextAsync(path, ct).ConfigureAwait(false);
+        return CanonicalJsonSerializer.Deserialize<PolicySnapshot>(json);
+    }
+}
+
+public interface IPolicyStorage
+{
+    Task<PolicySnapshot?> GetByDigestAsync(string digest, CancellationToken ct = default);
+}
+
+public sealed class PolicyNotFoundException : Exception
+{
+    public PolicyNotFoundException(string message) : base(message) { }
+}