semi implemented and features implemented save checkpoint

This commit is contained in:
master
2026-02-08 18:00:49 +02:00
parent 04360dff63
commit 1bf6bbf395
20895 changed files with 716795 additions and 64 deletions

View File

@@ -0,0 +1,14 @@
# SOLID Review - INotificationPublisher
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/Abstractions.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (INotificationPublisher, UnknownsBand, IUnknownsMetrics, UnknownsMetrics); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GreyQueueWatchdogService
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/GreyQueueWatchdogService.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (GreyQueueWatchdogService, GreyQueueWatchdogOptions, WatchdogStats, StuckProcessingAlert, EntryFailedNotification, ForcedRetryNotification, IGreyQueueRepository); responsibilities may be bundled.
## Maintainability Notes
- File length 338 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - UnknownsLifecycleService
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/UnknownsLifecycleService.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownsLifecycleService, UnknownsLifecycleOptions, IEventSubscriber, EpssUpdatedEvent, KevAddedEvent, DeploymentCreatedEvent, RuntimeUpdatedEvent, RuntimeObservationType, UnknownEscalatedNotification, UnknownDemotedNotification, UnknownExpiredNotification, GreyQueueRepositoryExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 427 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - UnknownsMetricsService
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/UnknownsMetricsService.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownsMetricsService, UnknownsMetricsOptions, UnknownsLogging, TraceContextPropagation); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 334 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,16 @@
# SOLID Review - UnknownsSlaHealthCheck
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/UnknownsSlaHealthCheck.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownsSlaHealthCheck, UnknownsSlaHealthCheckExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - UnknownsSlaMonitorService
## Scope
- File: src/Unknowns/StellaOps.Unknowns.Services/UnknownsSlaMonitorService.cs
- Project: src/Unknowns/StellaOps.Unknowns.Services/StellaOps.Unknowns.Services.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownsSlaMonitorService, UnknownsSlaOptions, UnknownsBand, SlaWarningNotification, SlaBreachNotification); responsibilities may be bundled.
## Maintainability Notes
- File length 226 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - GreyQueueEndpoints
## Scope
- File: src/Unknowns/StellaOps.Unknowns.WebService/Endpoints/GreyQueueEndpoints.cs
- Project: src/Unknowns/StellaOps.Unknowns.WebService/StellaOps.Unknowns.WebService.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (GreyQueueEndpoints, GreyQueueListResponse, GreyQueueEntryDto, GreyQueueSummaryDto, EnqueueGreyQueueRequest, EvidenceBundleDto, TriggersDto, FeedTriggerDto, ToolTriggerDto, RecordResultRequest, ResolveEntryRequest, DismissEntryRequest, ExpireResultResponse, AssignForReviewRequest, EscalateRequest, RejectRequest, ReopenRequest, ValidTransitionsResponse, EscalationNotification, INotificationPublisher); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 815 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,17 @@
# SOLID Review - UnknownsEndpoints
## Scope
- File: src/Unknowns/StellaOps.Unknowns.WebService/Endpoints/UnknownsEndpoints.cs
- Project: src/Unknowns/StellaOps.Unknowns.WebService/StellaOps.Unknowns.WebService.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownsEndpoints, UnknownsListResponse, UnknownDto, ProvenanceHintsResponse, ProvenanceHintDto, SuggestedActionDto, UnknownHistoryResponse, UnknownHistoryEntry, UnknownsSummaryResponse); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 425 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/StellaOps.Unknowns.WebService/Program.cs
- Project: src/Unknowns/StellaOps.Unknowns.WebService/StellaOps.Unknowns.WebService.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - ServiceCollectionExtensions
## Scope
- File: src/Unknowns/StellaOps.Unknowns.WebService/ServiceCollectionExtensions.cs
- Project: src/Unknowns/StellaOps.Unknowns.WebService/StellaOps.Unknowns.WebService.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ServiceCollectionExtensions, DatabaseHealthCheck); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IProvenanceHintBuilder
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Hints/IProvenanceHintBuilder.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IProvenanceHintBuilder, BuildIdMatchResult); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Hints/ProvenanceHintBuilder.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 445 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - GreyQueueEntry
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/GreyQueueEntry.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (GreyQueueEntry, GreyQueueStatus, GreyQueueStateMachine, GreyQueueReason, GreyQueueResolution); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 380 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - N
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/NativeUnknownContext.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - BuildIdEvidence
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/ProvenanceEvidence.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BuildIdEvidence, DebugLinkEvidence, ImportFingerprintEvidence, ExportFingerprintEvidence, FingerprintMatch, SectionLayoutEvidence, SectionInfo, LayoutMatch, CompilerEvidence, DistroPatternEvidence, VersionStringEvidence, ExtractedVersionString, CorpusMatchEvidence); responsibilities may be bundled.
## Maintainability Notes
- File length 206 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ProvenanceHint
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/ProvenanceHint.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ProvenanceHint, SuggestedAction, ProvenanceEvidence); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ProvenanceHintType
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/ProvenanceHintType.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (ProvenanceHintType, HintConfidence); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - Unknown
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/Unknown.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (Unknown, UnknownSubjectType, UnknownKind, UnknownSeverity, ResolutionType, TriageBand); responsibilities may be bundled.
## Maintainability Notes
- File length 301 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - BlastRadius
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Models/UnknownRanking.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (BlastRadius, ExploitPressure, ContainmentSignals, UnknownItem); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IUnknownPersister
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Persistence/IUnknownPersister.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IUnknownPersister, UnknownInput); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IGreyQueueRepository
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Repositories/IGreyQueueRepository.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IGreyQueueRepository, GreyQueueEvidenceBundle, GreyQueueTriggers, FeedTrigger, ToolTrigger, GreyQueueSummary); responsibilities may be bundled.
## Maintainability Notes
- File length 371 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IUnknownRepository
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Repositories/IUnknownRepository.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IUnknownRepository, TriageSummary); responsibilities may be bundled.
## Maintainability Notes
- File length 228 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - N
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Services/NativeUnknownClassifier.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 255 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IRuntimeSignalIngester
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Services/RuntimeSignalIngester.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IRuntimeSignalIngester, RuntimeSignalData, SecurityContextData, NetworkPolicyData, ResourceData, ContainmentSignalResult, RuntimeSignalIngester, IRuntimeSignalStore, InMemoryRuntimeSignalStore); responsibilities may be bundled.
## Maintainability Notes
- File length 377 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - IUnknownProofEmitter
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Services/UnknownProofEmitter.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IUnknownProofEmitter, UnknownProofEmitter, UnknownProofExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 207 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,16 @@
# SOLID Review - IUnknownRanker
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/Services/UnknownRanker.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (IUnknownRanker, UnknownRanker, RankingWeights, UnknownRankingExtensions); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/UnknownsServiceExtensions.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Core/StellaOps.Unknowns.Core.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/Context/UnknownsDbContext.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/StellaOps.Unknowns.Persistence.EfCore.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/Extensions/UnknownsPersistenceExtensions.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/StellaOps.Unknowns.Persistence.EfCore.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - UnknownEfRepository
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/Repositories/UnknownEfRepository.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence.EfCore/StellaOps.Unknowns.Persistence.EfCore.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: file defines multiple types (UnknownEfRepository, UnknownDto, KindCount, SeverityCount, CountResult); responsibilities may be bundled.
## Maintainability Notes
- File length 316 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/EfCore/Context/UnknownsDbContext.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/StellaOps.Unknowns.Persistence.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/EfCore/Repositories/UnknownEfRepository.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/StellaOps.Unknowns.Persistence.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 259 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/Extensions/UnknownsPersistenceExtensions.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/StellaOps.Unknowns.Persistence.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/Postgres/PostgresUnknownPersister.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/StellaOps.Unknowns.Persistence.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/Postgres/Repositories/PostgresUnknownRepository.cs
- Project: src/Unknowns/__Libraries/StellaOps.Unknowns.Persistence/StellaOps.Unknowns.Persistence.csproj
- Date (UTC): 2026-01-30
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 1004 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - H
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Hints/HintCombinationTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 216 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Hints/ProvenanceHintBuilderTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 282 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ProvenanceHintSerializationTests
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Hints/ProvenanceHintSerializationTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ProvenanceHintSerializationTests, FrozenTimeProvider); responsibilities may be bundled.
## Maintainability Notes
- File length 299 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - G
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Models/GreyQueueEntryTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 241 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GreyQueueWatchdogServiceTests
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/GreyQueueWatchdogServiceTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GreyQueueWatchdogServiceTests, TestNotificationPublisher); responsibilities may be bundled.
## Maintainability Notes
- File length 348 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - N
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/NativeUnknownClassifierTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 259 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/UnknownRankerTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 365 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - UnknownsLifecycleServiceIntegrationTests
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/UnknownsLifecycleServiceIntegrationTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (UnknownsLifecycleServiceIntegrationTests, TestEventSubscriber); responsibilities may be bundled.
## Maintainability Notes
- File length 368 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - UnknownsSlaMonitorIntegrationTests
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/UnknownsSlaMonitorIntegrationTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (UnknownsSlaMonitorIntegrationTests, TestNotificationPublisher, NullLogger); responsibilities may be bundled.
## Maintainability Notes
- File length 270 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - UnknownsSlaMonitorServiceTests
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/Services/UnknownsSlaMonitorServiceTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Core.Tests/StellaOps.Unknowns.Core.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (UnknownsSlaMonitorServiceTests, SlaCalculator, FakeTimeProvider); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 341 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.Persistence.Tests/PostgresUnknownRepositoryTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.Persistence.Tests/StellaOps.Unknowns.Persistence.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 366 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - U
## Scope
- File: src/Unknowns/__Tests/StellaOps.Unknowns.WebService.Tests/UnknownsEndpointsTests.cs
- Project: src/Unknowns/__Tests/StellaOps.Unknowns.WebService.Tests/StellaOps.Unknowns.WebService.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 391 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.