semi implemented and features implemented save checkpoint

This commit is contained in:
master
2026-02-08 18:00:49 +02:00
parent 04360dff63
commit 1bf6bbf395
20895 changed files with 716795 additions and 64 deletions

View File

@@ -0,0 +1,15 @@
# SOLID Review - EidasPlugin
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/EidasPlugin.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (EidasPlugin, EidasOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 519 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,16 @@
# SOLID Review - EtsiConformanceTestVectors
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Tests/EtsiConformanceTestVectors.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (EtsiConformanceTestVectors, CadesB, CadesT, CadesLT, CadesLTA, TimestampToken, EuTrustList, Oids); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/CadesSignatureBuilder.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 320 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - E
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/EidasTimestampingExtensions.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/EuTrustListService.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 407 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ICadesSignatureBuilder
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/ICadesSignatureBuilder.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ICadesSignatureBuilder, CadesSignatureOptions, CadesUpgradeOptions, CommitmentType, SignerLocation); responsibilities may be bundled.
## Maintainability Notes
- File length 211 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - IEuTrustListService
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/IEuTrustListService.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IEuTrustListService, TrustListEntry, ServiceStatus, ServiceStatusHistory); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IQualifiedTimestampVerifier
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/IQualifiedTimestampVerifier.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IQualifiedTimestampVerifier, QualifiedTimestampVerificationOptions, QualifiedTimestampVerificationResult, CadesVerificationResult); responsibilities may be bundled.
## Maintainability Notes
- File length 215 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - ITimestampModeSelector
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/ITimestampModeSelector.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ITimestampModeSelector, TimestampContext, TimestampPolicy); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,15 @@
# SOLID Review - QualifiedTimestampVerifier
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/QualifiedTimestampVerifier.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (QualifiedTimestampVerifier, TstInfoData); responsibilities may be bundled.
## Maintainability Notes
- File length 405 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - QualifiedTimestampingConfiguration
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/QualifiedTsaConfiguration.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (QualifiedTimestampingConfiguration, QualifiedTsaProvider, TsaAuthentication, TsaAuthType, TimestampPolicyOverride, OverrideMatchCriteria, EuTrustListConfiguration, TimestampMode, CadesLevel); responsibilities may be bundled.
## Maintainability Notes
- File length 258 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/Timestamping/TimestampModeSelector.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Eidas/StellaOps.Cryptography.Plugin.Eidas.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 218 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - FipsPlugin
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Fips/FipsPlugin.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Fips/StellaOps.Cryptography.Plugin.Fips.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (FipsPlugin, FipsOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 433 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - GostPlugin
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Gost/GostPlugin.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Gost/StellaOps.Cryptography.Plugin.Gost.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (GostPlugin, GostOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 344 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - HsmPlugin
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Hsm/HsmPlugin.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Hsm/StellaOps.Cryptography.Plugin.Hsm.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (HsmPlugin, HsmMechanism, IHsmClient, SimulatedHsmClient, Pkcs11HsmClient, HsmOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 479 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,17 @@
# SOLID Review - Pkcs11HsmClientImpl
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Hsm/Pkcs11HsmClientImpl.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Hsm/StellaOps.Cryptography.Plugin.Hsm.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (Pkcs11HsmClientImpl, MechanismFactory, SlotContext, Pkcs11HsmClientOptions, HsmKeyMetadata); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 719 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - SmPlugin
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin.Sm/SmPlugin.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin.Sm/StellaOps.Cryptography.Plugin.Sm.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SmPlugin, SmOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 366 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - C
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Plugin/CryptoPluginBase.cs
- Project: src/Cryptography/StellaOps.Cryptography.Plugin/StellaOps.Cryptography.Plugin.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Profiles.Ecdsa/EcdsaP256Signer.cs
- Project: src/Cryptography/StellaOps.Cryptography.Profiles.Ecdsa/StellaOps.Cryptography.Profiles.Ecdsa.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Profiles.EdDsa/Ed25519Signer.cs
- Project: src/Cryptography/StellaOps.Cryptography.Profiles.EdDsa/StellaOps.Cryptography.Profiles.EdDsa.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - E
## Scope
- File: src/Cryptography/StellaOps.Cryptography.Profiles.EdDsa/Ed25519Verifier.cs
- Project: src/Cryptography/StellaOps.Cryptography.Profiles.EdDsa/StellaOps.Cryptography.Profiles.EdDsa.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Cryptography/StellaOps.Cryptography/IContentSigner.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - I
## Scope
- File: src/Cryptography/StellaOps.Cryptography/IContentVerifier.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - CeremonyAuthorizedRecoveryService
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/CeremonyAuthorizedRecoveryService.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (CeremonyAuthorizedRecoveryService, ICeremonyAuthorizedRecoveryService, ICeremonyAuthorizationProvider, CeremonyAuthorizedRecoveryOptions, CeremonyAuthorizationRequest, KeyRecoveryOperationPayload, CeremonyCreationResult, CeremonyStatusInfo, RecoveryCeremonyInitResult, RecoveryCeremonyStatus, CeremonyOperationType, CeremonyState); responsibilities may be bundled.
## Maintainability Notes
- File length 385 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,16 @@
# SOLID Review - G
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/GaloisField256.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- File length 261 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IEscrowAgentStore
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/IEscrowAgentStore.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IEscrowAgentStore, KeyEscrowMetadata, IKeyEscrowAuditLogger, KeyEscrowAuditEvent, KeyEscrowAuditEventType); responsibilities may be bundled.
## Maintainability Notes
- File length 242 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - IKeyEscrowService
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/IKeyEscrowService.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (IKeyEscrowService, KeyEscrowOptions, KeyEscrowStatus, KeyEscrowSummary); responsibilities may be bundled.
## Maintainability Notes
- File length 208 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeyShare
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/KeyEscrowModels.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyShare, ShareEncryptionInfo, KeyEscrowResult, KeyRecoveryRequest, KeyRecoveryResult, EscrowAgent); responsibilities may be bundled.
## Maintainability Notes
- File length 255 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeyEscrowService
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/KeyEscrowService.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyEscrowService, KeyEscrowServiceOptions); responsibilities may be bundled.
## Maintainability Notes
- File length 507 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,15 @@
# SOLID Review - ShamirSecretSharing
## Scope
- File: src/Cryptography/StellaOps.Cryptography/KeyEscrow/ShamirSecretSharing.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (ShamirSecretSharing, ShamirShare); responsibilities may be bundled.
## Maintainability Notes
- File length 238 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - M
## Scope
- File: src/Cryptography/StellaOps.Cryptography/Models/MultiSignatureResult.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Cryptography/StellaOps.Cryptography/Models/Signature.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Cryptography/StellaOps.Cryptography/Models/SignatureResult.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - VerificationResult
## Scope
- File: src/Cryptography/StellaOps.Cryptography/Models/VerificationResult.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (VerificationResult, CertificateValidationResult, TimestampValidationResult); responsibilities may be bundled.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.

View File

@@ -0,0 +1,14 @@
# SOLID Review - M
## Scope
- File: src/Cryptography/StellaOps.Cryptography/MultiProfileSigner.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Cryptography/StellaOps.Cryptography/SignatureProfile.cs
- Project: src/Cryptography/StellaOps.Cryptography/StellaOps.Cryptography.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - SignatureProfileTests
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/CryptographyModelTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SignatureProfileTests, SignatureTests, SignatureResultTests, VerificationResultTests, CertificateValidationResultTests); responsibilities may be bundled.
## Maintainability Notes
- File length 318 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - Q
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/Eidas/QualifiedTsaProviderTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 289 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - T
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/Eidas/TimestampModeSelectorTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 385 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - P
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/Hsm/Pkcs11HsmClientIntegrationTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,16 @@
# SOLID Review - SoftHsmTestFixture
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/Hsm/SoftHsmTestFixture.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (SoftHsmTestFixture, SoftHsmConfig); responsibilities may be bundled.
- Dependency inversion: static utility types limit substitution; consider abstraction if behavior must vary.
## Maintainability Notes
- Multiple types in one file can blur ownership boundaries.
## Recommendations
- Split types into separate files grouped by responsibility.
- Consider interface-backed abstraction if alternate implementations are needed.

View File

@@ -0,0 +1,14 @@
# SOLID Review - K
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/KeyEscrow/KeyEscrowRecoveryIntegrationTests.Fixed.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- Minimal surface area; easy to reason about.
## Recommendations
- Keep as-is.

View File

@@ -0,0 +1,15 @@
# SOLID Review - KeyEscrowRecoveryIntegrationTests
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/KeyEscrow/KeyEscrowRecoveryIntegrationTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: file defines multiple types (KeyEscrowRecoveryIntegrationTests, MockTimeProvider, KeyEscrowStatusResult, IKeyEscrowService, IKeyEscrowAuditLogger, KeyEscrowAuditEvent, KeyEscrowAuditEventType, KeyRecoveryRequest, KeyRecoveryResult, KeyShare); responsibilities may be bundled.
## Maintainability Notes
- File length 531 lines; consider splitting for readability.
## Recommendations
- Split types into separate files grouped by responsibility.
- Extract helpers to reduce file size and complexity.

View File

@@ -0,0 +1,14 @@
# SOLID Review - S
## Scope
- File: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/ShamirSecretSharingTests.cs
- Project: src/Cryptography/__Tests/StellaOps.Cryptography.Tests/StellaOps.Cryptography.Tests.csproj
- Date (UTC): 2026-01-31
## Findings
- Single responsibility: single type definition; cohesive.
## Maintainability Notes
- File length 385 lines; consider splitting for readability.
## Recommendations
- Extract helpers to reduce file size and complexity.