stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity

semi implemented and features implemented save checkpoint

Browse Source
This commit is contained in:
master
2026-02-08 18:00:49 +02:00
parent 04360dff63
commit 1bf6bbf395
20895 changed files with 716795 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
docs/implplan-blocked/audits/csproj-standards/Notify/StellaOps.Notify.WebService/StellaOps.Notify.WebService.md Normal file
View File

@@ -0,0 +1,47 @@
# Audit - StellaOps.Notify.WebService
## Project
- Path: `src/Notify/StellaOps.Notify.WebService/StellaOps.Notify.WebService.csproj`
- Module: `Notify`
- Kind: `WebService`
- SDK: `Microsoft.NET.Sdk.Web`
- TargetFramework: `net10.0`
- Audit date (UTC): 2026-01-30
## Coding Standards Findings
- Status: FAIL
- Nullable: enable
- TreatWarningsAsErrors: explicit true
- Deterministic: inherited true
- 100-line rule violations: 5
- Service locator usage (BuildServiceProvider/GetService): 1
- Analyzer enforcement: missing repo-wide (see summary).
### Details
- 100-line files:
- `src/Notify/StellaOps.Notify.WebService/Program.cs` (1483 lines)
- `src/Notify/StellaOps.Notify.WebService/Services/NotifyChannelTestService.cs` (313 lines)
- `src/Notify/StellaOps.Notify.WebService/Services/NotifyChannelHealthService.cs` (182 lines)
- `src/Notify/StellaOps.Notify.WebService/Options/NotifyWebServiceOptions.cs` (150 lines)
- `src/Notify/StellaOps.Notify.WebService/Options/NotifyWebServiceOptionsValidator.cs` (121 lines)
- Service locator matches:
- `src/Notify/StellaOps.Notify.WebService/Program.cs`:319 var registry = scope.ServiceProvider.GetRequiredService<INotifyPluginRegistry>();
### Fix Guidance
- Split files over 100 lines into smaller types or partials.
- Replace service locator usage with constructor injection.
## Testing Fullness Findings
- Status: FAIL
- Expected layers: Unit, Integration, Security, Offline
- Detected test projects: src/Notify/__Tests/StellaOps.Notify.WebService.Tests/StellaOps.Notify.WebService.Tests.csproj [Unit]
- Missing layers: Integration, Security, Offline
### Manual checks required
- Observability contract tests for WebService/Worker.
- Offline execution (tests must run without network access).
### Fix Guidance
- Add integration tests for cross-component flows.
- Add security tests for authn/authz or input validation.
- Add offline/airgap coverage with fixtures only.