Refactor code structure for improved readability and maintainability; removed redundant code blocks and optimized function calls.

src/Notifier/StellaOps.Notifier/StellaOps.Notifier.Tests/HttpEgressSloSinkTests.cs

@@ -0,0 +1,89 @@
+using System.Net;
+using System.Net.Http;
+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging.Abstractions;
+using Microsoft.Extensions.Options;
+using StellaOps.Notifier.Worker.Options;
+using StellaOps.Notifier.Worker.Processing;
+using Xunit;
+
+namespace StellaOps.Notifier.Tests;
+
+public class HttpEgressSloSinkTests
+{
+    [Fact]
+    public async Task PublishAsync_NoWebhook_DoesNothing()
+    {
+        var handler = new StubHandler();
+        var sink = CreateSink(handler, new EgressSloOptions { Webhook = null });
+
+        await sink.PublishAsync(BuildContext(), CancellationToken.None);
+
+        Assert.Equal(0, handler.SendCount);
+    }
+
+    [Fact]
+    public async Task PublishAsync_SendsWebhookWithPayload()
+    {
+        var handler = new StubHandler();
+        var sink = CreateSink(handler, new EgressSloOptions { Webhook = "https://example.test/slo", TimeoutSeconds = 5 });
+
+        await sink.PublishAsync(BuildContext(), CancellationToken.None);
+
+        Assert.Equal(1, handler.SendCount);
+        var request = handler.LastRequest!;
+        Assert.Equal(HttpMethod.Post, request.Method);
+        Assert.Equal("https://example.test/slo", request.RequestUri!.ToString());
+    }
+
+    private static HttpEgressSloSink CreateSink(HttpMessageHandler handler, EgressSloOptions options)
+    {
+        var factory = new StubHttpClientFactory(handler);
+        return new HttpEgressSloSink(factory, Options.Create(options), NullLogger<HttpEgressSloSink>.Instance);
+    }
+
+    private static EgressSloContext BuildContext()
+    {
+        var evt = Notify.Models.NotifyEvent.Create(
+            Guid.NewGuid(),
+            kind: "policy.violation",
+            tenant: "tenant-a",
+            ts: DateTimeOffset.UtcNow,
+            payload: new System.Text.Json.Nodes.JsonObject(),
+            actor: "tester",
+            version: "1");
+
+        var ctx = EgressSloContext.FromNotifyEvent(evt);
+        ctx.AddDelivery("Slack", "tmpl", evt.Kind);
+        return ctx;
+    }
+
+    private sealed class StubHandler : HttpMessageHandler
+    {
+        public int SendCount { get; private set; }
+        public HttpRequestMessage? LastRequest { get; private set; }
+
+        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
+        {
+            SendCount++;
+            LastRequest = request;
+            return Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK));
+        }
+    }
+
+    private sealed class StubHttpClientFactory : IHttpClientFactory
+    {
+        private readonly HttpMessageHandler _handler;
+
+        public StubHttpClientFactory(HttpMessageHandler handler)
+        {
+            _handler = handler;
+        }
+
+        public HttpClient CreateClient(string name)
+        {
+            return new HttpClient(_handler, disposeHandler: false);
+        }
+    }
+}

src/Notifier/StellaOps.Notifier/StellaOps.Notifier.Tests/Support/TestEgressSloSink.cs

@@ -0,0 +1,20 @@
+using System.Collections.Concurrent;
+using System.Collections.Generic;
+using System.Threading;
+using System.Threading.Tasks;
+using StellaOps.Notifier.Worker.Processing;
+
+namespace StellaOps.Notifier.Tests.Support;
+
+public sealed class TestEgressSloSink : IEgressSloSink
+{
+    private readonly ConcurrentBag<EgressSloContext> _contexts = new();
+
+    public IReadOnlyCollection<EgressSloContext> Contexts => _contexts;
+
+    public Task PublishAsync(EgressSloContext context, CancellationToken cancellationToken)
+    {
+        _contexts.Add(context);
+        return Task.CompletedTask;
+    }
+}