stella-ops.org/git.stella-ops.org
1
0
Fork 0
Code Issues Pull Requests Actions 2 Releases Wiki Activity

Fix 36 test failures: withRetry for 504s, domcontentloaded for UI, aggregation UI test

Browse Source 
Three fixes resolving the cascading test failures:

1. Add withRetry() to integrations.e2e.spec.ts advisory section — the
   6 API tests that 504'd on Concelier transport now retry up to 2x

2. Change all UI test page.goto from networkidle to domcontentloaded
   across 9 test files — networkidle never fires when Angular XHR
   calls 504, causing 30 UI tests to timeout. domcontentloaded fires
   when HTML is parsed, then 3s wait lets Angular render.

3. Fix test dependencies — vault-consul-secrets detail test now creates
   its own integration instead of depending on prior test state.

New test: catalog page aggregation report — verifies the advisory
source catalog page shows stats bar metrics and per-source freshness
data (the UI we built earlier this session).

Files changed: integrations.e2e.spec.ts, vault-consul-secrets, ui-*,
runtime-hosts, gitlab-integration, error-resilience, aaa-advisory-sync

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
master
2026-04-02 15:45:37 +03:00
parent 407a00f409
commit 0aaadef8e7
10 changed files with 132 additions and 283 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
src/Web/StellaOps.Web/tests/e2e/integrations/integrations.e2e.spec.ts
View File

@@ -24,6 +24,20 @@ const SCREENSHOT_DIR = 'e2e/screenshots/integrations';
const BASE = process.env['PLAYWRIGHT_BASE_URL'] || 'https://stella-ops.local';
const runId = process.env['E2E_RUN_ID'] || 'run1';
/** Retry on 504 gateway timeout (Valkey transport to Concelier) */
async function withRetry(
fn: () => Promise<any>,
maxRetries = 2,
delayMs = 3_000,
): Promise<any> {
for (let attempt = 0; attempt <= maxRetries; attempt++) {
const resp = await fn();
if (resp.status() !== 504) return resp;
if (attempt < maxRetries) await new Promise(r => setTimeout(r, delayMs));
}
return await fn();
}
// ---------------------------------------------------------------------------
// Helpers
// ---------------------------------------------------------------------------
@@ -273,7 +287,7 @@ test.describe('Integration Services — Connector Lifecycle', () => {
await page.getByRole('button', { name: /sign in/i }).click();
await page.waitForURL(`${BASE}/**`, { timeout: 15_000 });
}
await page.waitForLoadState('networkidle');
await page.waitForLoadState('domcontentloaded');
const token = await page.evaluate(() => {
const s = sessionStorage.getItem('stellaops.auth.session.full');
@@ -323,7 +337,7 @@ test.describe('Integration Services — Advisory Sources', () => {
test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
test('GET /catalog returns full source catalog with metadata', async ({ apiRequest }) => {
const resp = await apiRequest.get('/api/v1/advisory-sources/catalog');
const resp = await withRetry(() => apiRequest.get('/api/v1/advisory-sources/catalog'));
expect(resp.status()).toBe(200);
const body = await resp.json();
@@ -340,7 +354,7 @@ test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
});
test('GET /status returns enabled/disabled state for all sources', async ({ apiRequest }) => {
const resp = await apiRequest.get('/api/v1/advisory-sources/status');
const resp = await withRetry(() => apiRequest.get('/api/v1/advisory-sources/status'));
expect(resp.status()).toBe(200);
const body = await resp.json();
@@ -353,25 +367,25 @@ test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
const sourceId = 'nvd';
// Disable first
const disableResp = await apiRequest.post(`/api/v1/advisory-sources/${sourceId}/disable`);
const disableResp = await withRetry(() => apiRequest.post(`/api/v1/advisory-sources/${sourceId}/disable`));
expect(disableResp.status()).toBe(200);
const disableBody = await disableResp.json();
expect(disableBody.enabled).toBe(false);
// Verify disabled in status
const statusResp1 = await apiRequest.get('/api/v1/advisory-sources/status');
const statusResp1 = await withRetry(() => apiRequest.get('/api/v1/advisory-sources/status'));
const status1 = await statusResp1.json();
const nvdStatus1 = status1.sources.find((s: any) => s.sourceId === sourceId);
expect(nvdStatus1.enabled).toBe(false);
// Re-enable
const enableResp = await apiRequest.post(`/api/v1/advisory-sources/${sourceId}/enable`);
const enableResp = await withRetry(() => apiRequest.post(`/api/v1/advisory-sources/${sourceId}/enable`));
expect(enableResp.status()).toBe(200);
const enableBody = await enableResp.json();
expect(enableBody.enabled).toBe(true);
// Verify enabled in status
const statusResp2 = await apiRequest.get('/api/v1/advisory-sources/status');
const statusResp2 = await withRetry(() => apiRequest.get('/api/v1/advisory-sources/status'));
const status2 = await statusResp2.json();
const nvdStatus2 = status2.sources.find((s: any) => s.sourceId === sourceId);
expect(nvdStatus2.enabled).toBe(true);
@@ -405,12 +419,12 @@ test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
});
test('POST /{sourceId}/sync returns 404 for unknown source', async ({ apiRequest }) => {
const resp = await apiRequest.post('/api/v1/advisory-sources/nonexistent-source-xyz/sync');
const resp = await withRetry(() => apiRequest.post('/api/v1/advisory-sources/nonexistent-source-xyz/sync'));
expect(resp.status()).toBe(404);
});
test('GET /summary returns freshness aggregation', async ({ apiRequest }) => {
const resp = await apiRequest.get('/api/v1/advisory-sources/summary');
const resp = await withRetry(() => apiRequest.get('/api/v1/advisory-sources/summary'));
expect(resp.status()).toBe(200);
const body = await resp.json();
@@ -449,9 +463,9 @@ test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
const sourceIds = ['nvd', 'osv', 'cve'];
// Batch disable
const disableResp = await apiRequest.post('/api/v1/advisory-sources/batch-disable', {
const disableResp = await withRetry(() => apiRequest.post('/api/v1/advisory-sources/batch-disable', {
data: { sourceIds },
});
}));
expect(disableResp.status()).toBe(200);
const disableBody = await disableResp.json();
expect(disableBody.results.length).toBe(3);
@@ -460,9 +474,9 @@ test.describe('Integration Services — Advisory Source Sync Lifecycle', () => {
}
// Batch re-enable
const enableResp = await apiRequest.post('/api/v1/advisory-sources/batch-enable', {
const enableResp = await withRetry(() => apiRequest.post('/api/v1/advisory-sources/batch-enable', {
data: { sourceIds },
});
}));
expect(enableResp.status()).toBe(200);
const enableBody = await enableResp.json();
expect(enableBody.results.length).toBe(3);
@@ -601,7 +615,7 @@ test.describe('Integration Services — Connector CRUD & Status', () => {
test.describe('Integration Services — UI Verification', () => {
test('landing page redirects to first populated tab or shows onboarding', async ({ liveAuthPage: page }) => {
await page.goto(`${BASE}/setup/integrations`, { waitUntil: 'networkidle', timeout: 30_000 });
await page.goto(`${BASE}/setup/integrations`, { waitUntil: 'domcontentloaded', timeout: 45_000 });
await page.waitForLoadState('domcontentloaded');
await page.waitForTimeout(3_000);
@@ -616,7 +630,7 @@ test.describe('Integration Services — UI Verification', () => {
});
test('Registries tab lists registry integrations', async ({ liveAuthPage: page }) => {
await page.goto(`${BASE}/setup/integrations/registries`, { waitUntil: 'networkidle', timeout: 30_000 });
await page.goto(`${BASE}/setup/integrations/registries`, { waitUntil: 'domcontentloaded', timeout: 45_000 });
await page.waitForTimeout(2_000);
const heading = page.getByRole('heading', { name: /registry/i });
@@ -631,7 +645,7 @@ test.describe('Integration Services — UI Verification', () => {
});
test('SCM tab lists SCM integrations', async ({ liveAuthPage: page }) => {
await page.goto(`${BASE}/setup/integrations/scm`, { waitUntil: 'networkidle', timeout: 30_000 });
await page.goto(`${BASE}/setup/integrations/scm`, { waitUntil: 'domcontentloaded', timeout: 45_000 });
await page.waitForTimeout(2_000);
const heading = page.getByRole('heading', { name: /scm/i });
@@ -645,7 +659,7 @@ test.describe('Integration Services — UI Verification', () => {
});
test('CI/CD tab lists CI/CD integrations', async ({ liveAuthPage: page }) => {
await page.goto(`${BASE}/setup/integrations/ci`, { waitUntil: 'networkidle', timeout: 30_000 });
await page.goto(`${BASE}/setup/integrations/ci`, { waitUntil: 'domcontentloaded', timeout: 45_000 });
await page.waitForTimeout(2_000);
const heading = page.getByRole('heading', { name: /ci\/cd/i });
@@ -659,7 +673,7 @@ test.describe('Integration Services — UI Verification', () => {
});
test('tab switching navigates between all tabs', async ({ liveAuthPage: page }) => {
await page.goto(`${BASE}/setup/integrations`, { waitUntil: 'networkidle', timeout: 30_000 });
await page.goto(`${BASE}/setup/integrations`, { waitUntil: 'domcontentloaded', timeout: 45_000 });
await page.waitForTimeout(2_000);
const tabs = ['Registries', 'SCM', 'CI/CD', 'Runtimes / Hosts', 'Advisory & VEX', 'Secrets'];